Received-SPF: pass (google.com: domain of linux-kernel+bounces-56722-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Wed, 7 Feb 2024 15:30:16 +0000
From: Mark Brown <broonie@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Shenghao Ding <shenghao-ding@ti.com>, lgirdwood@gmail.com,
	perex@perex.cz, pierre-louis.bossart@linux.intel.com,
	13916275206@139.com, alsa-devel@alsa-project.org,
	linux-kernel@vger.kernel.org, liam.r.girdwood@intel.com,
	bard.liao@intel.com, mengdong.lin@intel.com,
	yung-chuan.liao@linux.intel.com, baojun.xu@ti.com, kevin-lu@ti.com,
	navada@ti.com, tiwai@suse.de, soyer@irl.hu
Subject: Re: [PATCH v7] ASoc: tas2783: Add tas2783 codec driver
Message-ID: <ZcOiCFlqsnyAEgl3@finisterre.sirena.org.uk>
References: <20240207054743.1504-1-shenghao-ding@ti.com>
 <ZcOWZlXu1fL_haFU@smile.fi.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="vE1mhbGjFNiuNYDa"
Content-Disposition: inline
In-Reply-To: <ZcOWZlXu1fL_haFU@smile.fi.intel.com>


--vE1mhbGjFNiuNYDa
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Feb 07, 2024 at 04:40:38PM +0200, Andy Shevchenko wrote:
> On Wed, Feb 07, 2024 at 01:47:42PM +0800, Shenghao Ding wrote:

> > +static const struct regmap_config tasdevice_regmap = {
> > +	.reg_bits = 32,
> > +	.val_bits = 8,
> > +	.readable_reg = tas2783_readable_register,
> > +	.volatile_reg = tas2783_volatile_register,

> > +	.max_register = 0x44ffffff,

> I'm always wondering how this can work in debugfs when one tries to dump all
> registers...

regmap will filter out non-readable registers from what it shows in
debugfs so sparse regmaps will end up much smaller than they might look.
The debugfs code also has support for seeking into the output (since
each register is a fixed size) so we'll only actually render whatever is
being read in an individual read().

> > +static const struct dev_pm_ops tas2783_sdca_pm = {
> > +	SET_SYSTEM_SLEEP_PM_OPS(tas2783_sdca_dev_suspend,
> > +		tas2783_sdca_dev_resume)
> > +	SET_RUNTIME_PM_OPS(tas2783_sdca_dev_suspend,
> > +		tas2783_sdca_dev_resume, NULL)
> > +};

> Use new PM macros.

..which are?

--vE1mhbGjFNiuNYDa
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEyBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmXDoggACgkQJNaLcl1U
h9C60gf1GOfWTgnrzFxR9xa5hmkPBPAi1Ojd3JfrzPlUXJfieLeZWc2wwlEbDLsA
yNTO21FqNRRdtrRAay4kRZBBFuam/4RwDef616jFc6lY61hkvPz/CeUSZ9X4Oqa1
nFnGaVmNNKxEdhM/J4cDsxjdhIpsUa/ib+rhwZGv2vXWxMlQhAbfQneSIKuedTfz
z+kXD1kegP9QWiqQzHsko8X/qBQjk/TfPYhjOSZni8hgKAmb5xY35jgcba3qZj0b
ndwz0c749lcBm7ojhrV14jeGmZwH2RmvHHxy76Csw9cKnRoOUuKs5eU6Wvh+yqOZ
FueTF3iS+xTteyTeDrGeO3T2+w16
=rb8K
-----END PGP SIGNATURE-----

--vE1mhbGjFNiuNYDa--