Received-SPF: pass (google.com: domain of linux-kernel+bounces-56737-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 7 Feb 2024 15:46:39 +0000
From: Mark Brown <broonie@kernel.org>
To: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
	thomas.petazzoni@bootlin.com,
	Miquel Raynal <miquel.raynal@bootlin.com>, yen-mei.goh@keysight.com,
	koon-kee.lie@keysight.com
Subject: Re: [PATCH 2/2] spi: omap2-mcspi: Add support for MULTI-mode
Message-ID: <ZcOl39IRjYpKBaY/@finisterre.sirena.org.uk>
References: <20240126-spi-omap2-mcspi-multi-mode-v1-0-d143d33f0fe0@bootlin.com>
 <20240126-spi-omap2-mcspi-multi-mode-v1-2-d143d33f0fe0@bootlin.com>
 <ZcIQVKibMmGegw+j@finisterre.sirena.org.uk>
 <ZcOg3JR9YW9JNxPp@localhost.localdomain>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="GiOcMxJhFbMI+zb+"
Content-Disposition: inline
In-Reply-To: <ZcOg3JR9YW9JNxPp@localhost.localdomain>


--GiOcMxJhFbMI+zb+
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 07, 2024 at 04:25:16PM +0100, Louis Chauvet wrote:
> Le 06/02/24 - 10:56, Mark Brown a =E9crit :

> this addition following the above paragraph, would it be clearer?
>=20
>   [...] this delay).
>=20
>   The OMAP2 MCSPI device can use two different mode to send messages:
>   SINGLE and MULTI:
>   In SINGLE mode, the controller only leverages one single FIFO, and the=
=20
>   host system has to manually select the CS it wants to enable.
>   In MULTI mode, each CS is bound to a FIFO, the host system then writes=
=20
>   the data to the relevant FIFO, as the hardware will take care of the CS
>=20
>   The drawback [...]

Yes.

> > Note that you may not have to tell the hardware the same word length as
> > the transfer specifies, so long as the wire result is the same it
> > doesn't matter.

> If I understand correclty what you want is: given a message, containing 2
> transfers of 4 bits, with cs_change disabled, use the multi mode and send=
=20
> only one 8 bits transfer instead of two 4 bits transfer?

> This seems very complex to implement, and will only benefit in very=20
> niche cases.

I was hoping that the hardware supports more than 8 bit words, in that
case then it gets useful for common operations like 8 bit register 8 bit
data register writes (and more for larger word sizes) which are
relatively simple.  If it's just 8 bit words then yes, totally not worth
the effort.

> If I have to add this, I have to:
> - detect the very particular pattern "message of multiple transfer and=20
> those transfer can be packed in bigger transfer"

Or just a single transfer with two words, it's trivial cases that don't
involve rewriting anything beyond lying about the word lengths that I
was thinking of.  Anything more involved should go in the core.

--GiOcMxJhFbMI+zb+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmXDpd8ACgkQJNaLcl1U
h9Awrwf/WSYL6hHrh/2g0K1QaxQHkaAT7BJB5ucVs/dXYdcO+hJjrYDUBuH6311T
MzzGtEFiHDtQ8SPa67gGZZXW96cbvYq2cyuJektuNUBhravfAo6pOMWH4Q2yUfDd
SZGldheoY5K4XUesqDfPJAdPgmDHFTfiSP9+LhD+RkTSSqihspOZsPruljGgIKNL
nHYKx2D5D8SnfHanImpy+OfImPLF4WuwkowgPbjprPuC8xV118/VN6sRBn6qfxGU
Pmu3b0srLXnKnJvHPOBPFDowOfWnQQ7UEAl1I/7Vngnl1erVBWmVfr+L99qCyjSr
s4wK91UIpdR7yWP8XZjOc/lZIupA5A==
=VH6Q
-----END PGP SIGNATURE-----

--GiOcMxJhFbMI+zb+--