Received-SPF: pass (google.com: domain of linux-kernel+bounces-56736-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Wed, 7 Feb 2024 07:45:50 -0800
From: Ira Weiny <ira.weiny@intel.com>
To: "Fabio M. De Francesco" <fabio.maria.de.francesco@linux.intel.com>, "Peter
 Zijlstra" <peterz@infradead.org>, Dan Williams <dan.j.williams@intel.com>
CC: <linux-kernel@vger.kernel.org>, kernel test robot <lkp@intel.com>,
	<oe-kbuild-all@lists.linux.dev>, <linux-cxl@vger.kernel.org>, Dave Jiang
	<dave.jiang@intel.com>, Jonathan Cameron <Jonathan.Cameron@huawei.com>, "Ingo
 Molnar" <mingo@kernel.org>, Ira Weiny <ira.weiny@intel.com>
Subject: Re: [PATCH 2/2 v3] cxl/region: Use cond_guard() in show_targetN()
Message-ID: <65c3a5aed6291_3aceba2947b@iweiny-mobl.notmuch>
References: <20240206121301.7225-3-fabio.maria.de.francesco@linux.intel.com>
 <202402070919.0zuYCxMS-lkp@intel.com>
 <4546212.LvFx2qVVIh@fdefranc-mobl3>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <4546212.LvFx2qVVIh@fdefranc-mobl3>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DCgAaCSAXW4cljpsuiQVtTCKGLHZbNlfcEJtc6/oESDo9PGXsRx0lQzUb42T?=
 =?us-ascii?Q?dZvGhfjtZmnnJvaq7qxnqz13ERwBvE5asWYmW3NxpOHSji6Udv1RuLJ3bUKA?=
 =?us-ascii?Q?YtpQb4dE6khv6C/RbmGjE+ye5N0lTxx+PbkUro11fnSjKVwQyUCs9q2DREnf?=
 =?us-ascii?Q?A9MaISWZ3JE6tXsIsTCCdSoHwyb5CnASRQptV0ul7HtamYMzIIuqzgnkjPAN?=
 =?us-ascii?Q?cud6HWSmk3poQbMysqbX/z+PNd79Zc+teCguaL9cphBU/GjHL16ZvCFADZ/P?=
 =?us-ascii?Q?d3V4KEIIu10A/+z9Av/7czuoshKxNarBRPYbc7YrYRUz0qUVLGWPbg2txbSG?=
 =?us-ascii?Q?wrQ5wMXjt76SWBs0GiBFwvAwiu6XRqQjY0EeEL/qKinCjRKyFuF6qP2NjHuF?=
 =?us-ascii?Q?u47/qhH5zwfCREtfxqZlChGINCeddAjdoptrBIl18tMMRr8PkgKuird95HMN?=
 =?us-ascii?Q?BY2oBnzwCvi1g7SzWzMLgP+PpO8/1ktc+Ppo/BDCgw1LFgzA21craocefvpq?=
 =?us-ascii?Q?ubyb5VFUYs30nkGsp2wK1ZDduPr6fQEf/gaeAivTJzrnS4PLgsgXno3/y70w?=
 =?us-ascii?Q?hRjk38EKTfKRklqaipYPkaTwt2hRG9poQZ7ZDdDwa4w0jNe4/P5MixVZsOnh?=
 =?us-ascii?Q?qFiy90yeHx3igurYARE0VjJy6dXWJpQlDs+r8KhWfpHx+//ABRy0SlgkuFzM?=
 =?us-ascii?Q?qwfBaeVcOmJgnItzNtY+ju/uutVFqAdBFUlY8FnERPKzlN+HMPsUWylR36JW?=
 =?us-ascii?Q?Wvo7F1Uo/oNrX5m0SI4gRcGGpccXtEWxIfLCnaRkt1Jv0fNujC7U4vx42SCM?=
 =?us-ascii?Q?wbf0MLQIKdwrwKT8Z+WCCzZskDTPdEL2qAnfUmIQmGnF/GoP9M80Vi8aEKXw?=
 =?us-ascii?Q?D/kZwPuXB0Zbx6rJ3BSU7gISbc6cNMgo4ZNKcL0UDQrzNZ20NDsESoFuBWbF?=
 =?us-ascii?Q?ohUOBn81U+MkA0Z494DKGwU2jhovQxPZuZdKDLaQZpT3ZOpWKKJFgcCUeOLF?=
 =?us-ascii?Q?B28NLiFSU8lfyUwDkefoD2SuiZmeJRBwxq+axLM/cCHFvl1zLoCyC9QDEK97?=
 =?us-ascii?Q?4/gF8C6q3LlFRoZcsnci50ODXTHzCQY2bm9SD3LSijcFGyPOL6Y1Hj+29rDC?=
 =?us-ascii?Q?wNSMmbxCLD8OM2cNyqv9nRX+yYulV54EqCDieiEsX5e6gvngM0OsUvj3bZpd?=
 =?us-ascii?Q?n9lo9j8gOdgQ0vs1Ny7cScpCgQyWTeyjrQaex4QlyszOkrynN+s80UdxpqPq?=
 =?us-ascii?Q?Dpwv6afUnfWX/aKWcq2vpYDrSOMqHbPnd3f1kw0IRicqZ132Ks0O27dZjY44?=
 =?us-ascii?Q?MMeyrRbzJXSvx458/296SE8maVEh09l99JqxPZlRCjvlIuliWSi69g5Bxw9O?=
 =?us-ascii?Q?cTkVR63CzQgzpZ4aXlaqRlj8OeFaaVeT0yZbmcHvgByAUFSrPFA5PlaFa4vy?=
 =?us-ascii?Q?CKayBOaUBTzgpgh+c8/YEhobgHtWoBTi3XnkwNwGE+nKUneKsoMhLp6q1ui4?=
 =?us-ascii?Q?lM5MM3yX/qx5/YUoG6hjKSO64+62Gf5cvgkCb2L0he59HfsBR11MaW/9oyQC?=
 =?us-ascii?Q?E/vfzv4oTEFKe6xSsMwgkJE8P0dsyYin6xWXffQE?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ede89e2e-9121-4021-3243-08dc27f3de89
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2024 15:45:54.5946
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SiUI/w9xvbzBK2huPvTBo6VBc3gkuh1cDHsxVY1R7iJcvZ9GOsshIqC73fQ6ZDO+kGkcMRQApSIvs3qWjLBR9w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7573
X-OriginatorOrg: intel.com

Fabio M. De Francesco wrote:
> On Wednesday, 7 February 2024 02:54:34 CET kernel test robot wrote:
> > Hi Fabio,
> > 
> > kernel test robot noticed the following build warnings:
> > 
> > [auto build test WARNING on linus/master]
> > [also build test WARNING on v6.8-rc3 next-20240206]
> > [cannot apply to cxl/next cxl/pending]
> > [If your patch is applied to the wrong git tree, kindly drop us a note.
> > And when submitting patch, we suggest to use '--base' as documented in
> > https://git-scm.com/docs/git-format-patch#_base_tree_information]
> > 
> > url:   
> > https://github.com/intel-lab-lkp/linux/commits/Fabio-M-De-Francesco/cleanup
> > -Add-cond_guard-to-conditional-guards/20240206-203110 base:   linus/master
> > patch link:   
> > https://lore.kernel.org/r/20240206121301.7225-3-fabio.maria.de.francesco%40
> > linux.intel.com patch subject: [PATCH 2/2 v3] cxl/region: Use cond_guard()
> > in show_targetN() config: s390-allyesconfig
> > (https://download.01.org/0day-ci/archive/20240207/202402070919.0zuYCxMS-lkp
> > @intel.com/config) compiler: s390-linux-gcc (GCC) 13.2.0
> > reproduce (this is a W=1 build):
> > (https://download.01.org/0day-ci/archive/20240207/202402070919.0zuYCxMS-lkp
> > @intel.com/reproduce)
> > 
> > If you fix the issue in a separate patch/commit (i.e. not just a new version
> > of the same patch/commit), kindly add following tags
> > 
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes:
> > | https://lore.kernel.org/oe-kbuild-all/202402070919.0zuYCxMS-lkp@intel.com
> > | /
> > All warnings (new ones prefixed by >>):
> > 
> >    drivers/cxl/core/region.c: In function 'show_targetN':
> > >> drivers/cxl/core/region.c:670:70: warning: suggest braces around empty
> > >> body in an 'else' statement [-Wempty-body]
> >      670 |         cond_guard(rwsem_read_intr, return -EINTR,
> > &cxl_region_rwsem);
> >          |                                                                      
> ^
> 
> I think that this warning deserves attention and braces should be added around 
> the 'else' empty body. I'm going to send v4:
> 
> #define cond_guard(_name, _ret, args...) \
>         CLASS(_name, scope)(args); \
>         if (!__guard_ptr(_name)(&scope)) _ret; \
>         else { }
>

I think this is a good addition.  If the user forgets ';' at the end of
the cond_guard() we could have a hidden side effect similar to what Dan
was concerned about...  This guarantees that won't happen.

Score one for the bots!
Ira