Received-SPF: pass (google.com: domain of linux-kernel+bounces-56524-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <27323df7-7cb2-4cde-a6fc-8aef04370ead@linux.intel.com>
Date: Wed, 7 Feb 2024 15:11:07 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 1/3] pwm: dwc: Add 16 channel support for Intel Elkhart
 Lake
Content-Language: en-US
To: Raag Jadav <raag.jadav@intel.com>,
 Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: u.kleine-koenig@pengutronix.de, mika.westerberg@linux.intel.com,
 lakshmi.sowjanya.d@intel.com, linux-pwm@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20240122030238.29437-1-raag.jadav@intel.com>
 <20240122030238.29437-2-raag.jadav@intel.com>
 <ZbZqZDvdw-_D3hyb@smile.fi.intel.com> <ZbjPv_-S-6CQsaja@black.fi.intel.com>
 <Zbt__WmU74vmLpPR@smile.fi.intel.com> <Zbxo2b_TuCoSyhav@black.fi.intel.com>
 <ZcNt83zD4H3hsCgc@black.fi.intel.com>
From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
In-Reply-To: <ZcNt83zD4H3hsCgc@black.fi.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 2/7/24 13:48, Raag Jadav wrote:
> On Fri, Feb 02, 2024 at 06:02:46AM +0200, Raag Jadav wrote:
>> On Thu, Feb 01, 2024 at 01:26:53PM +0200, Andy Shevchenko wrote:
>>> On Tue, Jan 30, 2024 at 12:30:23PM +0200, Raag Jadav wrote:
>>>> On Sun, Jan 28, 2024 at 04:53:24PM +0200, Andy Shevchenko wrote:
>>>>> On Mon, Jan 22, 2024 at 08:32:36AM +0530, Raag Jadav wrote:
>>>>>> Intel Elkhart Lake PSE includes two instances of PWM as a single PCI
>>>>>> function with 8 channels each. Add support for the remaining channels.
>>>
>>> ...
>>>
>>>>> First option: Always provide driver data (info is never NULL).
>>>>
>>>> Allowing empty driver_data would save us from adding dummy info
>>>> for single instance devices in the future.
>>>
>>> Which may be too premature "optimisation". Why? Because if we ever have
>>> something like pci_dev_get_match_data(), the empty will mean NULL, and
>>> we may not get difference between empty and missing one.
>>
>> Not sure if I'm able to find such a helper as of now, but fair.
>> I can change it in v2 if Jarkko is okay with it.
> 
> Hi Jarkko,
> 
> If you agree with Andy's comments, please let me know.
> Will send out a v2 accordingly.
> 
Ah, sorry, I didn't have opinion.