Received-SPF: pass (google.com: domain of linux-kernel+bounces-56751-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 7 Feb 2024 08:08:14 -0800
From: Kees Cook <keescook@chromium.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Andy Shevchenko <andy@kernel.org>,
	Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
	Marco Elver <elver@google.com>, Eric Biggers <ebiggers@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	linux-hardening@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 3/3] overflow: Introduce wrapping_inc() and
 wrapping_dec()
Message-ID: <202402070806.445F7F7F03@keescook>
References: <20240207152317.do.560-kees@kernel.org>
 <20240207152422.3855315-3-keescook@chromium.org>
 <CAHp75Vf3emnw-=it-Smb_NG+xYjWhB+U0+i1hcNPWA=BByN6nw@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAHp75Vf3emnw-=it-Smb_NG+xYjWhB+U0+i1hcNPWA=BByN6nw@mail.gmail.com>

On Wed, Feb 07, 2024 at 05:31:54PM +0200, Andy Shevchenko wrote:
> On Wed, Feb 7, 2024 at 5:24 PM Kees Cook <keescook@chromium.org> wrote:
> >
> > This allows replacements of the idioms "var += offset" and "var -= offset"
> > with the wrapping_inc() and wrapping_dec() helpers respectively. They
> > will avoid wrap-around sanitizer instrumentation.
> >
> > Add to the selftests to validate behavior and lack of side-effects.
> 
> I would expect inc/dec to add/subtract 1. So, to me the terminology is
> confusing. The list of the C/C++ operators on Wikipedia describes
> above as
> 
> += Assignment by sum
> -= Assignment by difference
> 
> 
> Hence the proposal is to have
> 
> wrapping_sum()
> wrapping_diff()

I think maybe the missing phrase is "assign", which is what makes
argument 1 "special" -- it's being changed. Perhaps:

wrapping_add_assign()
wrapping_sub_assign()

?

-- 
Kees Cook