Received: by 2002:a05:7412:2a8a:b0:fc:a2b0:25d7 with SMTP id u10csp416702rdh; Wed, 7 Feb 2024 08:22:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IFAwbGpa+coA7DBHH48HJuqKHFdCfAJ2E0U3X7kNxDev3wYWEoezOtau4HwMj0GeTDZcFCj X-Received: by 2002:a05:6358:2c81:b0:178:72c6:a3c5 with SMTP id l1-20020a0563582c8100b0017872c6a3c5mr3968698rwm.25.1707322924788; Wed, 07 Feb 2024 08:22:04 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707322924; cv=pass; d=google.com; s=arc-20160816; b=daLqWR8puOa3Se9J+zbY3hk7Rh9S24lb/Zyx2RJY4pkyWDZT+02MrM6ZtoFAcnwpRx cgfnvIFgjQDvB2VBzClDxT/rEcvFvIVJiFT1w2Xk1dyUSfWEiKPD1hnvNq2nZtYc1C+f Ue4JchWGmSBJUWRdiJ/dIgIpsskrkyUybOaWReyAPG7lQ/ABDdvj9IoEyl7DCB55/VIJ qy+tyOLJgDVo3Qq4a4KCINIEiYi7KwkHixprK4yJRBqh+fjpFUp/gqjAdk1M9Kv90KBW Enfvz7sFUx/lqC8koOaQpqj0OsniRoPF2MuQ5in8ppvmtiKEdohkH1nI2jV5hs23jtel zFSg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=oEdLlaxlZ3oglVV4Ap7Tat9mBR143UBObIp6QjvJAfk=; fh=TB9fY7k53dZ+l9CmLK4RPEWF7ZL3V2IVrt0kNXVGJao=; b=E3kUZGcy/A0sbYIljrYsfJbW2dCUjk5goq8jugPqI4nTW+oOERz6m5b2rECgNMwmbe 0s19S5Ilx9vMSzbNvss2ULg3LvbTmoXHS8DMSIjIk7vG7JlLgUGPvhTfx3WGfaB8dYPe zata9cXZFBTrw3xFEW37FIy5JheWheqSCCdak2Bx8ZtIcO1ial2wrATKNXnGf6uJw0+A IdED4+F67A3hGwqEv2y8/JAm4msR8ld4HlAeU6bzJpOeldGS2Gqj2gqrhX1VP+0O04pn LNvsvcmAdMKn5U5UM4I8fc4Z9H2lAJQrtSlfkoOAxshdiHReeCeJgEKhYhbxoDJe+I87 i7Mg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=U0lXzm6w; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-56763-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56763-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com X-Forwarded-Encrypted: i=2; AJvYcCW2nYzoYkBBRbWsjgZRNU3DqTdkv6RytAKN0Gf0MxtxdZ9Yl8PP+xVMx7MZvd877JxaHou5n9Zj2CWxngEtrcKzqiGLYw+ZvL6YsgZxkw== Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id n26-20020a638f1a000000b005cdfaccba35si1749632pgd.665.2024.02.07.08.22.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 08:22:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-56763-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=U0lXzm6w; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-56763-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56763-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id C4F4BB23D1E for ; Wed, 7 Feb 2024 16:22:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0E0CD81210; Wed, 7 Feb 2024 16:21:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="U0lXzm6w" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E7CD8120B for ; Wed, 7 Feb 2024 16:21:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707322901; cv=none; b=LI31ar55AykRjw57K7EgD47u0Iw8Yv1u/PkmVfi0y7Z/Ck1gUkNkKhGy2CEk2rDjoDRg+kCn7jTTFn7PO4IPzfW6BGelmcIL94P88G/cm3UhNDCz/vYzEx32nipahFj6j08F8wVEIWqP3jVjeXqK/uktoJBkd6gDpTx6pD+AnyA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707322901; c=relaxed/simple; bh=Ham27Lju8X30G/Pi7G2NB/yVZZfjl/5xdSUO56dUsNk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KTr7K/hUJNYQ2szj5wCAuheFzBG0H8vXjyPhDDWAHJ3smn65tHTds+wPBTVS+T2CtnluzaF8lwwM6BGuXYiaPVWTK1j1MRiGTUN11Q9B7FnbBHrLNWwv5NUR/Q0KgNRm+RpGOjV8TjgcaSh/1vLMMmLbj4wd6YUkwvEedsEUF+Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=U0lXzm6w; arc=none smtp.client-ip=198.175.65.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707322900; x=1738858900; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Ham27Lju8X30G/Pi7G2NB/yVZZfjl/5xdSUO56dUsNk=; b=U0lXzm6wYsI3tNX7Q9jxYKMir8ujFDznBHjE0aiLLbWHr5DmAeQeFzBQ DIG/7/Kgg/bJpehZOJ8X0AqIGo8bWRydVndNF9ntFusbttYWNlEdxX9lb gzTM4KWBj1zUXbEPvnp1KRxBTlobxAKIjJ6gx3A1VmrKJkRRpXSZLwNdW nr0V8NSdl8eX9tGr7s8NgBcbVm9mmfLlEPBJv1N49vWWbjBBQYhLBELcC RQdCRr9SjwYbzLlcjiO+idctD1JRi+/UDeOt3G/1gS7Tbk7nU84eKBRia 7fsfbl2KcztZRxpaUImaHopeBUaUBTiUtX1TyQxT1xou5vQQbUOrgk0cM A==; X-IronPort-AV: E=McAfee;i="6600,9927,10977"; a="4887758" X-IronPort-AV: E=Sophos;i="6.05,251,1701158400"; d="scan'208";a="4887758" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2024 08:21:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,251,1701158400"; d="scan'208";a="38817515" Received: from ranerica-svr.sc.intel.com ([172.25.110.23]) by orviesa001.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2024 08:21:37 -0800 Date: Wed, 7 Feb 2024 08:22:55 -0800 From: Ricardo Neri To: alexs@kernel.org Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Daniel Bristot de Oliveira , Valentin Schneider , linux-kernel@vger.kernel.org, yangyicong@hisilicon.com Subject: Re: [PATCH v4 2/4] sched/fair: remove unused parameters Message-ID: <20240207162255.GB21939@ranerica-svr.sc.intel.com> References: <20240207034704.935774-1-alexs@kernel.org> <20240207034704.935774-2-alexs@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240207034704.935774-2-alexs@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) On Wed, Feb 07, 2024 at 11:47:02AM +0800, alexs@kernel.org wrote: > From: Alex Shi A few nits: subject: s/remove/Remove/ > > sds isn't used in function sched_asym(), so remove it to cleanup code. The argument sds is not used in function sched_asym(). Remove it. > > Fixes: c9ca07886aaa ("sched/fair: Do not even the number of busy CPUs via asym_packing") > Signed-off-by: Alex Shi > Reviewed-by: Ricardo Neri With that, my tag stands, FWIW.