Received: by 2002:a05:7412:2a8a:b0:fc:a2b0:25d7 with SMTP id u10csp419422rdh; Wed, 7 Feb 2024 08:27:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IFd+tfjlvxgu/YIxjzR4FtRxOkw07+ONvm/2VwPTcsalm6umfmTLB8EiSi18fb2B245wEZe X-Received: by 2002:a17:903:228e:b0:1d6:f16b:a30e with SMTP id b14-20020a170903228e00b001d6f16ba30emr9039598plh.5.1707323226306; Wed, 07 Feb 2024 08:27:06 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707323226; cv=pass; d=google.com; s=arc-20160816; b=iCxf4igDvDzMYl6Ut5oOM8iXke1Zg/B/LDQEOkYJBObqrLjb87pYCQOMnuEt/FyPYu SJDKgHm2iNiNNezDv8bOV18GZiI35x0XgxSD/8+OOrQhkS3O9varTAqySXTlhMnOk6Y5 P42QNtHltDWAgUiyy5aBcFH8SHStop5fmQI91vgyQHwj0vcylvLYro+4ATFNISW0H+yN ZPitybr95EvvWI6n8j7RCwbiGz5iPcs+cFMGQByTmvB/+1TUvB6B+7Lihz9C864BndpY NwJwsNoDqRvo/dDbTkfKp4b8pHg4YB0qCkgxTsnBzD+1uvkr8yAT8+cUbuBTyhv4KNp9 pf9g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=TG2YNTbDb5RqJQT2Oozpl3HLHZ0RIJQ+EtnL/6mJBIg=; fh=74RKmVDgGHPxVxttTEa9DuieFHcLPHy/7ei2sjeItto=; b=EGdVl99wkyOf8ysO3l4X3ubbp9KK3EI/DzA9QDQrm2Etma9wvwGPHDBlaIJ6tbrUzj LrKYDPY68YBfNuWMTrDNMlNFQ0sYIys0JaiIrNMGmZ4TsoJdjtNtgXZKOUU6nXoxanuu Y7dsjchZJVD7QJttdQYuHrc8hbpL7cyc2kOyIB7mevfXk9sN4Xn+4qyNkF1I60/Hut3x R0ln3KLwZl/OzjvjtbYghwjtqKjLzJVJFswWIeCXjLE/aENwB+au09/ZkWAZPxfviYjX ez+qwmQrNPg5nCQLFtQWZsLGkt/9hS6oOuVAj1/iypha+d1LgnQQ7pzMIDEi8BqWowcG KPLw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="tV/1//8g"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-56766-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56766-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCWglcX1ImwHr9Oed3nhOaMzns3v8GOcpi9dfpppY2HAyhUnheXILJZSwUj0lQkwap3yquJqMMb08GHHyJ2fmryYLTBxwpW9C2ozJvTuog== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id f14-20020a170902ce8e00b001d9d4629bc1si2075463plg.456.2024.02.07.08.27.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 08:27:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-56766-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="tV/1//8g"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-56766-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56766-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id D691428D42E for ; Wed, 7 Feb 2024 16:27:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B4E7B8174B; Wed, 7 Feb 2024 16:26:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tV/1//8g" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D467381201; Wed, 7 Feb 2024 16:26:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707323212; cv=none; b=AwoIuKuZoAy8sWkav1UtyNxT4JG7fuIEkKFJKjKsTGvLoG3Nht5xBmPt95bwBrqYUVFIjRTAApZLWsRfU6FbKGdJCgPdsgbUhXChr1gNBUORyJLFm7f6mnpfAYG1kZRseq2WW8dlAQ3nwYvK67QYVVI226M6z9qEwHigKNGZghk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707323212; c=relaxed/simple; bh=PowRBFjz75WWYEtFZnydwXqExpiqvShTdLKPfWCIPg4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ncTquXr4MQkU3/87YR8QFxogfOQ+4zO0pQJGvTQXzLqPhlbvC5zQ+oJB4+E3+dYDKtiP60W+LIHrJVi4479yU/2SZDp1U8AWvTDlwJtlUPWWQnxK5VOXVWqKqWUI6AoXh06PuGBGQMiQCCh5Dqr9UsB25cH7w1ekdpc/oeaBfV4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tV/1//8g; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id DECBFC433F1; Wed, 7 Feb 2024 16:26:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707323212; bh=PowRBFjz75WWYEtFZnydwXqExpiqvShTdLKPfWCIPg4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tV/1//8gmuYg8UQWVRYRPGpWBRe7tk8hpqX4Fa+hCjQTh5jOhH9qCqY2+w/SbpPnD OtwhsPh/2f/eXCURP++4uL52+aLyCtoZGc9nrGdtLDpx0gIiUlxYVdD8FzIZeyIdEF 8JXAK0CS38f4Bsv+SUWIIcdKeNTNp+EniAbRPvVN6qdrGEpJYZdSy1VH3lU+5PkhNa U3C7vH3eqFU7cSmLVWPS70PQnUZGdO1PXTiUwW1qOqrCMhwWG35BQ8/w65/aWTGuUV opE5xg02jBDPibX3mNGIEQPctLXuER6gxILCfsVoTBA+4UKpX7S1OkOg/e4xLtCEMG PMksVQD0be53Q== Date: Wed, 7 Feb 2024 16:26:44 +0000 From: Mark Brown To: Richard Fitzgerald Cc: alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: Re: [PATCH] ASoC: cs35l56: Fix deadlock in ASP1 mixer register initialization Message-ID: References: <20240207161602.1030342-1-rf@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="EMCHHW87nQ+T4IA8" Content-Disposition: inline In-Reply-To: <20240207161602.1030342-1-rf@opensource.cirrus.com> X-Cookie: You might have mail. --EMCHHW87nQ+T4IA8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Feb 07, 2024 at 04:16:02PM +0000, Richard Fitzgerald wrote: > + if (!cs35l56->asp1_mixer_widgets_initialized) { > + ret = cs35l56_sync_asp1_mixer_widgets_with_firmware(cs35l56); > + if (ret) > + return ret; > + } Might it make sense to factor the check for init into the function since it looks like all the callers do it and I'd expect that'd be the case for any new ones? --EMCHHW87nQ+T4IA8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmXDr0MACgkQJNaLcl1U h9DaLAgAhU2r1USCPLg8AOzumIzQ20m/PAOaACMu81xCBh4JH5D7EHv+uNOBql0p /wxF88FtoX/xe5ZsN9JzyjApP9Y1dSSsBUgRbTqge/5ixuZHKgzuDDbqwt+fDSky dODR1k+1Yw85DtKlAmk2aA0bbMV0QpjQ+iuRt4nauR3IHF/p9kSTPzqaf33eiBJL kO3rT10QH8IQWtzKwnltiTnKMlBrnsgzlzyJ/oLfMyN26g5yWCdaTWoY/LCxMmmL dfWnPVXJ7+Cpq+xAi2mhDX78Fb/X+uGK9KeE9bIKwZITWGuc5z9ITkkr20fruvCQ e8meSxc2yddRLmf5q8DFlPjU46T0DQ== =j0DP -----END PGP SIGNATURE----- --EMCHHW87nQ+T4IA8--