Received-SPF: pass (google.com: domain of linux-kernel+bounces-56766-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 7 Feb 2024 16:26:44 +0000
From: Mark Brown <broonie@kernel.org>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: alsa-devel@alsa-project.org, linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org, patches@opensource.cirrus.com
Subject: Re: [PATCH] ASoC: cs35l56: Fix deadlock in ASP1 mixer register
 initialization
Message-ID: <ZcOvREgHBiQVuB9n@finisterre.sirena.org.uk>
References: <20240207161602.1030342-1-rf@opensource.cirrus.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="EMCHHW87nQ+T4IA8"
Content-Disposition: inline
In-Reply-To: <20240207161602.1030342-1-rf@opensource.cirrus.com>


--EMCHHW87nQ+T4IA8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Feb 07, 2024 at 04:16:02PM +0000, Richard Fitzgerald wrote:

> +	if (!cs35l56->asp1_mixer_widgets_initialized) {
> +		ret = cs35l56_sync_asp1_mixer_widgets_with_firmware(cs35l56);
> +		if (ret)
> +			return ret;
> +	}

Might it make sense to factor the check for init into the function since
it looks like all the callers do it and I'd expect that'd be the case
for any new ones?

--EMCHHW87nQ+T4IA8
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmXDr0MACgkQJNaLcl1U
h9DaLAgAhU2r1USCPLg8AOzumIzQ20m/PAOaACMu81xCBh4JH5D7EHv+uNOBql0p
/wxF88FtoX/xe5ZsN9JzyjApP9Y1dSSsBUgRbTqge/5ixuZHKgzuDDbqwt+fDSky
dODR1k+1Yw85DtKlAmk2aA0bbMV0QpjQ+iuRt4nauR3IHF/p9kSTPzqaf33eiBJL
kO3rT10QH8IQWtzKwnltiTnKMlBrnsgzlzyJ/oLfMyN26g5yWCdaTWoY/LCxMmmL
dfWnPVXJ7+Cpq+xAi2mhDX78Fb/X+uGK9KeE9bIKwZITWGuc5z9ITkkr20fruvCQ
e8meSxc2yddRLmf5q8DFlPjU46T0DQ==
=j0DP
-----END PGP SIGNATURE-----

--EMCHHW87nQ+T4IA8--