Received-SPF: pass (google.com: domain of linux-kernel+bounces-56796-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240206033320.2657716-1-irogers@google.com>
In-Reply-To: <20240206033320.2657716-1-irogers@google.com>
From: Namhyung Kim <namhyung@kernel.org>
Date: Wed, 7 Feb 2024 08:54:25 -0800
Message-ID: <CAM9d7cix-TuMov+hsqVvvkeSRA2snhuddcY0zypR1F9yY4G2Wg@mail.gmail.com>
Subject: Re: [PATCH v1 0/6] maps memory improvements and fixes
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, 
	Arnaldo Carvalho de Melo <acme@kernel.org>, Mark Rutland <mark.rutland@arm.com>, 
	Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>, 
	Adrian Hunter <adrian.hunter@intel.com>, Song Liu <song@kernel.org>, 
	Miguel Ojeda <ojeda@kernel.org>, Liam Howlett <liam.howlett@oracle.com>, 
	Colin Ian King <colin.i.king@gmail.com>, K Prateek Nayak <kprateek.nayak@amd.com>, 
	Artem Savkov <asavkov@redhat.com>, Changbin Du <changbin.du@huawei.com>, 
	Masami Hiramatsu <mhiramat@kernel.org>, Athira Rajeev <atrajeev@linux.vnet.ibm.com>, 
	Yang Jihong <yangjihong1@huawei.com>, Tiezhu Yang <yangtiezhu@loongson.cn>, 
	James Clark <james.clark@arm.com>, liuwenyu <liuwenyu7@huawei.com>, Leo Yan <leo.yan@linaro.org>, 
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, 
	bpf@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Ian,

On Mon, Feb 5, 2024 at 7:33=E2=80=AFPM Ian Rogers <irogers@google.com> wrot=
e:
>
> First 6 patches from:
> https://lore.kernel.org/lkml/20240202061532.1939474-1-irogers@google.com/
>
> Ian Rogers (6):
>   perf maps: Switch from rbtree to lazily sorted array for addresses
>   perf maps: Get map before returning in maps__find
>   perf maps: Get map before returning in maps__find_by_name
>   perf maps: Get map before returning in maps__find_next_entry
>   perf maps: Hide maps internals
>   perf maps: Locking tidy up of nr_maps

This fails to build with NO_LIBUNWIND=3D1

util/unwind-libdw.c: In function =E2=80=98unwind__get_entries=E2=80=99:
util/unwind-libdw.c:266:70: error: invalid use of undefined type =E2=80=98s=
truct maps=E2=80=99
  266 |                 .machine        =3D
RC_CHK_ACCESS(thread__maps(thread))->machine,

Thanks,
Namhyung


>
>  tools/perf/arch/x86/tests/dwarf-unwind.c |    1 +
>  tools/perf/tests/maps.c                  |    3 +
>  tools/perf/tests/thread-maps-share.c     |    8 +-
>  tools/perf/tests/vmlinux-kallsyms.c      |   10 +-
>  tools/perf/util/bpf-event.c              |    1 +
>  tools/perf/util/callchain.c              |    2 +-
>  tools/perf/util/event.c                  |    4 +-
>  tools/perf/util/machine.c                |   34 +-
>  tools/perf/util/map.c                    |    1 +
>  tools/perf/util/maps.c                   | 1296 ++++++++++++++--------
>  tools/perf/util/maps.h                   |   65 +-
>  tools/perf/util/probe-event.c            |    1 +
>  tools/perf/util/symbol-elf.c             |    4 +-
>  tools/perf/util/symbol.c                 |   31 +-
>  tools/perf/util/thread.c                 |    2 +-
>  tools/perf/util/unwind-libunwind-local.c |    2 +-
>  tools/perf/util/unwind-libunwind.c       |    7 +-
>  17 files changed, 899 insertions(+), 573 deletions(-)
>
> --
> 2.43.0.594.gd9cf4e227d-goog
>