Received-SPF: pass (google.com: domain of linux-kernel+bounces-56850-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 7 Feb 2024 18:51:45 +0100
From: Pavel Machek <pavel@ucw.cz>
To: Justin Stitt <justinstitt@google.com>
Cc: Kees Cook <keescook@chromium.org>, Andy Shevchenko <andy@kernel.org>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] string: Allow 2-argument strscpy()
Message-ID: <ZcPDMZFPY08S4MGR@duo.ucw.cz>
References: <20240129202901.work.282-kees@kernel.org>
 <20240129215525.4uxchtrywzzsrauc@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="eLOfAe0GFtq5q4sl"
Content-Disposition: inline
In-Reply-To: <20240129215525.4uxchtrywzzsrauc@google.com>


--eLOfAe0GFtq5q4sl
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> > Using sizeof(dst) is the overwhelmingly common case for strscpy().
> > Instead of requiring this everywhere, allow a 2-argument version to be
> > used that will use the sizeof() internally.
>=20
> Yeah, this is definitely the case. I have a ton of patches replacing
> strncpy with strscpy [1] and many of them match the pattern of:
> | strscpy(dest, src, sizeof(dest))
>=20
> BTW, this hack for function overloading is insane. Never really looked in=
to
> it before.

This hack is insane, but this is also highly confusing, please don't
do this.

BR,
									Pavel
--=20
People of Russia, stop Putin before his war on Ukraine escalates.

--eLOfAe0GFtq5q4sl
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCZcPDMQAKCRAw5/Bqldv6
8l3TAJ9JeO899iqkl6Ymsyx096x6S41JLQCdE2n2yCsojfhW1w17jM7QJNEtg/c=
=8PgS
-----END PGP SIGNATURE-----

--eLOfAe0GFtq5q4sl--