Received: by 2002:a05:7412:2a8a:b0:fc:a2b0:25d7 with SMTP id u10csp485724rdh; Wed, 7 Feb 2024 10:16:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IEM7NhpkzyGXnn5rE+Sy74GEzz2tsCo96xdwXdn9o8l0J6tWzrW0lY1GkSeDlKbhEOnT1fY X-Received: by 2002:a05:6512:34ce:b0:50e:a8c7:b2e2 with SMTP id w14-20020a05651234ce00b0050ea8c7b2e2mr4755520lfr.38.1707329805793; Wed, 07 Feb 2024 10:16:45 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707329805; cv=pass; d=google.com; s=arc-20160816; b=ehYkZwNxPL1ubIlKTy8PVmkCJDUm0RlXTEjYf38DXY+bKiZ9KU/UFRzbLsl71+Y8QN VcgAETJz2ZIh7ubP2FH6PLpqUX3RVvHEb6y1FhcP8UiyG3qIvGP4DPNdT4/T4E2vtZXF 4vJscNXXJz98HBnTYhBFavLs4hhIFaJF2yqmWLnm5c2wg/L4i+YPLayIVUiN3ay1VyLV VpZBGCWyoyiUwN5AVHzNd82gQUiyCKADUHUldXJuH4AOqyL421BLNtS5gXV9hZX/7Oob Ec1rZFlJG3gwN/V5EQlQv4gLVvbqWnzOJZDaIQHAQ5e/c3A1kq8omtwiJYL7TWWmX57n W9Gg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:message-id:in-reply-to:date:references:subject:cc:to :from:dkim-signature; bh=elVl3MslZ8hlmvkpGnEK+NiOzkpNG1WdJXmfHJ5SQ9c=; fh=EWjqTQvk69paKehz6zUYURkyxYa21b2l9UkzwXzaUcI=; b=oVg4LrtATuwqqOPKkv1zcMGkbSleNgYchjlp6ZubV0eMUxPoWCd9Gmaf6PR3+OWRkR PegbV1L+QHH9QpdINgCxk5C4JLtw+nU0irkkzCFFNAT/fSH6omDAQkbbDerlb3S4AkP0 ZsJbbmFYsP9rTtIDSH4Od1iKDQyl0LrRFxN6+P1eH0oRG/rCaMMxxtdZfjgLVDl8KddW p3Hy2471X4ovJzZEfKoeB/9kunjB+iNu87HdwMBHtKaWcvSACyt+5gnDU3s7c5d5iCz1 Q2TXYjODVHHTZ6AVLcPtZaOpQS6o+svMB3ZXWo8GkwRrWircAojX9LVB0gargFH1sVZ+ /BBQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=vNIk7sJY; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-56899-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56899-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCU3qJlW32FusCoIdH5mbACbeiX4zFXceqacOSv4J9BInSvyAiCGFCk+aa8swjsjuEdP74ZNx7Bh2lJEv8Jt4z/z4h6HXGA1W3INrH89Eg== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id mf26-20020a170906cb9a00b00a381e72bce0si1183561ejb.694.2024.02.07.10.16.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 10:16:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-56899-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=vNIk7sJY; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-56899-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56899-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 7B4971F2322D for ; Wed, 7 Feb 2024 18:16:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D3E1185C42; Wed, 7 Feb 2024 18:14:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="vNIk7sJY" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED12D1B7F0; Wed, 7 Feb 2024 18:14:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707329654; cv=none; b=dARabMFGsWk/mcq0nTnASGLyC7VBjQcvtfh2pa6IbVns7WgaZmd4xMHqgwjagX30B07n1R9kFXjVdP7/8hO61TaSAy5qDe3danrDhe8LxtqUEl52SoSeBsPvqsHn7EoS5KS7IorD1hv3HA+hmMJEzjazhE1ZyK16JND+HDm9xIA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707329654; c=relaxed/simple; bh=eP/zI19SPSRRm5KxM8isKzsQV4/zUTMHBunc8dphjiQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=RM5ndtjjln+t7inZ8g+zX6G3FjPZEv5cgw3tXfZwQdsdez39+z0i134fCFbG2I3CSJWlAUPiBasgmlslf7YbKW+Ra+725IFIhmEQF5SJSVxtcn1yDkskww9rTHjy8x9JFNSqYzzgRSHk3y5Ldi8N/EaH1/jOAdXF+OdRYFtR1eE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=vNIk7sJY; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6EE4AC433C7; Wed, 7 Feb 2024 18:14:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707329653; bh=eP/zI19SPSRRm5KxM8isKzsQV4/zUTMHBunc8dphjiQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=vNIk7sJY8Qm62mFrkb9lpQ2YkFwH1W4nUltIhZOtUc89p+x8O5FSy/PKtcc5BW9m5 PyRVmOcpwKB0kPded1Vy4YMwNAcgkr3mBQ0nnI2446aEW9E/ei3yX1dJs0Pc7/dT0v vJAqPmHIGtxul7dJmmxFFuEtwCgwINP0YPmNJgFXSjHnrMV8DIK9KmqUC77ukMLM2K Q9mFSYpTbJLARpyPrQ1svxG1lNFt9a5QWMGTxs4NjTNffdv9L77DBsV7tg9Sxu8o1o hZu++QLeWmOkMP1Dt0bIefJNlAS4CB2PDwujEIPAGTe1tVqBMBvpTph7Dv/CjC19bH qK2rWKyjMZlDA== From: Kalle Valo To: Colin Ian King Cc: Christian Lamparter , linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] carl9170: Remove redundant assignment to pointer super References: <20240207171524.2458418-1-colin.i.king@gmail.com> Date: Wed, 07 Feb 2024 20:12:00 +0200 In-Reply-To: <20240207171524.2458418-1-colin.i.king@gmail.com> (Colin Ian King's message of "Wed, 7 Feb 2024 17:15:24 +0000") Message-ID: <87a5ocgn4f.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Colin Ian King writes: > The pointer super is being assigned a value that is not being read, it > is being re-assigned later. The assignment is redundant and can be > removed. > > Cleans up clang scan warning: > drivers/net/wireless/ath/carl9170/tx.c:192:34: warning: Value stored to > 'super' during its initialization is never read [deadcode.DeadStores] > > Signed-off-by: Colin Ian King Same here, "wifi:" missing. I can add it, no need to resend because of this. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches