Received: by 2002:a05:7412:2a8a:b0:fc:a2b0:25d7 with SMTP id u10csp487588rdh;
        Wed, 7 Feb 2024 10:19:50 -0800 (PST)
X-Google-Smtp-Source: AGHT+IEmyQo2S9eLjJzb9K8TtQWqTvwbdmjMPde5QINuUwp17z0KvSlqn/pHW+8Qg9CejH0UcQgt
X-Received: by 2002:a17:906:ae94:b0:a36:6dc6:d9c7 with SMTP id md20-20020a170906ae9400b00a366dc6d9c7mr4758271ejb.4.1707329990568;
        Wed, 07 Feb 2024 10:19:50 -0800 (PST)
ARC-Seal: i=2; a=rsa-sha256; t=1707329990; cv=pass;
        d=google.com; s=arc-20160816;
        b=pUcEU6cs8RcdTCOAMl2W3G4/JeFXMhhPR5iqMB92MYY4BAY4D4XNsjN/GyfjgvCFKK
         z/G+VXyd7UpvTkZ4uQL1tMQCcEsVKeiIm9ClPnFZoJtKHDYjivVIBhGUKRC8NvPjZ8bM
         en0jGQoCEmJ2iCxRDrtuIZTrSNoBnfl+PBEkf7dnnt3AfHGEboN75X6agYqhotHn44Sw
         ZZQD2mCkpsQMV4BUXTRZjHe7eph9gFl72CSuAS5AK+Xi6711+j2mMVtWqhuWWzX3vkp8
         yw2+1iNkRvql3pNSEFVdqPJIjAoPCdc4Wzi+pyfFej902CukI/aZYFGSpTSlJ49PBVrl
         zEOQ==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=content-transfer-encoding:mime-version:list-unsubscribe
         :list-subscribe:list-id:precedence:references:in-reply-to:message-id
         :subject:cc:to:from:date:dkim-signature;
        bh=JXBv0387KpdbfDf2TbxhzHei4PcLOYBFJkVl/4uQiOY=;
        fh=sHk/pQNFOXKE5Tji1llTvN5LMNHycQzK45Tk2HzMlBw=;
        b=DCuCp2Xgt7dgbqGPrYTqbqE6kzPnDzfvK+NabEnBQr7OaVq/3rlo/npdqi8OBhl7AD
         SK6fXU0nPhvaeuas0rpW/Xf/uSsihuh5VmHji/JSVdHDPiKQk0ex2DtBprqjQl1PoU5I
         gSgOAKrHN34Ij4cORijJH0XKSARCUzkxUdtahrADnxdWdV4MX54eJsJ8aZr4X/0OTRgE
         Cq77yhGBPPQDHa4GfHZpsUTYrxGeJ0IdbuGsqkY2FAzJCX38QDKOCNn/XaASMr2cG81W
         JWq5NR1BTh+mxUkHb8qw1JzVEmIjwfUPC1l8ufw3JrCjD3/RoOQYdOItD5ynp8NFSMpI
         EaLA==;
        dara=google.com
ARC-Authentication-Results: i=2; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kEGhdQDJ;
       arc=pass (i=1 dkim=pass dkdomain=kernel.org);
       spf=pass (google.com: domain of linux-kernel+bounces-56902-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56902-linux.lists.archive=gmail.com@vger.kernel.org";
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
X-Forwarded-Encrypted: i=2; AJvYcCU6MdPV8Z6jmScIWgCAVGUO0tC/Kk6MLTJ03v1hFoU8v32AXnRaI/+yvOAti6GIqiobW8W6QqV2TLH9hsq/tLSvLPkZugbAj6KoogcFdg==
Return-Path: <linux-kernel+bounces-56902-linux.lists.archive=gmail.com@vger.kernel.org>
Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3])
        by mx.google.com with ESMTPS id h7-20020a170906110700b00a385cce2031si1230763eja.573.2024.02.07.10.19.50
        for <linux.lists.archive@gmail.com>
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Wed, 07 Feb 2024 10:19:50 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel+bounces-56902-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kEGhdQDJ;
       arc=pass (i=1 dkim=pass dkdomain=kernel.org);
       spf=pass (google.com: domain of linux-kernel+bounces-56902-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56902-linux.lists.archive=gmail.com@vger.kernel.org";
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by am.mirrors.kernel.org (Postfix) with ESMTPS id 50E461F23765
	for <linux.lists.archive@gmail.com>; Wed,  7 Feb 2024 18:19:50 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id EC8B283CCB;
	Wed,  7 Feb 2024 18:19:37 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kEGhdQDJ"
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0294F82C64;
	Wed,  7 Feb 2024 18:19:36 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1707329977; cv=none; b=AFTUmJd7vK91cl2nOYbSIc/1Y8JYHfOBndhPAWB2PezOn8lwxAWx7DaGuzDgNibwiBWEi6fZmLae9gMz9eDaLxMlJquZIjBCdRIgjA5PE1P08nXBPQH9Qafx6MS3trKKjoCH1UchPvamEGf+LuqpVbhM6XJH+aMQPFTx5dvbQaM=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1707329977; c=relaxed/simple;
	bh=yzqZkWmurf1d3vXbpPSRq3flg3TmxvLtRnfELAdKB7g=;
	h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:
	 MIME-Version:Content-Type; b=CYKtwLRpEe61L8FIgCvp+bq+TrwkLzWucmdTTMtwaSi9eM5i2BtiwHbd2qtxVG4NEBPfrsVlkZ1kSaWThL/YdY7qoDJRilHxjk4t3NoZ+H9LgDgkBoEhzySuJ1okZoLmzXReIQSwbAay3pZgb7D86j2H3AY53bG/s4WbfzIOPYs=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kEGhdQDJ; arc=none smtp.client-ip=10.30.226.201
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F479C43390;
	Wed,  7 Feb 2024 18:19:35 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1707329976;
	bh=yzqZkWmurf1d3vXbpPSRq3flg3TmxvLtRnfELAdKB7g=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=kEGhdQDJzavIhJvxC2C52ffr/UE9SoJ9mSUpiZCNmq1JypOn2mgZ6hiueF8bHxcmz
	 JPeRnosDHGyBRAaDNn/KALE4+xNTlFO7Uwq10pSMRCdC1PakuguEDBP7qR2Mab/dTy
	 aLaAesbZaSjSnMezz+7Pjja6d1pGC7TqHrOsOu+zrDFcXJS8LRhccozlrWXUSCkbdb
	 9nCjFktQAC3cyrJW74mDt5pmRpu3SuaKL4rAAzo81ZlKJ9O40lGgwyqUrsLwLgAjBf
	 UU540HAIc1fpuPXdzChWcQOMrX2XMquNc120ZiWSrUYi0WsGdIu6zg1PFuTHgS5uuv
	 zhj1lqaBMdeWw==
Date: Wed, 7 Feb 2024 10:19:34 -0800
From: Jakub Kicinski <kuba@kernel.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: Abhishek Chauhan <quic_abchauha@quicinc.com>, Vinod Koul
 <vkoul@kernel.org>, Bhupesh Sharma <bhupesh.sharma@linaro.org>, Andy Gross
 <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio
 <konrad.dybcio@linaro.org>, "David S. Miller" <davem@davemloft.net>, "Eric
 Dumazet" <edumazet@google.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof
 Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley
 <conor+dt@kernel.org>, Alexandre Torgue <alexandre.torgue@foss.st.com>,
 Jose Abreu <joabreu@synopsys.com>, Maxime Coquelin
 <mcoquelin.stm32@gmail.com>, <netdev@vger.kernel.org>,
 <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
 <linux-kernel@vger.kernel.org>, <linux-stm32@st-md-mailman.stormreply.com>,
 Prasad Sodagudi <psodagud@quicinc.com>, Andrew Halaney
 <ahalaney@redhat.com>, Rob Herring <robh@kernel.org>, <kernel@quicinc.com>
Subject: Re: [PATCH v2] net: stmmac: dwmac-qcom-ethqos: Enable TBS on all
 queues but 0
Message-ID: <20240207101934.6c0ab20b@kernel.org>
In-Reply-To: <578b6a6e-83df-4113-9c1f-cdd7aa65f65e@quicinc.com>
References: <20240207001036.1333450-1-quic_abchauha@quicinc.com>
	<578b6a6e-83df-4113-9c1f-cdd7aa65f65e@quicinc.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 7 Feb 2024 09:26:05 -0800 Jeff Johnson wrote:
> > This is similar to the patch raised by NXP <3b12ec8f618e>
> > <"net: stmmac: dwmac-imx: set TSO/TBS TX queues default settings">  
> 
> note that there is a standard way to refer to a prior patch, in your case:
> 3b12ec8f618e ("net: stmmac: dwmac-imx: set TSO/TBS TX queues default
> settings")

Yes, please fix.

> (note this format is defined in the context of the Fixes tag at
> <https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes>)

A fixes tag would be great. But we can't point at 3b12ec8f618e, right?
Can someone explain what the user-visible problem is?
TBS cannot be used? Device reinit is require to enable it?