Received: by 2002:a05:7412:2a8a:b0:fc:a2b0:25d7 with SMTP id u10csp510576rdh; Wed, 7 Feb 2024 11:04:30 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWhEJTKl71hD86WO1i9hkS1R2OIR519nrEi7Ya6bPxgmLZxluP7B7Y0O+qtzviqyhe7ZkTekJ4iTQB3qNtSAWZq0vxNJnOqxuC1tZROTQ== X-Google-Smtp-Source: AGHT+IFYWF8a5ZFCf0QsIbzRzWurU4BM4rkdWd6yUdD7bz88PCvc+S9ASngQ8A2HBy+j5XUK+1ER X-Received: by 2002:a0c:e253:0:b0:68c:83f9:fa37 with SMTP id x19-20020a0ce253000000b0068c83f9fa37mr5259369qvl.65.1707332670612; Wed, 07 Feb 2024 11:04:30 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707332670; cv=pass; d=google.com; s=arc-20160816; b=xsjP9PRChHrDnKhIDanwwYRd9shs4EzfjTmXu2syvIyvkzwuBdVZBgpd0ORsACKzI/ 138+Z1pLVQvA9NVI2U+ThjK9nBGjvfLOMNAtqzPa8zLYYxY73zqfE0G/MZ1MHVwRA5to MY96lzKUsM7KMxY8UArcbdXp/8EsaGW1mkUBTHOjmrTRERc2CcC7SWw4VIsF8sVNI6K8 nreS7jLkBNsDDo2dLcCGz1lcdUetCHGTZOIG/Ik9kC8IHWG+vmJbDTe8gbP+rdaSFAmi sMzUZItmfKlKnZOIhqpH91BnHNPnJgLtW7Eke76Rekq+KwE2nLbFV4VOXkVHGLfoUQSJ 0mVQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=lXCPrWeHwKviAb9Om/OecQyMcGOAgBROs0AT1Dc+xR8=; fh=nZtHl9zkVHqCyj8KSq7ZI0bVvJMKrQZrn9upaxcvO08=; b=FvlY2k11FVExu92oVAupy8FCnjyzDYkSMQs1vomiz3Y6llnJsJJGthWEsTsCquhGAq 5a3BxtGykf1Rcdos9EZblY7055yKf8jbCYtU/qHnOIR3XIWE/Rro/J3kph+z3ROeGpbO KkWfbLinpNA6jHVi8ophAgYWhyCg+QpNxy94xV10wFMQR8SywAm2Pe23Ye4FlSDmfpAT S5eOkGLuUDfcOFmKwa2+6Ouqqr7BWtBnxNByMPiXeX0k7H5ZLTWw54xvj9P0b5TwnOb1 eUtOJ/9I9tfR8mu24AZfgAlNGVm9VIgbK0hVlpdo4aBG74lP0j6JdhAPyMfE9PHpc4kv AKgA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Dw1PNj2J; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-56967-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56967-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCUMsWBK9akjLexdKBect9Rg1sSvm8Wjtd3cYZu34mhc0TFIs7RuJmuU7PwbHYRPU1nL0r6AL8MUUM6zw5duBGI/9+YwBw/Va+m0SdVFyA== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id l2-20020a0ce842000000b0068cc2573ffcsi873131qvo.126.2024.02.07.11.04.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 11:04:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-56967-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Dw1PNj2J; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-56967-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56967-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 5EFBD1C225ED for ; Wed, 7 Feb 2024 19:04:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9538D85624; Wed, 7 Feb 2024 19:04:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Dw1PNj2J" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E9C380050; Wed, 7 Feb 2024 19:04:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707332655; cv=none; b=eJkBjPfCFkyx/9iMEJI3OvTQ5D+YX/1sPQA4r2GTIW2kf6RO1+uzBxIDO5OTs+QbbQXmo1RyIM1Yz1d7vC9ukDkF/IKJSD3AhOkf0xZOqfh6ev0NrcHFBLhYTWrePKr3q3DfxPYYVgnXfDkkI93c+x+23Si9Ld4pQvmaZmytbZA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707332655; c=relaxed/simple; bh=1eMoQIwa2v9F1EG4OnTgU45DkG8KXU0lJOhuCKUtpaA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=a1o4K0NeNoJvUU5JiuXUG1zoaEvf22KSrnyyRHrlCp5nZUi0AXN3/+rQVj89+izMAf7Q3F3VAy3KMiCIOrAqIQf/jkP/osETjROHDdlBM2o8zZ3/MzxIoi4kdFids+pzrsDAIHr9vkZD5E5a3wm9eDxtAD5t/NMiPj9FMqqHU+E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Dw1PNj2J; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 360BAC433C7; Wed, 7 Feb 2024 19:04:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707332654; bh=1eMoQIwa2v9F1EG4OnTgU45DkG8KXU0lJOhuCKUtpaA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Dw1PNj2JwItoT+3D9hyvFIPIS+84+F4sljILJ2R6pOzHBaf4n34CiMi04rSr0MVlT 6l2C1boXR6XQHK9XSRBs/nYGefkbidvcF2o2wW5lLaDrfOnedr8DN9PbiS621nsUAN zJ23Es244HUuvCxr86cSgIe8QtVZ2iBJjSHnXEVWJMbfBHsl3MOJiq347gqGmBp4rE wwOaFTAws8Sc7La3ricgbvn93g6wYX4Cu7q9MK0Kt7INR1SAnwA4KGoOG6CHlUOcgQ fkyc5GvF1EDUJm3Us8rNjObxRDXFIf/MV+wTjIhM7249UXqW0GXeMKoVtl74FqiBuX UyTtp+WW9YHng== Date: Wed, 7 Feb 2024 11:04:13 -0800 From: Jakub Kicinski To: Joe Damato Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, chuck.lever@oracle.com, jlayton@kernel.org, linux-api@vger.kernel.org, brauner@kernel.org, edumazet@google.com, davem@davemloft.net, alexander.duyck@gmail.com, sridhar.samudrala@intel.com, willemdebruijn.kernel@gmail.com, weiwan@google.com, David.Laight@ACULAB.COM, arnd@arndb.de, sdf@google.com, amritha.nambiar@intel.com, Alexander Viro , Jan Kara , linux-fsdevel@vger.kernel.org (open list:FILESYSTEMS (VFS and infrastructure)) Subject: Re: [PATCH net-next v6 1/4] eventpoll: support busy poll per epoll instance Message-ID: <20240207110413.0cfedc37@kernel.org> In-Reply-To: <20240205210453.11301-2-jdamato@fastly.com> References: <20240205210453.11301-1-jdamato@fastly.com> <20240205210453.11301-2-jdamato@fastly.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 5 Feb 2024 21:04:46 +0000 Joe Damato wrote: > Allow busy polling on a per-epoll context basis. The per-epoll context > usec timeout value is preferred, but the pre-existing system wide sysctl > value is still supported if it specified. Why do we need u64 for usecs? I think u16 would do, and u32 would give a very solid "engineering margin". If it was discussed in previous versions I think it's worth explaining in the commit message.