Received: by 2002:a05:7412:2a8a:b0:fc:a2b0:25d7 with SMTP id u10csp511550rdh; Wed, 7 Feb 2024 11:05:56 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWgoVvFnsPCgQ7dQEioQncZguPoQ2isn2LK6EHst3OcC1O1PbfQns2yhJulrDK7FkeRQ4sJCs3G34Ww/42T9wicxAXkCnWFuh306t5vCg== X-Google-Smtp-Source: AGHT+IF+mreSDjIZQWc6TrVXu6moGbxtuiCIL9eJs2yMvwgb22C4tSvaHmyoLJwIc6mWTW67BAxX X-Received: by 2002:ae9:e641:0:b0:785:909c:19b6 with SMTP id x1-20020ae9e641000000b00785909c19b6mr4954848qkl.2.1707332755858; Wed, 07 Feb 2024 11:05:55 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707332755; cv=pass; d=google.com; s=arc-20160816; b=Nzhr9bBm+UDVzU9Z3PLi5Ag/N8ukIELBEItqJQewZbXill+IsTDuQ+ovsiZH/KXxhA x74H3ibsMMoUh02/De8mUxS4zCifkEbRExztWEkFKRVnlQ7/8zWlfITtb+8Dt/0+WpZS xxakhiVLQVX2Bu5d6l4wvmSkkqr+Z6jzZk+6RBjz47oAf6RnawKqlkxz3dX38rVTUYJD ItospAZUeh6Nf+EGGn5IBL+dwYB2s+EiPDQ9y/YvT3QDhe7oVduu5396fBo9RKUNAMRy TunS6R+Apiyo7QSZo0HNC6Zye/mkN2nndWjFJhlg6VTMPzAHM+hP5vZ/nyBmFOg8PJ97 l6SQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=KAVPNm6oaZ9b8OHkkLjgnm5MABzaEUdCbRvGmgk4FGg=; fh=j7wgCbeSkNjMHzo7qIEcOw+i1hjfkvNAcDpF5eqfh+U=; b=fmg9F/9nZ5uIfP9eqZ/4yijs5XrNHELCMXf3XWGtLzCXkGYQVZkOh4cUNZWIDIPppt QCfBoDFNJVSe5u2jKcHTmJwQ4xO5gZKCxVrNAPTz3Do3liU97rqc2gbeHoqU38WEtgkl ggoh4v4xb1BdXBhNXjMqL3tWH9WO6/u+pHW8fetx825cYJcah4lAKvX2Sz41evMjEpX1 LAhTt8up/cdVq1xHUsLJ8MpZCFJhsAeX9w+FQxTMGOrwTcDsMJsjaqR8aiV0er/0i2Iq gX/Vk0cuVDW4vRjbo1azP47Yvm+D3hvMfYJm8wdwlF8UKG+VbkyBhoQ2irC20sifDkSG Gnnw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ENQrnzkO; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-56970-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56970-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCXe5cgjXZtLgsODBBQ4y05kNBoeugnRRbCJLwKNP42i9Qz4d/oad94a7pJeYx6tbJhvtAmHDARP3l93YYTgjSdIXMwWKqDBshKpP5/+OQ== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id u16-20020a05620a455000b0078403334a6fsi581570qkp.733.2024.02.07.11.05.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 11:05:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-56970-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ENQrnzkO; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-56970-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56970-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 68B831C21FFA for ; Wed, 7 Feb 2024 19:05:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8BA6886ADD; Wed, 7 Feb 2024 19:04:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ENQrnzkO" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99CB88564B; Wed, 7 Feb 2024 19:04:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707332679; cv=none; b=mvzQ1RzPJmdvxr5YmpEn2LYaJODwtX5/OFDGbM+qJc97g3bw0Ri0AxkZX+ldxakc1nV+ReEvHtK1yaFxWlCO0p9Cr010pvGNDn4g2hnIjkzMEAmbMJjng6LtvucLLcVaYUF11oNZ54c9Zs9NnGBBnfAt0zncM9EG2o4f+YPdeQc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707332679; c=relaxed/simple; bh=5GVhqpjuJPE3FvDUZWAwDUtgj5KWUa1cTo/8uxteTSY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qgiq3wyX8djdFoMGGhHa9trBFU7deowuaZrzs86mRqqvxeYeMjzj7c01GDNKdv67iOOiEGIf4kWWSLgKr3xn1Ygk0zznlmO+Vm4BWqujF552JFQ6Qo0uiq09xkvuHltpu3z4jYkT3c/iXloDmTMKDk6zmNsbWWS5+IHyMOdkvvI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ENQrnzkO; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F337C433C7; Wed, 7 Feb 2024 19:04:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707332679; bh=5GVhqpjuJPE3FvDUZWAwDUtgj5KWUa1cTo/8uxteTSY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ENQrnzkOPesZKqiDU0cwLn6XoCVLAjhIas4QUugytVYKxIG6Ba3AAqFcM4GdT4lKE ZIfO4DJkgQ2SumZp9LXEi1kNi30mL3Uc/OnlYY+cq7ElPW8rEFM2oaARX/iHE5iQXF l0LSvClRKd072SrfoHcrqBEvIm6rmJa3ALLMeloOH9BE6HIC7M/PFr1u9X6RkoLyJE d6rasc/zNnMTcS7TOx95EfuDYryAmxUEXZfrKk5TAXjOE3w7wI7r8TASZjU0md0wxM QgGwhSp1i4pwA3EiydfHLf969TbHVr9X9bKjDRjFz9cRJfYaBxu9JvbXmn5NkCL72q rPBnlttOAE8vw== Date: Wed, 7 Feb 2024 11:04:37 -0800 From: Jakub Kicinski To: Joe Damato Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, chuck.lever@oracle.com, jlayton@kernel.org, linux-api@vger.kernel.org, brauner@kernel.org, edumazet@google.com, davem@davemloft.net, alexander.duyck@gmail.com, sridhar.samudrala@intel.com, willemdebruijn.kernel@gmail.com, weiwan@google.com, David.Laight@ACULAB.COM, arnd@arndb.de, sdf@google.com, amritha.nambiar@intel.com, Alexander Viro , Jan Kara , linux-fsdevel@vger.kernel.org (open list:FILESYSTEMS (VFS and infrastructure)) Subject: Re: [PATCH net-next v6 3/4] eventpoll: Add per-epoll prefer busy poll option Message-ID: <20240207110437.292f7eaf@kernel.org> In-Reply-To: <20240205210453.11301-4-jdamato@fastly.com> References: <20240205210453.11301-1-jdamato@fastly.com> <20240205210453.11301-4-jdamato@fastly.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 5 Feb 2024 21:04:48 +0000 Joe Damato wrote: > When using epoll-based busy poll, the prefer_busy_poll option is hardcoded > to false. Users may want to enable prefer_busy_poll to be used in > conjunction with gro_flush_timeout and defer_hard_irqs_count to keep device > IRQs masked. > > Other busy poll methods allow enabling or disabling prefer busy poll via > SO_PREFER_BUSY_POLL, but epoll-based busy polling uses a hardcoded value. > > Fix this edge case by adding support for a per-epoll context > prefer_busy_poll option. The default is false, as it was hardcoded before > this change. Reviewed-by: Jakub Kicinski