Received: by 2002:a05:7412:2a8a:b0:fc:a2b0:25d7 with SMTP id u10csp516155rdh; Wed, 7 Feb 2024 11:14:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IGUgtKcjmlJfpLLfCvLAWSw8OgBfQO5dG7xE1/+lxmqixIEZ7LWiYJ+iN2iUa/EkOmlVBVh X-Received: by 2002:a17:903:228b:b0:1d9:7ebe:432a with SMTP id b11-20020a170903228b00b001d97ebe432amr6859744plh.30.1707333283801; Wed, 07 Feb 2024 11:14:43 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707333283; cv=pass; d=google.com; s=arc-20160816; b=I3+w9KFETRvOcZn/E7b7INaObeNZhAmac5wAwKpr2XkoWMXfY+K4r/roSv0oGhhKlg c0GLMil3BC2dliFLy3UyDjZRJEziMO3lALiI8l8k6mfYU5lmg3BxbNh4L+0XeX25kEzv GRcS/qHU6xTxOXxUHhR4G1zPnB58TmtrpxvzVNpKBkb1lOs8OKds4zZQaEo64GyK0OxG GzboyXWc8o9oVuLvjcEXnZJzDaCRqUk+aMI4p0zsBpbJL3XdiTLIk3zob9vBC1XST+oh dUdKnUvLVUUKQ8kN4nIK6vsPSiVeoK9JRrZ1sZF6+RP64tEbpEszq94Km3oslXz7Yhc6 vc0Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=T/rKAwAEfKEl02Xj6qqBCTszWTSTMP2vNPDD2/t6tnk=; fh=cQwvB4101aii1C6EkcKUN1y69NxbehECvEkUrBSoW5M=; b=RlbRWYxWuCOceaTL8cDHMvsG6FZCPTZJp0xgGjelPwINyEiaP9pbX4n4xtt/cTOmoU DXBlmNVyOKY5T+PwICDwckL46rd6mN4SvrMsRp9S1tovED5ss5HqM3t5d/V79G53L2iN 9MsSICZwu4tZeRG7IuVIEFpqiSEwUXQ0XSO5NhXa3hBgEIYHY0bNoFc15cpU0hsr6dxP Efb7Ec0+FLBXyrwpDO9jVFDTb7KloioEqkP68qEvzNBau6zxky2UEKI+fKpI+F0OyRiM 13pO8ky3uCVYWjoLerDn9b1r3Wr/9rUvBjJUSEtQAj386baXKE90n7il8BYK7+nar1vf 2p6Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@fastly.com header.s=google header.b=fZONvztv; arc=pass (i=1 spf=pass spfdomain=fastly.com dkim=pass dkdomain=fastly.com dmarc=pass fromdomain=fastly.com); spf=pass (google.com: domain of linux-kernel+bounces-56978-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56978-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=fastly.com X-Forwarded-Encrypted: i=2; AJvYcCUsFmfN1VBcCBdhPUMXJEjtCgy/BfHhHA1g7NudIXnnPtmr0orURVl7Q2iGme/TMswFxmDshH8Jhwl/iB2TDTkY3Ge8s5wigCS7Ldu9Hw== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id p14-20020a170902e74e00b001d6f7b3f65csi2581208plf.43.2024.02.07.11.14.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 11:14:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-56978-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@fastly.com header.s=google header.b=fZONvztv; arc=pass (i=1 spf=pass spfdomain=fastly.com dkim=pass dkdomain=fastly.com dmarc=pass fromdomain=fastly.com); spf=pass (google.com: domain of linux-kernel+bounces-56978-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56978-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=fastly.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 641E72838F1 for ; Wed, 7 Feb 2024 19:14:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7A5EC85C50; Wed, 7 Feb 2024 19:14:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b="fZONvztv" Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43CB58562A for ; Wed, 7 Feb 2024 19:14:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707333253; cv=none; b=XS2L3UPiJQsyY7UVVCFSAH2DkbgvuhppmP4MCGBEK4HoDn44NH7c08TxovlrCFAD3Ww39MTFH72g0hwD7tSmQJt0gU04nZ4XkHGD6yLMd01TTTQJCcv3zRz9FY/ZA59hJOe8vT4+hDL4YiaXn9tP4eqfafmMaOgO/jy/VNhervw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707333253; c=relaxed/simple; bh=KXyViLhzEsxPVRLuCQTh8V/0OZj8FhwAW35ZH0hE6T4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sUwCKHgEp+qWiQ6/k0jI0nU5mkA/RnwOQs+Zdl0tUz/k9z31ou7YM0VQJrV0Ygt3CfDKApL8YeGIbqYiSXwP1/5v7reixcWVgPIq+cGIXtP6m2UHc5PvOKkdlxyZNdm1Y290VZWJnFyM88iS+RBmhpQ53JKWOHhHAGr/w7oI0Ig= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com; spf=pass smtp.mailfrom=fastly.com; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.b=fZONvztv; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=fastly.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastly.com Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-6e06725a08dso687408b3a.3 for ; Wed, 07 Feb 2024 11:14:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; t=1707333251; x=1707938051; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=T/rKAwAEfKEl02Xj6qqBCTszWTSTMP2vNPDD2/t6tnk=; b=fZONvztvWp/mxTS/uTGQypIynf86WVnSbEmWNHzk+PaiWqyK5G/d+Yj3XU+/5BBrJl EcOECn3E9BQNGwzGXP1AcygtG5IDuYYbp00qHpoUD+Ffjw+sHd5X8aD/uMAvCY64aPVR cs4cYkBoNN/8yfZjLB8T/WdCCoPp6B5VKr5O8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707333251; x=1707938051; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=T/rKAwAEfKEl02Xj6qqBCTszWTSTMP2vNPDD2/t6tnk=; b=BuiiZFMF+ObSOn+IUPCV7bglWSL2upceDJRbqhiKFyQrvD+yd980Dxbc1EgnMWOb8l nwQPZYY6aUORI0EvnwrZFPbwEMJ9FXUqFw8M8kKp9//B63PiLiznqVqbbYtLSt5qNwmW pU5vs91qJS28OnvEq63Zl4fg++njH5E0t5/Uktn12MEJ1CsfJmnb8S330dTrMN7p2l+0 8vD6tKSzDPmIgIZ/PAK4Kb/10B0eOeCzBdMEYX0+7qx8mLK/KcgRnKoL7R84zpJl8StW x8Ylr6kfWT1k5GnFZ/4NPKDG9AYO0BFu+McDoZJDxqJShNM0q85vAZ7g4Q+cbplJ39pM iWbQ== X-Gm-Message-State: AOJu0YxdCiXRy+3uI3CqLjOUfPxSrAL7CUSMr/u6Mt+l9PLvrX/klQOr HVduThRT2/O9DvTmi8ic2qfD44WH7fOgs2hAo36A7pvbZgwl5F4kWUjudblcWuM= X-Received: by 2002:a05:6a20:8698:b0:19c:93c2:7ef3 with SMTP id k24-20020a056a20869800b0019c93c27ef3mr4183085pze.46.1707333251675; Wed, 07 Feb 2024 11:14:11 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVG+1M2cR4xp1y1p4GRK3cgTXg3DcbRpzJZL35j2Vm4cwz7Mu6m3KbetTNBxQ0yfcUQ0B6QdBnQhYcYfXGNvcvGnukOln5ehLAoTx6v0kcWWHpMrzdj6NTydogDKldDrmIyQiKPf2DzeR5hVWjWMYRMD8BQteYm3r/cbFQ36wwpODv3aGXQKYlp/Qh58DyKHxSO2rld6GX0EbALHj6Am4Ey/O6WuoqwMxe+X81LGnF7OkJqEeNMJZNJMSJVnuMEFcCB4t8aTu+OG5Z4vqa+9T+H1EPf0rq1ZFjKVlITrpujOtfIGCwcLTYjnefAtwZtvkE+rv8FMyYcDl8hLNeBbuKg4roZEa7kh0rKW4JF6rFA4XmdhpRGPrlf30Q2Q55DGrjZ3p38U+DJ4f0RCBUmR5lTmLovGVj+7rfPOBwDp+nNgJBLsNUxjF32r58L0AywfMjppdJQMOIThgRY6LK++kDoPlmvb2G4/g2EriU8U4e5vB5tluDE+QL9xEo2EkNR0XnoRZ9bgXcqyVJH3w2svwdvpvLAT/RMhAt+c8RulCOeaa8HSuIJRh0p6LUzii9RT0JC3jGAizO8YPDw4qfVznxRvpw4niUyVmg2mjOasSvLQw== Received: from fastly.com (c-24-6-151-244.hsd1.ca.comcast.net. [24.6.151.244]) by smtp.gmail.com with ESMTPSA id mi7-20020a170902fcc700b001d6f8b31ddcsm1819227plb.3.2024.02.07.11.14.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Feb 2024 11:14:11 -0800 (PST) Date: Wed, 7 Feb 2024 11:14:08 -0800 From: Joe Damato To: Jakub Kicinski Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, chuck.lever@oracle.com, jlayton@kernel.org, linux-api@vger.kernel.org, brauner@kernel.org, edumazet@google.com, davem@davemloft.net, alexander.duyck@gmail.com, sridhar.samudrala@intel.com, willemdebruijn.kernel@gmail.com, weiwan@google.com, David.Laight@ACULAB.COM, arnd@arndb.de, sdf@google.com, amritha.nambiar@intel.com, Alexander Viro , Jan Kara , "open list:FILESYSTEMS (VFS and infrastructure)" Subject: Re: [PATCH net-next v6 1/4] eventpoll: support busy poll per epoll instance Message-ID: <20240207191407.GA1313@fastly.com> References: <20240205210453.11301-1-jdamato@fastly.com> <20240205210453.11301-2-jdamato@fastly.com> <20240207110413.0cfedc37@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240207110413.0cfedc37@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) On Wed, Feb 07, 2024 at 11:04:13AM -0800, Jakub Kicinski wrote: > On Mon, 5 Feb 2024 21:04:46 +0000 Joe Damato wrote: > > Allow busy polling on a per-epoll context basis. The per-epoll context > > usec timeout value is preferred, but the pre-existing system wide sysctl > > value is still supported if it specified. > > Why do we need u64 for usecs? I think u16 would do, and u32 would give > a very solid "engineering margin". If it was discussed in previous > versions I think it's worth explaining in the commit message. In patch 4/4 the value is limited to U32_MAX, but if you prefer I use a u32 here instead, I can make that change.