Received-SPF: pass (google.com: domain of linux-kernel+bounces-57004-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <22088ed3-51a4-415f-932c-db84c92a2812@intel.com>
Date: Wed, 7 Feb 2024 12:16:53 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC PATCH v2 0/4] tsm: Runtime measurement registers ABI
To: Dan Williams <dan.j.williams@intel.com>, James Bottomley
	<James.Bottomley@hansenpartnership.com>, Kuppuswamy Sathyanarayanan
	<sathyanarayanan.kuppuswamy@linux.intel.com>, Dan Middleton
	<dan.middleton@linux.intel.com>, Samuel Ortiz <sameo@rivosinc.com>
CC: Qinkun Bao <qinkun@google.com>, "Yao, Jiewen" <jiewen.yao@intel.com>,
	Dionna Amalie Glaze <dionnaglaze@google.com>, <biao.lu@intel.com>,
	<linux-coco@lists.linux.dev>, <linux-integrity@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
References: <20240128212532.2754325-1-sameo@rivosinc.com>
 <c17a31e4fb30f5f9d4a337e5bd8d54cc6f99eef7.camel@HansenPartnership.com>
 <a255bc36-2438-41b7-b304-bcf7a6628bef@linux.intel.com>
 <42e14f74d3819c95fdb97cd2e9b2829dcb1b1563.camel@HansenPartnership.com>
 <1557f98a-3d52-4a02-992b-4401c7c85dd7@linux.intel.com>
 <85b7a4a679eada1d17b311bf004c2d9e18ab5cd3.camel@HansenPartnership.com>
 <b8140cc8-a56b-40f6-a593-7be49db14c77@intel.com>
 <fe1722c3618a8216cb53b8fd3f1b7cbb6fdff5a0.camel@HansenPartnership.com>
 <65c2e4aa54a0_d4122947f@dwillia2-mobl3.amr.corp.intel.com.notmuch>
Content-Language: en-US
From: "Xing, Cedric" <cedric.xing@intel.com>
In-Reply-To: <65c2e4aa54a0_d4122947f@dwillia2-mobl3.amr.corp.intel.com.notmuch>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b3ZnMnI4VFZoTkwraCtPY3VSL0RSVy85T2tnRWNXZlllWmRWYmVRd210dlhB?=
 =?utf-8?B?MTVWQ2dmc0hYbkswZ3pGSThLd3Mza0RtbElNTVdodmxJK2Exald1VjhvT1NF?=
 =?utf-8?B?bmZ4SjlqOXNlTlUxZlY1UHNkblJLdlU3UGsva2VJaEd2OW5XZ0U5T1YvVkpm?=
 =?utf-8?B?bWxGM0Q2eHUwbm1lbFRVVDZmajFLVEpYb1IwelFIc2dBQ29GNS9XL1VkR2xa?=
 =?utf-8?B?ZEwwL2ZJWXFDcS9UWDJQVUpZTTR2Zk82ZFBoUXYzTHE0YWExM2tLSzl6UkR0?=
 =?utf-8?B?dnk0ZWpRN3RMeFp0VmpraHBRaE95OW1oVS9yVzArOGZZSC9FaW1YS2JXaVZG?=
 =?utf-8?B?N2laUGsrS28yeFY3N1pweWgzZjVNanlXR1BYZERTUmIvb3JPdkpSQUJCejBm?=
 =?utf-8?B?UkN0dlpqRDBYcEJBRU5sMUdEdVpENWpsSUluU0t5dWJtbmpKckNNMEF4aHMy?=
 =?utf-8?B?ZE9VMzlMU2tGdHVzLzdTRFM0NGE1V0dWOXpBbDBlRFRGNWx0eXlMQ2c3eGph?=
 =?utf-8?B?aTREM1M0V3JiZnhETVVDR045b3AxRXl6S0VxMldLdkdDVE1BVjZra2tpcWIx?=
 =?utf-8?B?SWF2QjhKZGYrYnU5V09mVVF3cE9MdUJERWpsTGVKVytlSFFlRHNCYWxGdzly?=
 =?utf-8?B?eEI3UEcwSGNtRS9iV3pCMGxRUXJsYVUwNGVhREFCSEEvQWh4amxXd0pxcCtW?=
 =?utf-8?B?WmtCa0daVEVwSEtyajNwLzdTN0VGekhTczAvenh5WTVFQjVmYlBvOUdEeTRG?=
 =?utf-8?B?Wnh0enFhWHlhc0c4cmFMRThrc1E1ZXpSRERRKzNwSmtpLzNDTWJBVjVwUGl6?=
 =?utf-8?B?Z2dpdU5uc2J2QTVoMFBQTVZSenhYWE4rcTlmVTlyVlJuVFJaUEtmTmEzRW1l?=
 =?utf-8?B?UmIxTjEzbVVwemprY2pQd0tZajdDOWhOSGlEMlI3Tk01Y3BtTm90R3duVlE4?=
 =?utf-8?B?cHVuOU9aZ0swUE53Rk1KS3NQVEtjays2bHM1Mmptd3JzYXIweHArcWJndzBU?=
 =?utf-8?B?UWhNaGNzWDR5UmZRZjdiOElaT3Y1NWZnT1FDTG9oTW1MUDlZanpCMjRsVm10?=
 =?utf-8?B?ZDc4OWVCOFAwRk10UkN3azV2U29HSWNXbDJsSGxYT2QxcnpFejFURytMaVds?=
 =?utf-8?B?T2NZWEY5dTZvOUtEeHRPQmVpV1NSb1lKSU5CUmVYVmhZa3JxUENFRjVFK0ZU?=
 =?utf-8?B?RFgzamxBMFByVVVjWFZMWXpiY2JJZHp5R2NHZWszMHFtdGJNVHRRdXNrc0Qr?=
 =?utf-8?B?SVpkR2x1dVdPNnE2dTk2UEw0b01TUlVaaWxKZnZHNzZLQXlWNnpNMUVNSmNh?=
 =?utf-8?B?dUJlTEtmTmhEblFuWG9Rbll5YXpoVFozQXhjaE5XS1dFS3ZFWXVVQW12SjEz?=
 =?utf-8?B?UWpKakNSK3F6YlhjdG1qbEVaQ3cwVHBWdnltUVJOQlM5QXBpaERaRmdBUTVV?=
 =?utf-8?B?eHJGNm9rdE1DTFNORnRueC9BeTZxV1hhNEpBMlBteFlRYUZ0T0NhdWlBbDEr?=
 =?utf-8?B?bEJEa2ZPR3JjaHhESkcyOVY0Rk1TMnh1bHdLMXV1clErRUVocFBuaDJOdWp1?=
 =?utf-8?B?b2wwaTREMEhDbzFKWm9PNU5lb203QWxTbFFiZG9JWmRsdDI0enByS3NEK3Rq?=
 =?utf-8?B?Tk00QXRXNTl2aGtiR2tTcEpXbHF2bE9mZFpwMUVjTHArU3N1c3ZPbWZCR3dM?=
 =?utf-8?B?U1loNVN5dTIvT1YvWEpZbEZzY201ODRqcFJDRTBDYlFsT3A1dXpxaE9uV2ZP?=
 =?utf-8?B?VVNicHZHQUovNi95MnpvRE1EV1kvR0o0dFQ1bnpQS1ZvWENpYXJUUldrc2Vx?=
 =?utf-8?B?dHgwU3FvVjlHMXFWSUtWbDIvQ0ZCeUt5aDVodGhQUUthTG1RVEJENy91MmFv?=
 =?utf-8?B?ZjVsaXB1VjA3ZWpSVXg0WnpYZmMvcWtnN25hQ2trWDZLRzNQOWZieXZyUUV1?=
 =?utf-8?B?V0xsVFhsOW5jcFk1QndNZHRSdXdCcm8wZENDZ1pRTm9VZS9YN0dwWU9nMkRn?=
 =?utf-8?B?MHdEZ0QzQy9DaWp4eDNxd05oV3czNzRzdzlEbXh0LzZPWFppV1JzQzVWZGNX?=
 =?utf-8?B?UGlTdlJiVHdZMXJrMUhjSUhXVGJLSDg2N2p4RzJFN2ZKbjBpamxBb3lId0VZ?=
 =?utf-8?Q?T9J8UDNUMlU5Ttg4Drs2GP/br?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5dea2f86-1f07-452e-a9e9-08dc2819bba0
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB6269.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2024 20:16:56.9529
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XI2zGJEozEWSFsuUZg8EmxrnCa5cl8ZftaiMMv1NRf1llEeuqN9rHVy+ACcpiQNukuSF76S3vUqPRR319n7iig==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7964
X-OriginatorOrg: intel.com

On 2/6/2024 6:02 PM, Dan Williams wrote:
> James Bottomley wrote:
>> There isn't really anything more complex about an interface that takes
>> a log entry, and does the record an extend, than an interface which
>> takes a PCR extension value.  So best practice would say that you
>> should create the ABI that you can't get wrong (log and record) rather
>> than creating one that causes additional problems for userspace.
> 
> Agree, there's no need for the kernel to leave deliberately pointy edges
> for userspace to trip over.
> 
> Cedric, almost every time we, kernel community, build an interface where
> userspace says "trust us, we know what we are doing" it inevitably
> results later in "whoops, turns out it would have helped if the kernel
> enforced structure here". So the log ABI adds that structure for the
> primary use cases.

Dan, I agree with your statement generally. But with the precedent of 
TPM module not maintaining a log, I just wonder if the addition of log 
would cause problems or force more changes to existing usages than 
necessary. For example, IMA has its own log and if changed to use RTMR, 
how would those 2 logs interoperate? We would also need to decide on a 
log format that can accommodate all applications.