Received: by 2002:a05:7412:2a8a:b0:fc:a2b0:25d7 with SMTP id u10csp565664rdh; Wed, 7 Feb 2024 13:00:43 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWymtdKHGHFLoX+FGPFCd8ZgFD3OvUiLIcLaNeLkZ6zlyoAUFuxg/efqeldLtwBU8HnSpTJuuNbULQndcUTCqGPNbhbVi/rPbRL9gHugA== X-Google-Smtp-Source: AGHT+IGbzaDxhAaKMM0zlWvd/ZBFN5oKvMpHB+33BtlVoWKN/neWbRfAGIHMBXB/9wwD0L4esFNJ X-Received: by 2002:a17:90a:b892:b0:296:e59a:476f with SMTP id o18-20020a17090ab89200b00296e59a476fmr2738002pjr.30.1707339643171; Wed, 07 Feb 2024 13:00:43 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707339643; cv=pass; d=google.com; s=arc-20160816; b=DZeUOk3yb9Z1ord9nAwiO2LwuQ0pRMKtp27eo+W1mTOzLxwLRG75626Cspvx7U2NuL LLcn+EEybvQNZ+OYeCz8zhkGfVBn3de3oO/pcnZIcVmUlNp4utF2pAGhSrF7YlWi8sm2 adikXOiI64+iV2HMe6C+X4m6bSOZFOJiVAQEfde1l3spGomB5lkOEGVsens5a8aKI/SQ DrmE5kiM1/rof7wcfdRkQrCjwt8Ur32y//3vwyM++UW5NZ/UwueIPgRvHqmwnnGXbjUX ilGYTCwYT5XDdHp/7pGmw8Je13axVO9azx0Q/MUMW7/3lqlyLImptKPOBUp23XtSqlns oHLg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=rrUT1OVs1EafzCjNcIxgi7mtdU6I4GMqqwAa5ghme2w=; fh=Xz86l8/Q/imr1sYI8uw//4aEdQE5a6+R9my7/tZEl7A=; b=dQLiZwH3L6Hav3g6UmGfgPILPBqBziPgWbK4AWPDOFupKPbD1+WMSxlw0uC5xvwqWT WPfVFJAM6WukXboDR6In3HgztHsucYHk3EJAvAn896ftM/XqFnqe+29eSPFzMW5EUAnS FtTpIeV2ylG0lwBHgDHbieBJPgUvDUaD8ViGcegdK2LDTtVp7M33utxobeHZJrW6msYZ fPrSLZ/vRv8oYz/WVdP9byJSk6S9XAs0TZL8C/24vm2Q4lrU7SyZm+MtXUdiJg68KFbW d1F02sTyLsnHGgWVwM5DgSeWTFd2+CTTBbSTmhAuCm3NuTwJ+7Oo/DRXlowR5pMWeDWR E5+Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kYut+V7K; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-57049-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-57049-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCVQ08viO4B51e1nbE6opY2FjKp610RcQSB1WEwhoTZCpUCSiu+ZbiSqm+wc+Ok8bjSciPtcLedw/fOn9Nq/kYBqC+lpqhQjaLN5ScGHVw== Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id cm23-20020a17090afa1700b002962f808626si4164780pjb.162.2024.02.07.13.00.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 13:00:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-57049-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kYut+V7K; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-57049-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-57049-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 939F9B27B56 for ; Wed, 7 Feb 2024 20:56:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6E526127B58; Wed, 7 Feb 2024 20:56:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kYut+V7K" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81E0A5A0EB; Wed, 7 Feb 2024 20:56:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707339391; cv=none; b=rZCcbH5wWd1k8Ze8CpscUuKEXpssKuc9F5qT6H5C+74Sj7yVGJ1r5eopYGY34JGFKZiJV7HpOi1JijRaDf3dRN7JAzigtCoI/aw3VaVT1XSKb5SNakhcOATj/oq7OqFkw2kTNcx1nojziN8BZtEr3L9/lg8l4OYs3vYy+vWqNDU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707339391; c=relaxed/simple; bh=O9TU/DdbGeLFdubQoNlLF1Trt2IeopsApf3EemlHi6Y=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QcArXmIok18WyXr4SytssJyKFAEuiV7OJcjHyQQZ+G32FIqhXgbuUCMHO6ScZPBBZBHPRh/4/vZ/3NK8DZ5BpkXhrM17+1So2O27LawZZEdFOaR0ieZw7DkVdn4g6daVWYtFv6LHz3bjSglh0Rh6OHy+0pNfIRQ5ltvBArmhvL0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kYut+V7K; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96A5AC433C7; Wed, 7 Feb 2024 20:56:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707339390; bh=O9TU/DdbGeLFdubQoNlLF1Trt2IeopsApf3EemlHi6Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kYut+V7KhMj1sRThLMAxbOr3ZEjyRsnXLexMXFD7K9mPevhW7o4xU+pjGquYXHx5G SXrQkIL9faPgy5DgiOzV/Iz8yUin1c7ruI0qLvomSJq10HTjZ93tqPT0+C88g8vLDf e3KKoEsbfCwMDjWggS6+imu99xHx9aA082xeW/vW1ZQOsIwTb6kJcgUtqUgGjS3SFQ seCQSVN2HjpFt0SEyrxiEw5rq9qlURCgDqO5qQz1C9v2hncxVYu6J3l8Otu1mMJdk4 81G2h8skksL3mIfLwwLtHX3izqkg92hwKoVESIkdMKbU3FMkNB7U2E0L85PTdZT81h 0lnLScoQH0AyA== Date: Wed, 7 Feb 2024 12:56:28 -0800 From: Jakub Kicinski To: Joe Damato Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, chuck.lever@oracle.com, jlayton@kernel.org, linux-api@vger.kernel.org, brauner@kernel.org, edumazet@google.com, davem@davemloft.net, alexander.duyck@gmail.com, sridhar.samudrala@intel.com, willemdebruijn.kernel@gmail.com, weiwan@google.com, David.Laight@ACULAB.COM, arnd@arndb.de, sdf@google.com, amritha.nambiar@intel.com, Alexander Viro , Jan Kara , "open list:FILESYSTEMS (VFS and infrastructure)" Subject: Re: [PATCH net-next v6 1/4] eventpoll: support busy poll per epoll instance Message-ID: <20240207125628.44c5d732@kernel.org> In-Reply-To: <20240207202323.GA1283@fastly.com> References: <20240205210453.11301-1-jdamato@fastly.com> <20240205210453.11301-2-jdamato@fastly.com> <20240207110413.0cfedc37@kernel.org> <20240207191407.GA1313@fastly.com> <20240207121124.12941ed9@kernel.org> <20240207202323.GA1283@fastly.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 7 Feb 2024 12:23:23 -0800 Joe Damato wrote: > > Unless you have a clear reason not to, I think using u32 would be more > > natural? If my head math is right the range for u32 is 4096 sec, > > slightly over an hour? I'd use u32 and limit it to S32_MAX. > > OK, that seems fine. Sorry for the noob question, but since that represents > a fucntional change to patch 4/4, I believe I would need to drop Jiri's > Reviewed-by, is that right? I'd default to keeping it. But the review tag retention rules are one of the more subjective things in kernel developments.