Received-SPF: pass (google.com: domain of linux-kernel+bounces-57250-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Wed, 7 Feb 2024 17:14:01 -0500
From: Frank Li <Frank.li@nxp.com>
To: Conor Dooley <conor@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Felipe Balbi <balbi@kernel.org>,
	Thinh Nguyen <Thinh.Nguyen@synopsys.com>, linux-usb@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	imx@lists.linux.dev
Subject: Re: [PATCH 0/2] usb: dwc3: drop 'quirk' suffix at
 snps,host-vbus-glitches-quirk
Message-ID: <ZcQAqVViPHcbgn52@lizhi-Precision-Tower-5810>
References: <20240207-vbus-glitch-v1-0-7be87099461d@nxp.com>
 <20240207-settling-drone-90e6f10a3476@spud>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240207-settling-drone-90e6f10a3476@spud>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?ORRe1aygBXDEHEafBW+sGZMYF/GIW17ntUORghTMZ/ENplNpRy6CeMGtFZVh?=
 =?us-ascii?Q?9ph3CIdavDvn1ybtXpwBYjmuS7Jctu2l2zWtQTRnPRapaEfegnB2KwttvBrd?=
 =?us-ascii?Q?rI6umN7CEkOQ++6DqKponPDWoqtETR6y2d4q0fmovbRStyhX9LnZwlQXEc6C?=
 =?us-ascii?Q?PkQiYT4rcltFplqdO9z1zjrwaKLjWFXhoAVjVPMXty16JodFRr2Dg/7wl9yp?=
 =?us-ascii?Q?DIRwKSzH997ctQzLFkHjn8f18B6XTxdqz4ew0MV2+4Z/J9kdihZ0IZwkW6kN?=
 =?us-ascii?Q?OHs71dq6dGMoavAY9NiNuweL4EWfeRAf4JlOQ2Sk7RlWSL+R1SuzMxOEiEIN?=
 =?us-ascii?Q?SxuLbxcGcVcljPWCwlG7AVOK2oEGBeYq43pA8r0VU446yWQJcPS+nV4lS/3r?=
 =?us-ascii?Q?mqLWd+lzsVO+pqbg4wFuNrGP5k1ZZIz0m+fwIj9+Ke7jUbpY4c6gIe88MQva?=
 =?us-ascii?Q?hfDIkBU6vmwBXq2FqCXxMgu58bIGnqVhO8zosSb5sTbPdVf8BxkdkwvgRk4P?=
 =?us-ascii?Q?URLDgXftaunC4O8y3+k39R/ZuEF66bNUsvom+MxLQ2b3MjAfMIsJCwUydOeS?=
 =?us-ascii?Q?dZp+ow4nJSIfcIK2NE4KHCN3VOsie+Q5uwsSTR4LM0z0aUKGmvegfDO8EKDW?=
 =?us-ascii?Q?T4W/wk/MAQoO1ZBm9PHETGwy9KtfCGLx1uVsA7hBI+NP6fxhjIjOCSsU9xZO?=
 =?us-ascii?Q?aIToJzeQTk5TR+FTQ2AZMNDMb7D52WwMRcPZESi6eq7xd6hvfaL6YFndBxfN?=
 =?us-ascii?Q?MX1/Yybtq0NHPcLk654vvDwEOW1GWaNpJ9OeuDTOx8JBnyaafCRNWYVcC192?=
 =?us-ascii?Q?5+OMrhAMyEqTpbpL+dtKbDECOwLQUAbzZMRb+b8AegJun5GtARfQm4pidO/7?=
 =?us-ascii?Q?wKqzl47/LyuKrxTovN84Iz7FNQebBa4gWMdRo4OnGPYIPYjzRRRh+/vqf+Eo?=
 =?us-ascii?Q?bLGt0kmTGSWpM6dvCYUs+4LQgdavBNmiK7jufHgeBqxQm3xI1FZ20cTYVj3H?=
 =?us-ascii?Q?LfcPd5NNbJ7WwVTCrWLtK+mMIBcM1rvrk5fdrECP1PYLfJR3z8teQVymuxfo?=
 =?us-ascii?Q?8KTzc31tGQNrVd32zMsvdUXwP5HflnN2Lr0BSHAUHhrsS2nobKGEZ88bt1tY?=
 =?us-ascii?Q?lu6SWCAGowAqiSwHUp5aJlpZyAXEqsuCt4LU0yfoxs7B8o26TD+NojsBnXv5?=
 =?us-ascii?Q?bGyJDrk5E5y/SohN8DEqKCgLx7iBut8iruZgoP3/DdUKwZqZjbnXAlrtseXK?=
 =?us-ascii?Q?7H1a9C+vdmUx8ap4YXCvrrn00LGh0QQFc98TQvFj6DeerD2XbD3l7GWELmiL?=
 =?us-ascii?Q?xLAefM9YOEPjQnfMaCI13LDQtYpCj9gvtP2QF0Iy9qfP8lHpwFbGHFT+2aQj?=
 =?us-ascii?Q?R3folbEo16V4uwwTeEvMSy7uKPBhV2qHoGhFMkbY4h9hqIPAThJtDR0xG85+?=
 =?us-ascii?Q?1w3yXidQVDrnYUkFM5YrtBqcBcLJzUZZgKNSulS18lCAo5ggRHhF5k8yPZA1?=
 =?us-ascii?Q?LdlgR8lvBfar/dTq9XNwTRlEb/nEZe/6XvTVBeMf43Yjyxi3wCd5bX3MruVM?=
 =?us-ascii?Q?4KL5MPIhluWOQZS3uyk=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cdc7de4a-5a50-40be-c65b-08dc282a1b34
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2024 22:14:09.1293
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 916pL/kkFPw4SpjyIYD/leYtexJeD9FtdUcwM5oDNr1BpW4peRTpzhyqmUP53qFsmD2Yn+Q+tNs8Ll3ytJx93g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7914

On Wed, Feb 07, 2024 at 10:05:23PM +0000, Conor Dooley wrote:
> On Wed, Feb 07, 2024 at 05:00:17PM -0500, Frank Li wrote:
> > Since dt maintainer give comments at old thread
> > https://lore.kernel.org/linux-usb/20240119213130.3147517-1-Frank.Li@nxp.com/
> > 
> > The patch v4 already merged.
> > https://lore.kernel.org/linux-usb/20240124152525.3910311-1-Frank.Li@nxp.com/
> > 
> > So submit new patch to rename snps,host-vbus-glitches-quirk to
> > snps,host-vbus-glitches to align dt maintainer's comments.
> 
> I thought the last comment left on the v1 was Thinh agreeing that a
> DT property was not needed here and we should be able to apply this
> conditionally?

I don't think so. This is workaround. We can use this track which chip
actually need this. If some year later, such chips already end of life.
We have chance to clear up these code. Otherwise, it will keep there for
ever.

And I am not sure that the side effect for other chips. Workaround should
be applied as less as possible.

Frank