Received-SPF: pass (google.com: domain of linux-kernel+bounces-57258-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <e86c920a-c328-4fdf-b060-155216dafccb@amd.com>
Date: Wed, 7 Feb 2024 16:34:50 -0600
User-Agent: Mozilla Thunderbird Beta
Subject: Re: [PATCH v5] remoteproc: Make rproc_get_by_phandle() work for
 clusters
Content-Language: en-US
From: Tanmay Shah <tanmay.shah@amd.com>
To: andersson@kernel.org, mathieu.poirier@linaro.org
Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
 Ben Levinsky <ben.levinsky@xilinx.com>, Tarak Reddy <tarak.reddy@amd.com>
References: <20240130154849.1018666-1-tanmay.shah@amd.com>
 <0f4905b4-9972-40ce-85f4-0880f273d7dc@amd.com>
In-Reply-To: <0f4905b4-9972-40ce-85f4-0880f273d7dc@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?a0QrelIrM09qMFFaTEpKeUJxV1VzZWFMNW1DUjJUQnpJWEg5dCtBcnluQVZG?=
 =?utf-8?B?MFQ5K2xjZ0w4MG5SbUl3b3EzbWhOcUdEYW5Ob1VzNG9qbnFQNys2eGtwYzk2?=
 =?utf-8?B?ZTZTOWxwQlRmQk5TUSsyR0JxRmhPN1BtUmlic21KY0pOOWlOQ2c4a1U1N3Bu?=
 =?utf-8?B?OWp6ajBJbk90dklqbUtTTDdWcDlKeTl2YUxiQ05teU56OVdaaFY5dXZzb3Jp?=
 =?utf-8?B?KzJXWHBTQ0NYTFlnbUVQYmE0Nm9zVy9WZFpqOVBORDZBbll2anlkVDE2NzlY?=
 =?utf-8?B?QkhTdTRTaW5HK3RxSWVQUHp2SCtTTWl3SURBbCtLN0xuRkRjWDlIcE54cFlF?=
 =?utf-8?B?L2MyZHRvVUZqR25rNlMyeWFEZGl1aWg2aUl0UTJESDJtTThQNWdMQzdob3Fk?=
 =?utf-8?B?dTRpUGRDNUxCNHR4MDd0eGlEL0pjOS9Qc0RiaXpGWEUvS2o4WlcweHFNdW5N?=
 =?utf-8?B?Z0d1ejF2bkJWM202aDRMbnpEcGtUb3gxc0Z6ZUV0SmFHb0VNbFZrM05udVoy?=
 =?utf-8?B?WTZnMXNoT3BHSXd3dXdJWlh1NGFmRnBxdXBIc1k1WnJnU0VuZHdoS3l6U2VY?=
 =?utf-8?B?ODZuT1crcEdRVmJXZjFycjhERHppM2UzZ1NmN2E4MHNrZWZMWWdZQ1N3bTBs?=
 =?utf-8?B?dDFSQVZ0Q1pFaTRBdlFsL0xYeS83dm5zWUtJQWdNNHNOUGVELzE2K1ExalMz?=
 =?utf-8?B?V1Y5RU0xTVZTZEZ2U01DZVhXUEM0QmJYb1dZTWVNcTl0c2NaTzZZRFppMTBj?=
 =?utf-8?B?aUNwKzUvbVcwekVySGE4WUJSaEFsUE5wRkVLSXozSjk5bG9SOFFYdVRtZU42?=
 =?utf-8?B?eGVQbWFvRGo5M3hQaVFhRHRlSy9HMTZyVGppWFEybk9XM1hyVElsb1d4U3JN?=
 =?utf-8?B?TGdZcU1VbDRMejQzMEpacTlPU0lueGp1bVcydENJcy9reHp1dmxvak56QVhU?=
 =?utf-8?B?YmJLN2hrekcreWpPc3hDdDJZZVMrN2VKOTVvamllcDNUUzNDYkhYeG5lTFNr?=
 =?utf-8?B?bmpQRkE0RkpCdDlMVUNkZm43Z0U4N3RjanlJMmR2UERKME9xSVFsQkFYVktE?=
 =?utf-8?B?Q0NDS2EyVHNtQ21oUTBnUG1UYjVmRzNIUFY3OUE2Q0JVcm9YVlI5M0p1QnAx?=
 =?utf-8?B?U0YvMk1iTmhBUXZGODlvOVpObDhINzZLeTRyZ1BxNlhTUGdEa096UE8zYzBX?=
 =?utf-8?B?eVdsTDJDNGZCWVhFOHNvZmdoa29tbEJ3U1UwQThPL3RGZ25qRFZoVHdxMmRv?=
 =?utf-8?B?d3VXTURvd21pSkxVMExnKzVhUjQ4bFpNNnVaVVVYeGJzVTM4VzdLb1dmR1pY?=
 =?utf-8?B?U3YyL2FzK3JTS2F1ZHVyOE5oSU1yYVpnQnVLNElyT2dVamYyWFpwZEJtZ2dE?=
 =?utf-8?B?T2FNSWVRVTdLQTZ6SUI1Rzh0RGwzaU5SMXVmaFlHUFp0Zkl6aS9udU9kYnBz?=
 =?utf-8?B?SWhFakpmQzRuMllsay92YWR6aTFDanhkZU10MEEyb0lVSllZVHVRclp0RnpE?=
 =?utf-8?B?YXlrOTRlbTFDMjVGMFJncW5CZ05FSEhVekRGWnZVMjU1eFlZVWMvNWJzM2Fp?=
 =?utf-8?B?Um1UVGZjOVR5dlVnb0JwaXJTWlc5aDhYMVJGRG5pMi9jTzgvZGtoL3laNXQx?=
 =?utf-8?B?VndXMzdrREZJU2U3bjZvdFhRUjZTUHltVUJhdGVrQ2FCdWtEZkhyclUybFpE?=
 =?utf-8?B?QlR0SjNpMDRNbndhSkdsU1VKRXM4WUFvaUM5SkQrUHhCYWZTNTRyL3A3WHNS?=
 =?utf-8?B?aVpOWW9YV08xMFEyVHVyRHA1NUFURXJOdTNYT3RHTnVXRFBDaDNuR0doNkwx?=
 =?utf-8?B?YTNzMnhWWG5CMmV0RmtPOEI4NjBlNWczYnlGQW5NRi9rQklUZmJJWFBUZG1Z?=
 =?utf-8?B?bGxLVVVRTVp2ZUl1dGh3OTdvYWw2OEN1V3Q3NktiUnBzN2pNNEUzcUlrWVBz?=
 =?utf-8?B?eXVxREMycUNjakhpZEErVWJzekM4czYvZ0w0ZVVzU2RreTRJaVNTUmMvdHQw?=
 =?utf-8?B?Rml2MUdleDltSXY1V3JYWExtaVpTZys5WnRiZWptU0xzSWZVRWxqZlhIdzFY?=
 =?utf-8?B?djExOVQ2eENZY0xCMER1ZVpFY1R4UEJmMFRweW5SdlJ5Y2RjNXU4WmxwOVd4?=
 =?utf-8?Q?rDYiP3d+VzXltTUWSJS7hMBXI?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 931fbd1d-be1f-4c03-73a1-08dc282d0140
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5874.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2024 22:34:54.0404
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wbZRAZEbuEfUnjJbE+F8TUZ7WO+R8JELEM8yok2jJc0tJ8wrZ7qlvJF+g3GOTvO8
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5792

I am sorry, I missed the fact that this patch was picked up and available on for-next branch.

Won't be sending new one now.

Thanks,

Tanmay

On 2/7/24 4:18 PM, Tanmay Shah wrote:
> Rejected-by: Tanmay Shah <tanmay.shah@amd.com>
>
> I will send new v5 with change long included.
>
> On 1/30/24 9:48 AM, Tanmay Shah wrote:
> > From: Mathieu Poirier <mathieu.poirier@linaro.org>
> >
> > Multi-cluster remoteproc designs typically have the following DT
> > declaration:
> >
> >         remoteproc-cluster {
> >                 compatible = "soc,remoteproc-cluster";
> >
> >                 core0: core0 {
> >                         compatible = "soc,remoteproc-core"
> >                         memory-region;
> >                         sram;
> >                 };
> >
> >                 core1: core1 {
> >                         compatible = "soc,remoteproc-core"
> >                         memory-region;
> >                         sram;
> >                 }
> >         };
> >
> > A driver exists for the cluster rather than the individual cores
> > themselves so that operation mode and HW specific configurations
> > applicable to the cluster can be made.
> >
> > Because the driver exists at the cluster level and not the individual
> > core level, function rproc_get_by_phandle() fails to return the
> > remoteproc associated with the phandled it is called for.
> >
> > This patch enhances rproc_get_by_phandle() by looking for the cluster's
> > driver when the driver for the immediate remoteproc's parent is not
> > found.
> >
> > Reported-by: Ben Levinsky <ben.levinsky@xilinx.com>
> > Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> > Co-developed-by: Tarak Reddy <tarak.reddy@amd.com>
> > Signed-off-by: Tarak Reddy <tarak.reddy@amd.com>
> > Co-developed-by: Tanmay Shah <tanmay.shah@amd.com>
> > Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
> > ---
> >  drivers/remoteproc/remoteproc_core.c | 29 ++++++++++++++++++++++++++--
> >  1 file changed, 27 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
> > index 695cce218e8c..f276956f2c5c 100644
> > --- a/drivers/remoteproc/remoteproc_core.c
> > +++ b/drivers/remoteproc/remoteproc_core.c
> > @@ -33,6 +33,7 @@
> >  #include <linux/idr.h>
> >  #include <linux/elf.h>
> >  #include <linux/crc32.h>
> > +#include <linux/of_platform.h>
> >  #include <linux/of_reserved_mem.h>
> >  #include <linux/virtio_ids.h>
> >  #include <linux/virtio_ring.h>
> > @@ -2112,6 +2113,7 @@ EXPORT_SYMBOL(rproc_detach);
> >  struct rproc *rproc_get_by_phandle(phandle phandle)
> >  {
> >  	struct rproc *rproc = NULL, *r;
> > +	struct device_driver *driver;
> >  	struct device_node *np;
> >  
> >  	np = of_find_node_by_phandle(phandle);
> > @@ -2122,7 +2124,26 @@ struct rproc *rproc_get_by_phandle(phandle phandle)
> >  	list_for_each_entry_rcu(r, &rproc_list, node) {
> >  		if (r->dev.parent && device_match_of_node(r->dev.parent, np)) {
> >  			/* prevent underlying implementation from being removed */
> > -			if (!try_module_get(r->dev.parent->driver->owner)) {
> > +
> > +			/*
> > +			 * If the remoteproc's parent has a driver, the
> > +			 * remoteproc is not part of a cluster and we can use
> > +			 * that driver.
> > +			 */
> > +			driver = r->dev.parent->driver;
> > +
> > +			/*
> > +			 * If the remoteproc's parent does not have a driver,
> > +			 * look for the driver associated with the cluster.
> > +			 */
> > +			if (!driver) {
> > +				if (r->dev.parent->parent)
> > +					driver = r->dev.parent->parent->driver;
> > +				if (!driver)
> > +					break;
> > +			}
> > +
> > +			if (!try_module_get(driver->owner)) {
> >  				dev_err(&r->dev, "can't get owner\n");
> >  				break;
> >  			}
> > @@ -2533,7 +2554,11 @@ EXPORT_SYMBOL(rproc_free);
> >   */
> >  void rproc_put(struct rproc *rproc)
> >  {
> > -	module_put(rproc->dev.parent->driver->owner);
> > +	if (rproc->dev.parent->driver)
> > +		module_put(rproc->dev.parent->driver->owner);
> > +	else
> > +		module_put(rproc->dev.parent->parent->driver->owner);
> > +
> >  	put_device(&rproc->dev);
> >  }
> >  EXPORT_SYMBOL(rproc_put);
> >
> > base-commit: 99f59b148871dadb9104366e3d25b120a97f897b