Received-SPF: pass (google.com: domain of linux-kernel+bounces-57294-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <f49b85d2045fc6960088166374c73f79b551f6c2.camel@irl.hu>
Subject: Re: [PATCH] ASoC: tas2781: remove unused acpi_subysystem_id
From: Gergo Koteles <soyer@irl.hu>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Shenghao Ding <shenghao-ding@ti.com>, Kevin Lu <kevin-lu@ti.com>,
  Baojun Xu <baojun.xu@ti.com>, Jaroslav Kysela <perex@perex.cz>,
  Takashi Iwai <tiwai@suse.com>, Liam Girdwood <lgirdwood@gmail.com>,
  Mark Brown <broonie@kernel.org>, linux-sound@vger.kernel.org,
  linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
  stable@vger.kernel.org
Date: Thu, 08 Feb 2024 00:24:22 +0100
In-Reply-To: <2024020745-freight-slush-9ae7@gregkh>
References: 
	<df5c94396256e9573b772962182def52d20c50d4.1707250969.git.soyer@irl.hu>
	 <2024020745-freight-slush-9ae7@gregkh>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.3 (3.50.3-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

Hi Greg,

On Wed, 2024-02-07 at 10:02 +0000, Greg KH wrote:
> On Tue, Feb 06, 2024 at 09:25:50PM +0100, Gergo Koteles wrote:
> > The acpi_subysystem_id is only written and freed, not read, so
> > unnecessary.
> >=20
> > Fixes: ef3bcde75d06 ("ASoC: tas2781: Add tas2781 driver")
>=20
> What does this really "fix"?  It's just a cleanup.
>=20
> > CC: stable@vger.kernel.org
>=20
> Again, what bug is this fixing?
>=20
> Please read:
>     https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.ht=
ml
> about what should be tagged for stable kernels, which this patch series
> does not seem to fix.
>=20

Yes, you are right, this is not really a bug.
I took the scope of "oh, that's not good" too wide.
Sorry for the noise.

thanks,
Gergo