Received-SPF: pass (google.com: domain of linux-kernel+bounces-57315-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 7 Feb 2024 16:08:22 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: linux-mm@kvack.org, alexandru.elisei@arm.com,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/cma: Add sysfs file 'release_pages_success'
Message-Id: <20240207160822.c061cc98d6ffd2ab1ecac38a@linux-foundation.org>
In-Reply-To: <8d9f2950-6805-481f-a5e7-e5ea45128fb5@arm.com>
References: <20240206045731.472759-1-anshuman.khandual@arm.com>
	<20240206093857.d834af4f96d643c53e29e02d@linux-foundation.org>
	<8d9f2950-6805-481f-a5e7-e5ea45128fb5@arm.com>
Precedence: bulk
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 7 Feb 2024 10:04:31 +0530 Anshuman Khandual <anshuman.khandual@arm.com> wrote:

> > The changelog doesn't explain why Linux needs this feature.  The value
> > to our users.  Perhaps that info is buried in the link which is buried
> > below the ^---$, but as this is the most important part of a changelog,
> > it really should be spelled out here, completely and carefully please.
> 
> Does this look better ?
> 
> mm/cma: Add sysfs file 'release_pages_success'
> 
> This adds the following new sysfs file tracking the number of successfully
> released pages from a given CMA heap area. This file will be available via
> CONFIG_CMA_SYSFS and help in determining active CMA pages available on the
> CMA heap area. This adds a new 'nr_pages_released' (CONFIG_CMA_SYSFS) into
> 'struct cma' which gets updated during cma_release().
> 
> /sys/kernel/mm/cma/<cma-heap-area>/release_pages_success
> 
> After this change, an user will be able to find active CMA pages available
> in a given CMA heap area via the following method.
> 
> Active pages = alloc_pages_success - release_pages_success
> 
> That's valuable information for both software designers, and system admins
> as it allows them to tune the number of CMA pages available in the system.
> This increases user visibility for allocated CMA area and its utilization.

yup, thanks.  I added the patch with the above for a changelog.