Received: by 2002:a05:7412:2a8a:b0:fc:a2b0:25d7 with SMTP id u10csp685093rdh; Wed, 7 Feb 2024 17:45:32 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUO9YAhnff1D85dV0k4Dj1D1iJLQQ1ln2artOlRV2Dfe39qxg+I8QA/VGsi8/OxycWVhyApZFIz2dBvsf5rGzcLz1k69rSz1kIR2JDV4Q== X-Google-Smtp-Source: AGHT+IECpL3r3Ti+4HDY0kJtpKjiuOISqJEg7XEUYYc1uIxusYhcKPDqv3v4geUVYURni6HoYdlG X-Received: by 2002:a05:6a00:26f1:b0:6e0:4510:fe20 with SMTP id p49-20020a056a0026f100b006e04510fe20mr4367376pfw.7.1707356732415; Wed, 07 Feb 2024 17:45:32 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707356732; cv=pass; d=google.com; s=arc-20160816; b=h9zwsYU3f9/3TtTHEtBTE2p9xtwF5PyxTPe1IXDjfi8D7y0K14dGm7um4A/g/UJLUA WKDV1mjHOqSWain8S6lAbF4d1/Ag9OQcf8SGTmZV8OUrkZXKxUVIgduHgFEglOqV8up4 e0q/cHjZLKu2S/V0tGBT0VmuehkQpStorA8POyYVE7RnAbal/017GD0b2uq6q9ww/nhF 9F6LxU5G+thUZXVmaJ3AFKVQ65PrO5u9647TxiqpyAyqz5k0J9HWG/zusW+5nq1gKirF 1NH4XBvThCQDb2ProTDnINsjirTTIg4knKNRe43+c73sPaFfKCBTINITTDn1DE9+dKIG i0Mw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=e42C00KGFouqh1aRG0SK2zbLWuRh5t+GpF4bcStxwvM=; fh=pQG5CmxN8HYjb27x3Jl9mj0eFZy0LGUbesPRmycutIk=; b=mtZifcwDwndO1dYngb9TZri3O/mh3ZHzG57VMpcuUxEcmNq5+P6cb0Qhfz+sLXPYzr nQRcWaP9JuAU7PZXIwGtZhYrgmetKgVHozCGFC0YAGdKWMSNv6OWBfC5FyJP0350UTgA 7sdAejVb0+bFcxc1Uw8CCLaeHRa0SW7cHbFICcTa1R3dsD03ze6goLQzyKdnpCzGgwQy oevKWiQojk/ORvX8oUH0+rAnGTHzsD3aHzV4uOHFa207agaNXWdmgBO3Oc3GdKESAgS1 WCHdZuBpC5aolybx9+8kKWUfA8Fb9+2dyGxIpxliiPzHuERrw/PjjJuH212oCM/3bwOA isFw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=js2h7UGb; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-57377-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-57377-linux.lists.archive=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=2; AJvYcCW+fMEHtg3xbOwUNLUbb9dPebkhW64//DH7kuoSwPCf2KSVDuy8abl0AP+BH/0IjaZwsv+3CRQ6uhruH8mDZAHdelzBm9WdeGEqn/o6Vg== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id r9-20020a632b09000000b005cd89d9fae3si2833491pgr.634.2024.02.07.17.45.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 17:45:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-57377-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=js2h7UGb; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-57377-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-57377-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 1BDA4285C2D for ; Thu, 8 Feb 2024 01:45:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B394E1D698; Thu, 8 Feb 2024 01:45:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="js2h7UGb" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92D111CD33 for ; Thu, 8 Feb 2024 01:45:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707356724; cv=none; b=bNtWNPt0F0KzlQDUl4ePwxCUxF8QvdCQiwyUx+dQhp+0YUKIHGTucysS/51ba67CCKjzIiJ3vGsmCjRO2P1T3XX9NFlmCLK61YGAXVbNd4Oc6iV3rJPipF+zqTYEwrAUgYk3y627QGaMVUf/uv1wa5kCQg3umZ/XDCml4V1goT8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707356724; c=relaxed/simple; bh=JVBIf2Ulo88/HvjGqKnfEYos35jVYsOVzHizfZ2s6JM=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=YEbrE2F78QjFxAQ7R2EOYyx6KVk+P5X9666zDYrnCT6DymUaZNm+o8Sh47ZOH0hQ1qhp6qlDoz5de87YYybe/d96qb09qoIlXBnbrbXLjMaSWQ035HinZYBOvJwBXT7nw3rkrdpMpg2Cz6hEe2c3P76zSDt1mXfw6/GvH5AaDHE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=js2h7UGb; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id AFDC1C433F1; Thu, 8 Feb 2024 01:45:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1707356723; bh=JVBIf2Ulo88/HvjGqKnfEYos35jVYsOVzHizfZ2s6JM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=js2h7UGbeBdMJzWZ05C1L7C/0M9lDD8e7pB80Uw/k90ukxfj7k9VQfAbe5toOtE4W K2QWwXCC1cj3TAMjFTREiZ05n20OozY879NOOqUzIRuYho5CvX7h8ukG22LJUwTnPm Ebr5SguISzJinhC8suLU0B1qaV5wJf8x+69QTjbE= Date: Wed, 7 Feb 2024 17:45:22 -0800 From: Andrew Morton To: Charlie Jenkins Cc: Guenter Roeck , David Laight , Palmer Dabbelt , linux-kernel@vger.kernel.org, kernel test robot Subject: Re: [PATCH v6 0/2] lib: checksum: Fix issues with checksum tests Message-Id: <20240207174522.2d19729ec2e014d521335a04@linux-foundation.org> In-Reply-To: <20240207-fix_sparse_errors_checksum_tests-v6-0-4caa9629705b@rivosinc.com> References: <20240207-fix_sparse_errors_checksum_tests-v6-0-4caa9629705b@rivosinc.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 07 Feb 2024 16:22:49 -0800 Charlie Jenkins wrote: > The ip_fast_csum and csum_ipv6_magic tests did not have the data > types properly casted, and improperly misaligned data. Neither this nor the two patch's changelogs describe *why* these changes are needed. They merely assert that we need to do this. IOW, when fixing a bug please always describe the user-visible effects of that bug.