Received-SPF: pass (google.com: domain of linux-kernel+bounces-57381-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Wed, 7 Feb 2024 18:01:08 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Muchun Song <muchun.song@linux.dev>
Cc: Prakash Sangappa <prakash.sangappa@oracle.com>, linux-mm@kvack.org,
 linux-kernel@vger.kernel.org, mike.kravetz@oracle.com
Subject: Re: [PATCH v3] Hugetlb pages should not be reserved by shmat() if
 SHM_NORESERVE
Message-Id: <20240207180108.6a181d9fa5b404f78c0b4b22@linux-foundation.org>
In-Reply-To: <e59c8e4c-c416-4026-9ab9-ee55edafd4b3@linux.dev>
References: <1706040282-12388-1-git-send-email-prakash.sangappa@oracle.com>
	<e59c8e4c-c416-4026-9ab9-ee55edafd4b3@linux.dev>
Precedence: bulk
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 24 Jan 2024 15:03:15 +0800 Muchun Song <muchun.song@linux.dev> wrote:

> > Fix is to ensure that hugetlb pages are not reserved for SHM_HUGETLB shared
> > memory in the shmat() call.
> > Signed-off-by: Prakash Sangappa <prakash.sangappa@oracle.com>
> 
> BTW, it is better to add a Fixes tag to specify which commit
> that this commit aims to fix.

s/better/essential/

However this issue appears to pass the "been there forever" test, so
I'll send it to Linus as-is.