Received-SPF: pass (google.com: domain of linux-kernel+bounces-57434-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 8 Feb 2024 04:29:08 +0100
From: Johannes Weiner <hannes@cmpxchg.org>
To: Zhongkun He <hezhongkun.hzk@bytedance.com>
Cc: Matthew Wilcox <willy@infradead.org>, akpm@linux-foundation.org,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Vitaly Wool <vitaly.wool@konsulko.com>
Subject: Re: [External] Re: [PATCH] mm/z3fold: remove unneeded spinlock
Message-ID: <20240208032908.GB185687@cmpxchg.org>
References: <20240204125404.2112384-1-hezhongkun.hzk@bytedance.com>
 <Zb_bhO8Z_d7VUCdJ@casper.infradead.org>
 <CACSyD1MEM+KnNMimmbdSFXOsok9S=vN=DxzS9x90_6+pt5qjFA@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CACSyD1MEM+KnNMimmbdSFXOsok9S=vN=DxzS9x90_6+pt5qjFA@mail.gmail.com>

On Mon, Feb 05, 2024 at 09:08:05AM +0800, Zhongkun He wrote:
> On Mon, Feb 5, 2024 at 2:46 AM Matthew Wilcox <willy@infradead.org> wrote:
> >
> > On Sun, Feb 04, 2024 at 08:54:04PM +0800, Zhongkun He wrote:
> > > There is no need to use spinlock in this section, so
> > > remove it.
> >
> > I don't know this code at all, but the idiom is (relatively) common.
> > It waits until anybody _currently_ holding the lock has released it.
> >
> > That would, eg, make it safe to free the 'pool' memory.
> >
> > > -     spin_lock(&pool->lock);
> > > -     spin_unlock(&pool->lock);
> >
> 
> no,  please see the commit 'e774a7bc7f0adb'.
> 
>         spin_lock(&pool->lock);
> -       if (!list_empty(&page->lru))
> -               list_del_init(&page->lru);
>         spin_unlock(&pool->lock);
> 
> The original purpose of this lock was to protect  page->lru,
> which was removed now, so the spinlock is unnecessary.

But pool->lock protects other stuff too? This doesn't rule out that
there is some other ordering dependency on cycling the lock before
freeing the entry. The person who would know best is the maintainer of
this code, Vitaly. Let's CC him.