Received-SPF: pass (google.com: domain of linux-kernel+bounces-57457-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <180491ea-d4b4-4d70-a615-595492175efd@arm.com>
Date: Thu, 8 Feb 2024 09:31:11 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] dma-contiguous: remove debug code to removed
 CONFIG_CMA_DEBUG
Content-Language: en-US
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>,
 Andrew Morton <akpm@linux-foundation.org>, Christoph Hellwig <hch@lst.de>,
 Marek Szyprowski <m.szyprowski@samsung.com>,
 Robin Murphy <robin.murphy@arm.com>, iommu@lists.linux.dev
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240207143825.986-1-lukas.bulwahn@gmail.com>
From: Anshuman Khandual <anshuman.khandual@arm.com>
In-Reply-To: <20240207143825.986-1-lukas.bulwahn@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 2/7/24 20:08, Lukas Bulwahn wrote:
> Commit acc2f3e42d4a ("mm/cma: drop CONFIG_CMA_DEBUG") removes the config
> CMA_DEBUG and the debug code in cma.c, but misses debug code in
> kernel/dma/contiguous.c.
> 
> Remove this dead code from this removed config option.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> Andrew, please pick this minor clean-up patch of top of the commit above.
> 
>  kernel/dma/contiguous.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/kernel/dma/contiguous.c b/kernel/dma/contiguous.c
> index f005c66f378c..055da410ac71 100644
> --- a/kernel/dma/contiguous.c
> +++ b/kernel/dma/contiguous.c
> @@ -37,12 +37,6 @@
>  
>  #define pr_fmt(fmt) "cma: " fmt
>  
> -#ifdef CONFIG_CMA_DEBUG
> -#ifndef DEBUG
> -#  define DEBUG
> -#endif
> -#endif
> -
>  #include <asm/page.h>
>  
>  #include <linux/memblock.h>

Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>