Received-SPF: pass (google.com: domain of linux-kernel+bounces-57487-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 8 Feb 2024 11:25:56 +0530
From: "Gautham R. Shenoy" <gautham.shenoy@amd.com>
To: Perry Yuan <perry.yuan@amd.com>
Cc: rafael.j.wysocki@intel.com, Mario.Limonciello@amd.com,
	viresh.kumar@linaro.org, Ray.Huang@amd.com, Borislav.Petkov@amd.com,
	Alexander.Deucher@amd.com, Xinmei.Huang@amd.com,
	Xiaojian.Du@amd.com, Li.Meng@amd.com, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/6] ACPI: CPPC: enable AMD CPPC V2 support for family
 17h processors
Message-ID: <ZcRs7Ki8dhxCfCM9@BLR-5CG11610CF.amd.com>
References: <cover.1707363758.git.perry.yuan@amd.com>
 <f6ace4124c45e523e984b4eeab3760b95a70b72d.1707363758.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f6ace4124c45e523e984b4eeab3760b95a70b72d.1707363758.git.perry.yuan@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?PvRUylbwUUIZMVx8kR0coUk6Z6E51zeIp1rSbQnwast5emd/gOYF8aSS/nbi?=
 =?us-ascii?Q?GfyCTY2AnMw0ZEJYYuvkartkyYr9GOXnoNl7s+qrbhuEzNdpQXxchWRZNkop?=
 =?us-ascii?Q?jljTl1gv5Xs5gh2i/uQuOje/+J8o57f/o6YVXQrR9Ex1tVGdtuYRBV2hx3mE?=
 =?us-ascii?Q?5lsYsImfASXPgDRxF87aFipvr+bz9oVo/lDz8GfYy3LwA/ybr2xOsr45zmTr?=
 =?us-ascii?Q?NvR/iWq0L3+80CZGnqVfcmBxxuanC8X6dUc1Lfl0pThfZhuLiP0Gzqa5OMJg?=
 =?us-ascii?Q?zYsEHd2AbO8J/2AIPmU8WFLuxE8Q5nv4IHAuoIdSxIQCjLyq9OUM9PRjEpqO?=
 =?us-ascii?Q?uYLteMW4lxWY6a8JrkX3tZKQYlLF105xrlSZ57Wq9YTOXtEFpBAlnsnpE+wZ?=
 =?us-ascii?Q?dhpo3+Njp+/I60QEmveJwwnFpJUtwMfvdoMIPYxPQwVg/D8cqukCxgWKmBZB?=
 =?us-ascii?Q?fbE5AL02nc6rnKkaNb8Le7779a5saWO17jCr9mXQVEWhVUqwoT9nbPi/0fxj?=
 =?us-ascii?Q?+3DIPyTeek1Tl9DRtpwfzrkocb8yeDHgpYugC9pshN/Uq/MPolweM/ImSp0Y?=
 =?us-ascii?Q?9hrz+FCSi5wdUHesteEUE3GUrD/3/AVw7lHEg/CARJlQc2z9CdI/Si78d9GZ?=
 =?us-ascii?Q?S5vO0jwbEeguo5XBu+6AAfPPi+nPdjxyXbLbOPN6zRNJjjUP4iQkEyDuy8Z4?=
 =?us-ascii?Q?MwRI4E/6Z1vitYT/Y7WNiqU7mD2IQp6rGpotAy+7SrvjZ71erYesOsIzLV9s?=
 =?us-ascii?Q?ngRtrgEs+UkSpt1f+BzlxJYEZkxtxlXVCjqs1S8wjkJhe0kgZOfuqVr6y7Bn?=
 =?us-ascii?Q?OovjsTkaqnh8GZcWHFpZ+h+KdrAgDoL/WKoQIxRJWJgyx1z6aW2JHaiT+UzN?=
 =?us-ascii?Q?vKVg2dPa32yARYYHx3l2pv20ZnfHbO6aB896UodqQ5mMRUesKethIDQrMUJi?=
 =?us-ascii?Q?3AD7+mC6v1nRqjNn9XYDHul4nCu3/qQZtK5RsSzkR6RB4/5s+Aj8XZxQWY2j?=
 =?us-ascii?Q?nfZO6zK6dfq+H8MUNJyFnirV4b0qCuKTnKfPOLgblE+EeudK1OYAQrV9UDMp?=
 =?us-ascii?Q?j6LqQlqJ/AhpyAJK3t4EM0ADqaYuysipm4MykYbFd3PeCexKB6HvqLNZXei5?=
 =?us-ascii?Q?y+Z30LGkTCWQ+XTCs9GURuEGmP8dBbPWvwS8yZogF29Nu2L+sVuNwdT22TOo?=
 =?us-ascii?Q?d5c3bQuwGgACHDrojKMpAKGdcJBzf2Zu0vW2+OG0JdDqPr2Gr7VRVmKg4RbD?=
 =?us-ascii?Q?3BdpUPyDa1q/hErtDRX4d4xLjpHAYNSpO+LoDiv6z9IbFq18TtO8EuQpaZZx?=
 =?us-ascii?Q?wCIPgnOKA9acb5kTb7T0BCvOM346/IU37u/RmOBnPsYVJEzO343yV2iLco5j?=
 =?us-ascii?Q?UGx4yrDqbh8SS8lfdDASdYA+HTpTwk6JmDhECDj/qSDRtmxICWcUIrqSy/9Z?=
 =?us-ascii?Q?IsdG/gdQDsnTKZJYE7sLCZlPkVgZjFgON4oBXAc3MLVHU5BfvQ61NPGVE0Sz?=
 =?us-ascii?Q?0QZcxB/DHIt5LHZEnkTq9A6I2B4Zfh+sTYkTwlErIzaeSVA/s+rSuhDmO3Qe?=
 =?us-ascii?Q?7ZrvSM0rF3dXDA8oXSg0l32k5oGPcM7T8Fm7tbgZ?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 73bddf8f-968d-4b4c-e40e-08dc286aa22d
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB8252.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2024 05:56:03.5850
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jUQrYoBxQ5zQKhhZPr5jrCnIFKR+V3XSx0ImuYtJnV5+oZbzMyBL5/GEWkOBZcffGtgKm96Geif4Mub07K5QaQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7425

Hello Perry,

On Thu, Feb 08, 2024 at 11:46:28AM +0800, Perry Yuan wrote:
> As there are some AMD processors which only support CPPC V2 firmware and
> BIOS implementation, the amd_pstate driver will be failed to load when
> system booting with below kernel warning message:
> 
> [    0.477523] amd_pstate: the _CPC object is not present in SBIOS or ACPI disabled
> 
> To make the amd_pstate driver can be loaded on those TR40 processors, it
> needs to match x86_model from 0x30 to 0x7F for family 17H.
> With the change, the system can load amd_pstate driver as expected.
> 
> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> Reported-by: Gino Badouri <badouri.g@gmail.com>
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218171
> Fixes: fbd74d1689 ("ACPI: CPPC: Fix enabling CPPC on AMD systems with shared memory")
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>
> ---
>  arch/x86/kernel/acpi/cppc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/acpi/cppc.c b/arch/x86/kernel/acpi/cppc.c
> index 8d8752b44f11..ff8f25faca3d 100644
> --- a/arch/x86/kernel/acpi/cppc.c
> +++ b/arch/x86/kernel/acpi/cppc.c
> @@ -20,7 +20,7 @@ bool cpc_supported_by_cpu(void)
>  		    (boot_cpu_data.x86_model >= 0x20 && boot_cpu_data.x86_model <= 0x2f)))
>  			return true;
>  		else if (boot_cpu_data.x86 == 0x17 &&
> -			 boot_cpu_data.x86_model >= 0x70 && boot_cpu_data.x86_model <= 0x7f)
> +			 boot_cpu_data.x86_model >= 0x30 && boot_cpu_data.x86_model <= 0x7f)

This looks ok to me.
Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>

--
Thanks and Regards
gautham.