Received-SPF: pass (google.com: domain of linux-kernel+bounces-57489-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <033de6e2-4ca4-46bc-a0a7-e9921ed15977@phytec.de>
Date: Thu, 8 Feb 2024 06:57:54 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] arm64: dts: ti: am62-phyboard-lyra: Add overlay to enable
 a GPIO fan
To: Andrew Davis <afd@ti.com>, Nathan Morrisson <nmorrisson@phytec.com>,
	<nm@ti.com>, <vigneshr@ti.com>, <kristo@kernel.org>, <robh+dt@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>
CC: <linux-arm-kernel@lists.infradead.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <upstream@lists.phytec.de>
References: <20240207172820.478332-1-nmorrisson@phytec.com>
 <acd3c7f2-930d-46c0-9924-9775e9795fca@ti.com>
Content-Language: en-US
From: Wadim Egorov <w.egorov@phytec.de>
In-Reply-To: <acd3c7f2-930d-46c0-9924-9775e9795fca@ti.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit

Hi Andrew,

Am 07.02.24 um 23:20 schrieb Andrew Davis:
> On 2/7/24 11:28 AM, Nathan Morrisson wrote:
>> The phyBOARD-Lyra has a GPIO fan header. This overlay enables the fan
>> header and sets the fan to turn on at 65C.
>>
>> Signed-off-by: Nathan Morrisson <nmorrisson@phytec.com>
>> ---
>>   arch/arm64/boot/dts/ti/Makefile               |  1 +
>>   .../ti/k3-am62-phyboard-lyra-gpio-fan.dtso    | 51 +++++++++++++++++++
>>   2 files changed, 52 insertions(+)
>>   create mode 100644 
>> arch/arm64/boot/dts/ti/k3-am62-phyboard-lyra-gpio-fan.dtso
>>
>> diff --git a/arch/arm64/boot/dts/ti/Makefile 
>> b/arch/arm64/boot/dts/ti/Makefile
>> index 52c1dc910308..379fb4f31a1f 100644
>> --- a/arch/arm64/boot/dts/ti/Makefile
>> +++ b/arch/arm64/boot/dts/ti/Makefile
>> @@ -23,6 +23,7 @@ dtb-$(CONFIG_ARCH_K3) += k3-am625-verdin-wifi-dev.dtb
>>   dtb-$(CONFIG_ARCH_K3) += k3-am625-verdin-wifi-mallow.dtb
>>   dtb-$(CONFIG_ARCH_K3) += k3-am625-verdin-wifi-yavia.dtb
>>   dtb-$(CONFIG_ARCH_K3) += k3-am62-lp-sk.dtb
>> +dtb-$(CONFIG_ARCH_K3) += k3-am62-phyboard-lyra-gpio-fan.dtbo
>
> Why not call this k3-am625-phyboard-lyra-gpio-fan.dtbo to match the
> name of the base board it applies to better?

We are able to reuse this overlay for different SoMs (am625 and am62a) 
that are using the same carrier board (lyra).

Regards,
Wadim


>
> Andrew
>
>>     # Boards with AM62Ax SoC
>>   dtb-$(CONFIG_ARCH_K3) += k3-am62a7-sk.dtb
>> diff --git 
>> a/arch/arm64/boot/dts/ti/k3-am62-phyboard-lyra-gpio-fan.dtso 
>> b/arch/arm64/boot/dts/ti/k3-am62-phyboard-lyra-gpio-fan.dtso
>> new file mode 100644
>> index 000000000000..9c05748bdd9d
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/ti/k3-am62-phyboard-lyra-gpio-fan.dtso
>> @@ -0,0 +1,51 @@
>> +// SPDX-License-Identifier: GPL-2.0-only OR MIT
>> +/*
>> + * Copyright (C) 2024 PHYTEC America LLC
>> + * Author: Garrett Giordano <ggiordano@phytec.com>
>> + */
>> +
>> +/dts-v1/;
>> +/plugin/;
>> +
>> +#include <dt-bindings/gpio/gpio.h>
>> +#include <dt-bindings/thermal/thermal.h>
>> +#include "k3-pinctrl.h"
>> +
>> +&{/} {
>> +    fan: gpio-fan {
>> +        compatible = "gpio-fan";
>> +        gpio-fan,speed-map = <0 0 8600 1>;
>> +        gpios = <&main_gpio0 40 GPIO_ACTIVE_LOW>;
>> +        #cooling-cells = <2>;
>> +        pinctrl-names = "default";
>> +        pinctrl-0 = <&gpio_fan_pins_default>;
>> +        status = "okay";
>> +    };
>> +};
>> +
>> +&main_pmx0 {
>> +    gpio_fan_pins_default: gpio-fan-default-pins {
>> +        pinctrl-single,pins = <
>> +            AM62X_IOPAD(0x0a4, PIN_OUTPUT, 7) /* (M22) 
>> GPMC0_DIR.GPIO0_40 */
>> +        >;
>> +    };
>> +};
>> +
>> +&thermal_zones {
>> +    main0_thermal: main0-thermal {
>> +        trips {
>> +            main0_thermal_trip0: main0-thermal-trip {
>> +                temperature = <65000>;  /* millicelsius */
>> +                hysteresis = <2000>;    /* millicelsius */
>> +                type = "active";
>> +            };
>> +        };
>> +
>> +        cooling-maps {
>> +            map0 {
>> +                trip = <&main0_thermal_trip0>;
>> +                cooling-device = <&fan THERMAL_NO_LIMIT 
>> THERMAL_NO_LIMIT>;
>> +            };
>> +        };
>> +    };
>> +};
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel