Received-SPF: pass (google.com: domain of linux-kernel+bounces-57504-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "ankita@nvidia.com" <ankita@nvidia.com>, "jgg@nvidia.com"
	<jgg@nvidia.com>, "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
	"yishaih@nvidia.com" <yishaih@nvidia.com>, "mst@redhat.com" <mst@redhat.com>,
	"shameerali.kolothum.thodi@huawei.com"
	<shameerali.kolothum.thodi@huawei.com>, "clg@redhat.com" <clg@redhat.com>,
	"oleksandr@natalenko.name" <oleksandr@natalenko.name>, "K V P, Satyanarayana"
	<satyanarayana.k.v.p@intel.com>, "eric.auger@redhat.com"
	<eric.auger@redhat.com>, "brett.creeley@amd.com" <brett.creeley@amd.com>,
	"horms@kernel.org" <horms@kernel.org>, "rrameshbabu@nvidia.com"
	<rrameshbabu@nvidia.com>
CC: "aniketa@nvidia.com" <aniketa@nvidia.com>, "cjia@nvidia.com"
	<cjia@nvidia.com>, "kwankhede@nvidia.com" <kwankhede@nvidia.com>,
	"targupta@nvidia.com" <targupta@nvidia.com>, "vsethi@nvidia.com"
	<vsethi@nvidia.com>, "Currid, Andy" <acurrid@nvidia.com>,
	"apopple@nvidia.com" <apopple@nvidia.com>, "jhubbard@nvidia.com"
	<jhubbard@nvidia.com>, "danw@nvidia.com" <danw@nvidia.com>,
	"anuaggarwal@nvidia.com" <anuaggarwal@nvidia.com>, "mochs@nvidia.com"
	<mochs@nvidia.com>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>
Subject: RE: [PATCH v17 2/3] vfio/pci: rename and export range_intesect_range
Thread-Topic: [PATCH v17 2/3] vfio/pci: rename and export range_intesect_range
Thread-Index: AQHaWIdb3fVc1Z5CCE2afKbt+x6ZX7D/+wYA
Date: Thu, 8 Feb 2024 06:19:11 +0000
Message-ID: <BN9PR11MB5276BB50143B801E8F02D9958C442@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20240205230123.18981-1-ankita@nvidia.com>
 <20240205230123.18981-3-ankita@nvidia.com>
In-Reply-To: <20240205230123.18981-3-ankita@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?aAa+dzPFKf8of+UaMQ1fMYCHa+/SiCb24+8gam9c/XRyhy112J1lL/4vawd/?=
 =?us-ascii?Q?yXWz7+vVKYz4skMBeHfnd0L0kHk54S7ccW45je0u9zYVhM3BiXENwET1Qw8v?=
 =?us-ascii?Q?tOIWcC14L4GqUSRig5DgZzmnx6OsMltR7PWzSt9BKDUtXWLop6kBW3ST5xUp?=
 =?us-ascii?Q?7uvOQ+046GqaDKEZm0zQ1MTJZoHIONTLlIpu66tOyWnekf4b8SWxWomLWY3k?=
 =?us-ascii?Q?K62sibaYzsXd+0wHCrnbvSuO4rWUfbPFNw5xD8Nstz/c2I1qGMXeW33zWvKD?=
 =?us-ascii?Q?U3hUZfv5HcV07jNVhhkFdDPRxctcBQ5h6NYCDRB5OVjpxC3tQL2IlQErz01f?=
 =?us-ascii?Q?cu2qNVFaAnL4uqoyMxld6TCMGHvCObAKI6buvqfmvsIscX2nO55zxkrWrO5T?=
 =?us-ascii?Q?ykbQnrbTu6YoGJOdt3J0YhllA8oZT2ZH6T8amW+p7bCOHFKIxNFOgFoGNjTg?=
 =?us-ascii?Q?TN4FCMiAkk3tOjXO/V64EbbayHMJePT6QicXY2yFYJhWsZWsXWIMbnEG6cG5?=
 =?us-ascii?Q?ABy60ZBjiFRfLjJmpDqkpL/mjG9fHlzVGjg62FiXjitFWAh4QAs0hKJ6GMhp?=
 =?us-ascii?Q?d7h7Z/RUireO8EWcz0BtKwvYq+J/rFW9l9Xrt6up/cI/OumjCOvOjgq3ygrr?=
 =?us-ascii?Q?bVAiFJfekRC1HJom9MIh9i69tQSkjtOzBxyiXh5RP/ILZS0quAkkFSBbhDtx?=
 =?us-ascii?Q?WiApTCpH+cwkWZUFVGpjACZRokvCckfJUtKb6ZTtztyIPxjM+tWK6wltIyTg?=
 =?us-ascii?Q?W37dSGd71Y6MgI5wob3tfquaAkDuyz/xiQZyQWDDiww0iNPSogs4u6Pkmxd7?=
 =?us-ascii?Q?QrWGa6wow0h1RTgTNX2ypfoHbCT1MBd2jIlOjj7arev0VQgHDF1B3kR6r7vU?=
 =?us-ascii?Q?/1retgb0YLleLVeTbr19BDV4aPXSNZLe7xkK1bGKzraU4a1rpcB/nRiYXA6K?=
 =?us-ascii?Q?pNQ+FNru0oxKANNLL/GgCjVFyBHaKEsJI04SyBuV6egvjzC+y1LIgTFizBY7?=
 =?us-ascii?Q?SI4pqSQCmhA7BR28W3H+cSZ3T/27GB2JcFqR653xQeEksTVr6UAviYNzODnY?=
 =?us-ascii?Q?DqnBKbJV4Qu95MQtkY35/TfNJZWzw9pZZm53KhhMRWqUyK45GTnD//WQ5WoB?=
 =?us-ascii?Q?BdSVUf7KDxWC7akFXl4Rv5oRWNIGDkRCZXOjuCG+bVr3O6iSQhmCwms3esqy?=
 =?us-ascii?Q?ab/aTrPcyGzoe94IPL1OhHMV1yscMoiay9dRrVEG7jO8yx0KY4RNe4J5fG9y?=
 =?us-ascii?Q?5sXvxT0soj6SaQXhIYLuKFc5GJ9ycvXmAnC5C7zyxjJfZmVCbuHC22DT5kWQ?=
 =?us-ascii?Q?CAYVTNsbNZz7yEBZ9cVwCAfCAQatFcrCKTXJFjZrVJgG8Gbf+luVM6bg20Cl?=
 =?us-ascii?Q?ni/+SlvKT9sWe65UPMhQnSyIgHCA30E1qPlWZMRBHuEcfPYq8HZTJjprv5EQ?=
 =?us-ascii?Q?iFOLinn2dCUQx88d6VbajaPFAPO1Gys+DmXyqnYrq8DQPhTyRl4tR2Z3riNT?=
 =?us-ascii?Q?J+nhwfmPqSkIWxgb9lJn2mS32EKtLMXUaxikLVrN0pcksRR2I88iTj3de7pw?=
 =?us-ascii?Q?a2jABpz+PqKQfiCL9MuBYlMKVCGu32scwf+G7P4E?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 78b3457a-6903-4bde-5b76-08dc286ddd8a
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2024 06:19:11.2677
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: AhQ2wIKoe9K3F+FtHP8TPKdtGvNze2LheQyjiHMtr3YECxXTSlIxXvJ/Tv6y5amPqWNh2WeEC2+tArfESerf9Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6733
X-OriginatorOrg: intel.com

> From: ankita@nvidia.com <ankita@nvidia.com>
> Sent: Tuesday, February 6, 2024 7:01 AM
>=20
> From: Ankit Agrawal <ankita@nvidia.com>
>=20
> range_intesect_range determines an overlap between two ranges. If an

s/intesect/intersect/

> overlap, the helper function returns the overlapping offset and size.
>=20
> The VFIO PCI variant driver emulates the PCI config space BAR offset
> registers. These offset may be accessed for read/write with a variety
> of lengths including sub-word sizes from sub-word offsets. The driver
> makes use of this helper function to read/write the targeted part of
> the emulated register.
>=20
> Make this a vfio_pci_core function, rename and export as GPL. Also
> update references in virtio driver.
>=20
> Signed-off-by: Ankit Agrawal <ankita@nvidia.com>
> ---
>  drivers/vfio/pci/vfio_pci_config.c | 45 +++++++++++++++++++
>  drivers/vfio/pci/virtio/main.c     | 72 +++++++++++-------------------
>  include/linux/vfio_pci_core.h      |  5 +++
>  3 files changed, 76 insertions(+), 46 deletions(-)
>=20
> diff --git a/drivers/vfio/pci/vfio_pci_config.c
> b/drivers/vfio/pci/vfio_pci_config.c
> index 672a1804af6a..4fc3c605af13 100644
> --- a/drivers/vfio/pci/vfio_pci_config.c
> +++ b/drivers/vfio/pci/vfio_pci_config.c
> @@ -1966,3 +1966,48 @@ ssize_t vfio_pci_config_rw(struct
> vfio_pci_core_device *vdev, char __user *buf,
>=20
>  	return done;
>  }
> +
> +/**
> + * vfio_pci_core_range_intersect_range() - Determine overlap between a
> buffer
> + *					   and register offset ranges.
> + * @range1_start:    start offset of the buffer
> + * @count1:	     number of buffer bytes.
> + * @range2_start:    start register offset
> + * @count2:	     number of bytes of register
> + * @start_offset:    start offset of overlap start in the buffer
> + * @intersect_count: number of overlapping bytes
> + * @register_offset: start offset of overlap start in register
> + *
> + * The function determines an overlap between a register and a buffer.
> + * range1 represents the buffer and range2 represents register.
> + *
> + * Returns: true if there is overlap, false if not.
> + * The overlap start and range is returned through function args.
> + */
> +bool vfio_pci_core_range_intersect_range(loff_t range1_start, size_t cou=
nt1,
> +					 loff_t range2_start, size_t count2,
> +					 loff_t *start_offset,
> +					 size_t *intersect_count,
> +					 size_t *register_offset)

based on description it's probably clearer to rename:

range1_start -> buf_start
count1 -> buf_cnt
range2_start -> reg_start
count2 -> reg_cnt
start_offset -> buf_offset

but not big deal, so:

Reviewed-by: Kevin Tian <kevin.tian@intel.com>