Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp78212rdb; Wed, 7 Feb 2024 22:21:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IFDLjMTJMsoYTbuS5eJUg9sDSCD9E4z+87l5u4C6mchFORcHFXGGnAgvQRt4oblF5zMXGs+ X-Received: by 2002:a05:620a:6007:b0:785:a9c0:bc41 with SMTP id dw7-20020a05620a600700b00785a9c0bc41mr296900qkb.57.1707373295352; Wed, 07 Feb 2024 22:21:35 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707373295; cv=pass; d=google.com; s=arc-20160816; b=KWd8t2y/9zrsppfjb6+Hr2thBI6E5kgpT3thOiahez/xQHbWN2nyeXTa8dqutT49FJ VOAS+soQwWm+GOrt7NmS4/hIrTYAZYLKY203S1GsXCF5J5a0E5Nc9ILkAjj8sRC2ttyg OMJ6W6mLH5k0kRDY3Qn4yaoSHgVOURXfrtNXR2AZAiTTN7nyXofza0+QcdtV5Qo4Xw/3 XRcZyhTi9Yx/sIzsbPpInPMYFfhhdZO/SuJcXpXMFAXnFLQ/mtyXMqlewSloLo9WUGSh MWdSaZGDcPnR5BsDun2ciYBCmq2qfJeJNEx3ZiczjrVExSbhi5nQgcdgsS+wvs50niuf 4QPA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=5JRxrmAtTR5bS9y6pVFv8pI49A9aY4dC1xtw8EYFYb8=; fh=HNcgWN8DEteCMYebO20ymXJe2XruKHQMz7sIk+2Tr6M=; b=lIv1cxq2v4LcmzARmYqMTv4/Q6cKcZhaTHbifyI28Ax45v5pPBTfh6r3RaTmDRubfs NTxyE70p0q458L0DepYRlhI5vGcBuCLkPST/ohUW107ePv8P/bpN6aWqkO7PKjSCgkxd dAkjyLAQf1jO5kKzlJH/L8qbT0BjuqZalyOlmChIB3nygUQiePef90kXsivB07Pt7qnk C80fTnz6IC0LZxjcwqUdBs9nzjHUzT+YqrcH2NY71G4BNMu8UOMnbYBSEuh08auyViti jPSn1dagV7Ni5+voNvn6QkQpV9smup+08YDBBE4wCnYCOTIYQ/86cwCAZ///eBkOSvYK rCUQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kOuzsSbB; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-57509-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-57509-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCUIuE7hetCdCG5qHokVMa12+UXvnN64/zTPNVErxzjRaV2apaWtvFlAIMC7RHwVGo/pkdHBxjeQtyS34r1UIj/RJojchMMkV4Mz1kgBuw== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id az35-20020a05620a172300b007858abfed78si3069988qkb.18.2024.02.07.22.21.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 22:21:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-57509-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kOuzsSbB; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-57509-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-57509-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 200751C21D44 for ; Thu, 8 Feb 2024 06:21:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 459CE67E7C; Thu, 8 Feb 2024 06:21:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kOuzsSbB" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6616467E7B; Thu, 8 Feb 2024 06:21:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707373283; cv=none; b=XGdiqL8GjrKziexXeoL4VksDSXPibPwdVffppOWuDBDwldRwdWbsBtJAdcN7Eopc2ErDzAfyFq0XRgzqYFXRe6R/svTGb07i8Gj9oHoldQnK2bqRnljsAF2bjRTt2AFgUXkG0ls3cltqLqyPoyOexj058uoqYRLhY7bcXx6P/ME= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707373283; c=relaxed/simple; bh=lD1lrtMMdOBpkeLYHTDECguSxgees/c78w0lL7yv0bw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BYE7gZf77QNXTKPvJtntoy9edjDckkMy2amlti7qCoPmG2IoyKDiiX8W2ub2onSBQN7wkoXZqJidNJ0EDkNDmtdON9D+wZf47cAIXrx2wYWXjfPmrZaqPfVCR/b9VOdzQt9v5mLHserrK/WQPjJdrXxJjYG3BNO3rcSajOaCBes= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kOuzsSbB; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9FA67C433C7; Thu, 8 Feb 2024 06:21:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707373282; bh=lD1lrtMMdOBpkeLYHTDECguSxgees/c78w0lL7yv0bw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kOuzsSbB27uwSEFp6QnBBwF4c8wSiOnHMBpoT0jJuV3IEfQ/f661CpCyRQBuvLibE lLQXgNR3XCQOOP5nvA2vnYrZmZkM/dZXQxbM9FSzlFF4YpKjZv+hycd+20Elp8ywEL LAv0lEURquSyS6AsBFqOIDxwSjBdh4LEyqj78PHMjfRFx1Z2x+WKh2zG2BJ8sNyFaF HujNOdc0xlfRqZUvzM5o9jvnfWteYJRjhw62WISYKo869NMnlPw7V7xJ1+fXv/PF/u pHUOw3YaYaqgO8HS3ztmkMy9JMAmPt1+mxKkvDu4Ht04n+bkQbqIzXeGeuiFUFesQd NG/ZDh6p/DJXg== Date: Thu, 8 Feb 2024 08:20:57 +0200 From: Mike Rapoport To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Matthew Wilcox , Ryan Roberts , Russell King , Catalin Marinas , Will Deacon , Dinh Nguyen , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Aneesh Kumar K.V" , "Naveen N. Rao" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , "David S. Miller" , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org Subject: Re: [PATCH v3 10/15] powerpc/mm: use pte_next_pfn() in set_ptes() Message-ID: References: <20240129124649.189745-1-david@redhat.com> <20240129124649.189745-11-david@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240129124649.189745-11-david@redhat.com> On Mon, Jan 29, 2024 at 01:46:44PM +0100, David Hildenbrand wrote: > Let's use our handy new helper. Note that the implementation is slightly > different, but shouldn't really make a difference in practice. > > Reviewed-by: Christophe Leroy > Signed-off-by: David Hildenbrand Reviewed-by: Mike Rapoport (IBM) > --- > arch/powerpc/mm/pgtable.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/arch/powerpc/mm/pgtable.c b/arch/powerpc/mm/pgtable.c > index a04ae4449a02..549a440ed7f6 100644 > --- a/arch/powerpc/mm/pgtable.c > +++ b/arch/powerpc/mm/pgtable.c > @@ -220,10 +220,7 @@ void set_ptes(struct mm_struct *mm, unsigned long addr, pte_t *ptep, > break; > ptep++; > addr += PAGE_SIZE; > - /* > - * increment the pfn. > - */ > - pte = pfn_pte(pte_pfn(pte) + 1, pte_pgprot((pte))); > + pte = pte_next_pfn(pte); > } > } > > -- > 2.43.0 > > -- Sincerely yours, Mike.