Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp81099rdb; Wed, 7 Feb 2024 22:30:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IEdPSMeGVKIPm1NoPbsuhaJC5WY1k37bQtFe8CioPlnivIfAj9hMRm3Fo7IJjDbymOyVJiO X-Received: by 2002:a9d:7dce:0:b0:6e2:c029:ad1a with SMTP id k14-20020a9d7dce000000b006e2c029ad1amr1347652otn.31.1707373853753; Wed, 07 Feb 2024 22:30:53 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707373853; cv=pass; d=google.com; s=arc-20160816; b=osZyXPAFV8wBdiwhrhEB04ZgGJCWbv9IyF9PoUeENdfogPzb8QHbJVWWp7AmgFdQsi Dpm1ublBcDBh/fE+fosEvVz9gM3p+Aa6+VcM6mV5QaWYsQjuSBK72mqPF4KVtaeEL87B hV2EQfAugAjPmShIfCSL3FK+XWUGvaVWnq5AfMJ2CHd5xiHWPjSW0hTVlos8cfogo2/2 rHmpn7ZeB+56NE7XTsQpbL0wiydnF1hYqWaBGJK/4dP8UrgxlxTv3oSe+wnmw/5LSfg0 RW/5uNz6FyKKYNtvJENU7OmPFVOEOrV09ZPKTytwtejGdDlM7f8LbWOJ2lkxgzaEqnxw dIOw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=sAB3TJNJOJZ34vmKrSA1LdxGzcf1TUHQ+PjOH50ktWw=; fh=1nijbGZYO/6pZLuHhYGaCp4GA3K6pGmmpYGMld8NfyA=; b=LP70AdQIeL+/DSJlIYz0c4KEwU7mep91zycEGDUfcXkmND15lQC0rdkc61H4WNfb3g KG80kgshdjk5inqN5fAPZKVmj4hULC5FIb8cyxwmp3FvHQedMEhL5W1FamwKGRyG3ak2 G4vjnumkpsRQFeg7J+kpeFKw6P90I6SN9xhM3ZhRMg+xn+U3SlGFqlmRzShZuAzYdz4a UE5N9hxtZvgFtpQ7I6gC4dZ8CS4f5gFsto38hNLQ8cjbb0T7A+F858cd7TnBGui+tPtp 2YXZvO/EsUJZNYYVjEzIgWg+gNSuXQ1P0D8AC7gStBByr4NOXAu7UXusbJgaOeFyqqXV gA4A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kOdTKonu; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-57522-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-57522-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCUNkUeNXSZAIhcGUJIHhUCYjFxQC/gV9/9/+pvV1vdyjx+Slab9xHDgtr2OAJB4iyC/rlYEeqpozFMrAwLtDR+83cwP+O2uGFWpLzheTg== Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id y65-20020a638a44000000b005dbdc98c15csi3259385pgd.709.2024.02.07.22.30.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 22:30:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-57522-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kOdTKonu; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-57522-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-57522-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 4C7D6B2186D for ; Thu, 8 Feb 2024 06:28:52 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0AC6567C73; Thu, 8 Feb 2024 06:27:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kOdTKonu" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BFFE67E6D; Thu, 8 Feb 2024 06:27:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707373670; cv=none; b=jSwUVEh2Ms6exM0wyfiVS90cl6P2KD+AtPJcc3OyUq5rPol2tvsdZtCZTSruWcQ6JtcAH+Odybr7HKPdWS94MfxINzIm9n7mh44saiuqmtBEZU2VKH3eWSYwOzasLSaI78FjvFgQnW8UGQozqOI77h0Qh1jf7jQeNz0JwPrjoz0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707373670; c=relaxed/simple; bh=wxaBvjOQruR4Ppe5iBXVeEd+wF2Ez98jfGSuez99hUI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Y97S4/GTdI9O/oIF7I6BdCcqn+ceDEg17J/c5cHoki1ccmU8Nup2YVmxuNIN7dOqfZCGP0k3LNGillBV1Hn7CKg3lEL5J39/aEE951DVQEvRIvanDd5KWAKNJDjperBcmH7sXQqLAdXBj052zDPMo1tm/SUlZHKcx8hFl/7Xv/E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kOdTKonu; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F0D4C433C7; Thu, 8 Feb 2024 06:27:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707373669; bh=wxaBvjOQruR4Ppe5iBXVeEd+wF2Ez98jfGSuez99hUI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kOdTKonuPOHT47MMueyUa62BOnNiiM/wNlezDtex/q6A6C+C0/4I75w1hs6HgvTcM 6hzU/xNlN2o7mllZJQrfNN8OS6yllsdwkypMwhdT9Zppi/oCLVm5oi0rjh8531W++l VyhzaLbe16SPL0h9xcRPSV+cCkOkyBpKxf4y5KkH108vuZcpzPDikPbUG6HlcbyEC6 jTwJS9vdlSE+DGYuaJ63tvvk0g/PUUXVgtbv8Zylz7Hox9kBt886iEEM3kege/8EOf NJ+pl0uRULV4iQ598Nv8XuegThQZaF4ao5iEmjzKtdYeRjwmfPMTOqKkZ7RotF7fHW dTB19Ug9MhA4w== Date: Thu, 8 Feb 2024 08:27:24 +0200 From: Mike Rapoport To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Matthew Wilcox , Ryan Roberts , Russell King , Catalin Marinas , Will Deacon , Dinh Nguyen , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Aneesh Kumar K.V" , "Naveen N. Rao" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , "David S. Miller" , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org Subject: Re: [PATCH v3 12/15] mm/memory: pass PTE to copy_present_pte() Message-ID: References: <20240129124649.189745-1-david@redhat.com> <20240129124649.189745-13-david@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240129124649.189745-13-david@redhat.com> On Mon, Jan 29, 2024 at 01:46:46PM +0100, David Hildenbrand wrote: > We already read it, let's just forward it. > > This patch is based on work by Ryan Roberts. > > Reviewed-by: Ryan Roberts > Signed-off-by: David Hildenbrand Reviewed-by: Mike Rapoport (IBM) > --- > mm/memory.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/mm/memory.c b/mm/memory.c > index a3bdb25f4c8d..41b24da5be38 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -959,10 +959,9 @@ static inline void __copy_present_pte(struct vm_area_struct *dst_vma, > */ > static inline int > copy_present_pte(struct vm_area_struct *dst_vma, struct vm_area_struct *src_vma, > - pte_t *dst_pte, pte_t *src_pte, unsigned long addr, int *rss, > - struct folio **prealloc) > + pte_t *dst_pte, pte_t *src_pte, pte_t pte, unsigned long addr, > + int *rss, struct folio **prealloc) > { > - pte_t pte = ptep_get(src_pte); > struct page *page; > struct folio *folio; > > @@ -1103,7 +1102,7 @@ copy_pte_range(struct vm_area_struct *dst_vma, struct vm_area_struct *src_vma, > } > /* copy_present_pte() will clear `*prealloc' if consumed */ > ret = copy_present_pte(dst_vma, src_vma, dst_pte, src_pte, > - addr, rss, &prealloc); > + ptent, addr, rss, &prealloc); > /* > * If we need a pre-allocated page for this pte, drop the > * locks, allocate, and try again. > -- > 2.43.0 > > -- Sincerely yours, Mike.