Received-SPF: pass (google.com: domain of linux-kernel+bounces-57524-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 8 Feb 2024 12:04:34 +0530
From: "Gautham R. Shenoy" <gautham.shenoy@amd.com>
To: Perry Yuan <perry.yuan@amd.com>
Cc: rafael.j.wysocki@intel.com, Mario.Limonciello@amd.com,
	viresh.kumar@linaro.org, Ray.Huang@amd.com, Borislav.Petkov@amd.com,
	Alexander.Deucher@amd.com, Xinmei.Huang@amd.com,
	Xiaojian.Du@amd.com, Li.Meng@amd.com, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 3/6] cpufreq:amd-pstate: initialize nominal_freq of
 each cpudata
Message-ID: <ZcR1+kL8ShJdnK5B@BLR-5CG11610CF.amd.com>
References: <cover.1707363758.git.perry.yuan@amd.com>
 <b4fcf3b4c2b5abcf79bbaf9780fe67b4ec697dee.1707363758.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b4fcf3b4c2b5abcf79bbaf9780fe67b4ec697dee.1707363758.git.perry.yuan@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?TXC/A58APifh6W6mA5CYsebq2TADR1wYNzQWJsF4ypkoXfl/L+BpdjVWRZO6?=
 =?us-ascii?Q?iQjqdTRly/P8Jsye9XGjzMfS+Dsh9twaJaUSMkPi8fAAyakD954mDMfezMmN?=
 =?us-ascii?Q?HT8Q9Y3x22k30cAF3D/8wJJCihmaz/3fZtcNyNZq2Emvcmg8J5ljZr2Z6T8e?=
 =?us-ascii?Q?G3Kt2p5tv0rPx9UQyNDPrZfHgSUpaNA2VNg0r9/j84h/X018Qn7NHdcHWM4y?=
 =?us-ascii?Q?bw1lUPtc796yoGIE7QzqEZlcPd1IWmNlP47wdhEd5RFQvvYPjabGhsF4+iCE?=
 =?us-ascii?Q?b7Pe1/NpJw7vmP58PBncTemhplZMQS2cAZ7ssc+dpJoIrpeM6NYNfsHHN3QJ?=
 =?us-ascii?Q?v7N9yJr2COW8CayXGXf52PkLja/ycVz/7LRN837NdCJH84U/vMjK3WSKlk8Y?=
 =?us-ascii?Q?Z5Z1q7nB4x5yZIkV62L+Gdgx/ILoYN/LgpGu520TToevvX/se477D+xEsmOQ?=
 =?us-ascii?Q?WbMciNI0RfrGRuVYYZSOyEFzADiO/PdYirr+YfQKdHo5tS2lAK3CqI0TmXYM?=
 =?us-ascii?Q?QMvUmoBK/qGhintIwPTO2c1OLfZ1KC3t6PHYpm6SfbAybj0dHMJtI6b6JH0w?=
 =?us-ascii?Q?acT6w0Lo/ZDD+rJlncVLv7pTNGQF8REKJEF28UMMz+646URT+dtyad7fsYDc?=
 =?us-ascii?Q?tzR/SYPRbDvKk/NOq93u7HDhsSXzDhdTYT9f7oYv8e2TLcyc9C4qr9mi5omg?=
 =?us-ascii?Q?y/TU7LM17PoEydcwxsMdTvToIdgF2WDhSZvESsoVkQbu20chehTFUd/wd+Uh?=
 =?us-ascii?Q?p0POPzSb6jcV9MaHkg4/MxtGXhlwJIr4Uey13CZYl6TRmCAO1Ihekk5mp//V?=
 =?us-ascii?Q?zAZ1kIxjCC6RvUvsgJD97zY3QWBTbgoR+tp2yvd5ItVrU5Vbuzi1eVjwocIW?=
 =?us-ascii?Q?EwI5ye0t8w/ufdZCIGk9DIAlV0bHOup5JquBHmEDdMSO5nTM9YlDDRtHXijd?=
 =?us-ascii?Q?wqCm52IRydx8D4CEkDPnRUZWqu5zcZlH7IPxOMljQrAr0VA10euR2UUvgZHx?=
 =?us-ascii?Q?nntSG+907XXQhPIylpjFGdWpd1dwxazgb/WlCRIFoW0tWHxsRr0ckkHnRDhV?=
 =?us-ascii?Q?n3e4DA3IFOTjH1qxH1x9FRw6MqVQ0chYFN0/a6sEel5PnrL0I2dJpMjfzanC?=
 =?us-ascii?Q?va0de/vVDPrSZ4KYLexxFeNETq2uSeoa00tV8b1RZkDrm2nzkfxtVqy8ypWU?=
 =?us-ascii?Q?cFZ2Lp7b5UsVLxIYO8xJxf6RPtsHdUWQ5zmpbabM+rwrcBRlo4vD+yLiJsiw?=
 =?us-ascii?Q?czA+NeoGiz+l+dqJ9EDG7UDbkom4l11jkFG8D/eLCbSYGMP9Ejx9ALMWQRA6?=
 =?us-ascii?Q?TtVbjNmAQN1yFb8pdCHTxaVu8Zm3mz6A7M/UIWhz98CTOZ3/neh4fHcH9xfk?=
 =?us-ascii?Q?X8WsEtqWrFaivzD3QgW3c7u6oL2eW/cJSPFaeLozie8kxjuGfYFKDvfZLOYq?=
 =?us-ascii?Q?a+cqqzhN0ujOZUdMA9AGcxevdPqGWPttiNjAuGSUkZcsmL63rPj945lZUq/V?=
 =?us-ascii?Q?ETZKTpL853azd5Jjed0eFrQWBYrxSq4kVKYq1NaoD9axRR58uLd+AHY9+zD+?=
 =?us-ascii?Q?piTOh0fM+SbN0vX6ebXizAPM1aHa2IFgrNqNOO9r?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: af8d2d5b-9a85-4377-7ba5-08dc28700930
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB8252.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2024 06:34:43.7060
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: db14sLH0Gbx/e3/x1Q95noLzaQJx5XCSeTFz8+zMKvCHI6vn22esMMHKnqbyvWdHeDtlwnQJnu333nvoZrgHcw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6791


On Thu, Feb 08, 2024 at 11:46:30AM +0800, Perry Yuan wrote:
> Optimizes the process of retrieving the nominal frequency by utilizing
> 'cpudata->nominal_freq' instead of repeatedly accessing the cppc_acpi interface.
> 
> To enhance efficiency and reduce the CPU load, shifted to using
> 'cpudata->nominal_freq'. It allows for the nominal frequency to be accessed
> directly from the cached data in 'cpudata' of each CPU.
> It will also slightly reduce the frequency change latency while using pstate
> driver passive mode.
> 
> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>
> ---
>  drivers/cpufreq/amd-pstate.c | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index ac7faa98a450..ea8681ea3bad 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -619,7 +619,7 @@ static int amd_get_max_freq(struct amd_cpudata *cpudata)
>  	if (ret)
>  		return ret;
>  
> -	nominal_freq = cppc_perf.nominal_freq;
> +	nominal_freq = READ_ONCE(cpudata->nominal_freq);

Does it make sense to call cppc_get_perf_caps() in
amd_pstate_cpu_init() and amd_pstate_epp_cpu_init() and cache all the
relevant metrics such as highest_perf, lowest_perf,
lowest_nonlinear_perf, nominal_perf, nominal_freq, lowest_freq so that
subsequent calls to amd_get_max/min/lowest_nonlinear/nominal_freq()
can use these cached values instead of calling cppc_get_perf_caps()
again ?

Because even with this patch, we continue to call cppc_get_perf_caps()
in amd_get_max_freq(), amd_get_min_freq() and
amd_get_lowest_nonlinear_freq().


>  	nominal_perf = READ_ONCE(cpudata->nominal_perf);
>  	max_perf = READ_ONCE(cpudata->highest_perf);
>  
> @@ -654,7 +654,7 @@ static int amd_get_lowest_nonlinear_freq(struct amd_cpudata *cpudata)
>  	if (ret)
>  		return ret;
>  
> -	nominal_freq = cppc_perf.nominal_freq;
> +	nominal_freq = READ_ONCE(cpudata->nominal_freq);
>  	nominal_perf = READ_ONCE(cpudata->nominal_perf);
>  
>  	lowest_nonlinear_perf = cppc_perf.lowest_nonlinear_perf;
> @@ -848,13 +848,14 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy)
>  		goto free_cpudata1;
>  
>  	min_freq = amd_get_min_freq(cpudata);
> -	max_freq = amd_get_max_freq(cpudata);
>  	nominal_freq = amd_get_nominal_freq(cpudata);
> +	cpudata->nominal_freq = nominal_freq;
> +	max_freq = amd_get_max_freq(cpudata);
>  	lowest_nonlinear_freq = amd_get_lowest_nonlinear_freq(cpudata);
>  
> -	if (min_freq < 0 || max_freq < 0 || min_freq > max_freq) {
> -		dev_err(dev, "min_freq(%d) or max_freq(%d) value is incorrect\n",
> -			min_freq, max_freq);
> +	if (min_freq < 0 || max_freq < 0 || min_freq > max_freq || nominal_freq == 0) {

+1 for the "nominal_freq == 0" check. On CPPCv2, nominal_freq and
lowest_freq are not advertised. So nominal_freq will be 0. It is
better to fail here than failing later at the time of governor
initialization.


> +		dev_err(dev, "min_freq(%d) or max_freq(%d) or nominal_freq(%d) is incorrect\n",
> +			min_freq, max_freq, nominal_freq);
>  		ret = -EINVAL;
>  		goto free_cpudata1;
>  	}
> @@ -893,7 +894,6 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy)
>  	cpudata->min_freq = min_freq;
>  	cpudata->max_limit_freq = max_freq;
>  	cpudata->min_limit_freq = min_freq;
> -	cpudata->nominal_freq = nominal_freq;
>  	cpudata->lowest_nonlinear_freq = lowest_nonlinear_freq;
>  
>  	policy->driver_data = cpudata;
> @@ -1310,12 +1310,13 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy)
>  		goto free_cpudata1;
>  
>  	min_freq = amd_get_min_freq(cpudata);
> -	max_freq = amd_get_max_freq(cpudata);
>  	nominal_freq = amd_get_nominal_freq(cpudata);
> +	cpudata->nominal_freq = nominal_freq;
> +	max_freq = amd_get_max_freq(cpudata);
>  	lowest_nonlinear_freq = amd_get_lowest_nonlinear_freq(cpudata);
> -	if (min_freq < 0 || max_freq < 0 || min_freq > max_freq) {
> -		dev_err(dev, "min_freq(%d) or max_freq(%d) value is incorrect\n",
> -				min_freq, max_freq);
> +	if (min_freq < 0 || max_freq < 0 || min_freq > max_freq || nominal_freq == 0) {


Ditto.

> +		dev_err(dev, "min_freq(%d) or max_freq(%d) or nominal_freq(%d) is incorrect\n",
> +				min_freq, max_freq, nominal_freq);
>  		ret = -EINVAL;
>  		goto free_cpudata1;
>  	}
> @@ -1328,7 +1329,6 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy)
>  	/* Initial processor data capability frequencies */
>  	cpudata->max_freq = max_freq;
>  	cpudata->min_freq = min_freq;
> -	cpudata->nominal_freq = nominal_freq;
>  	cpudata->lowest_nonlinear_freq = lowest_nonlinear_freq;


--
Thanks and Regards
gautham.