Received-SPF: pass (google.com: domain of linux-kernel+bounces-57535-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: "Akula, Kalyani" <kalyani.akula@amd.com>
To: "Kundanala, Praveen Teja" <praveen.teja.kundanala@amd.com>,
	"srinivas.kandagatla@linaro.org" <srinivas.kandagatla@linaro.org>, "Simek,
 Michal" <michal.simek@amd.com>, "Kundanala, Praveen Teja"
	<praveen.teja.kundanala@amd.com>, "devicetree@vger.kernel.org"
	<devicetree@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH V4 2/4] nvmem: zynqmp_nvmem: zynqmp_nvmem_probe cleanup
Thread-Topic: [PATCH V4 2/4] nvmem: zynqmp_nvmem: zynqmp_nvmem_probe cleanup
Thread-Index: AQHaVcyCbGHMLh2EZUCTdZNZkpMnyrEACV4A
Date: Thu, 8 Feb 2024 06:47:52 +0000
Message-ID:
 <DM6PR12MB41547758296EEDAF2B5DFFF3F8442@DM6PR12MB4154.namprd12.prod.outlook.com>
References: <20240202113843.17999-1-praveen.teja.kundanala@amd.com>
 <20240202113843.17999-3-praveen.teja.kundanala@amd.com>
In-Reply-To: <20240202113843.17999-3-praveen.teja.kundanala@amd.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?DixjFRpJtIFcmVeB+G85smFwfqMiVVTthLALrta+Dkq9LdPak6ryejxPIM6V?=
 =?us-ascii?Q?lOB2flBPVGh0Dvone/Kddv0e1xO5PAN9e9qbv8cx1ds0yVHzGZ2JE78ZcvvK?=
 =?us-ascii?Q?KDNHpg8Inq4nAGGe7bCgL132BYtLG9kxVsjmkGmAWJNSQx6rQ/vDy0lXuifa?=
 =?us-ascii?Q?mqDZOpQpoUYCEEwzr/40iYKAGbgCOkRKiBxHKk3fxP1NsLZrDxkOVm1kcVjx?=
 =?us-ascii?Q?xsUkXFTXAtSTBaCLGjxydtVovt6EZTCUVHaIqcqB3mkwDOWRPzIsvT+D6kyW?=
 =?us-ascii?Q?Ml4OQicSbM5E1k4MSbQ3ic/HaLjAxD0SFZiWFu4BZyj7RZKXUVIQ8knykyov?=
 =?us-ascii?Q?jkDc0zu6Ki4nu9e7PbsK8ZpHElbmCYLH0dBKKLG1RgWrh7AtXA7jUWjdPeUP?=
 =?us-ascii?Q?CJVNLVzOXyVCVcTjifbVrh/MoDE8g2wbXndoli9RhrdnBtrQMTB/tBwRno9B?=
 =?us-ascii?Q?ccZ1Nk+wM3tKETc3bslogGurfJJwacOQULjWeZw6db0m4yMi/fltYcwDjC+L?=
 =?us-ascii?Q?10zv7Cs3B1vwVqnxrTmALFgiJkFd60xkPO702YnX99SumrfMKio3hrYRdzuo?=
 =?us-ascii?Q?/zpvV0a8EN+kt7Qhq4XGIQRfcF2WDhq4CQhnwKnkt78R0/kfqr0QEjvLfeqS?=
 =?us-ascii?Q?mSeTlxaUqMaPlmmrNVOhv63pl7YKCAt9LSwezQrCH8mfO5fotevXnoeMlBTp?=
 =?us-ascii?Q?TxVRrmG9vGluWnWwfmONztQVM12Taro/H3nviJfR/OyJSIvFQJzFG1NySnBB?=
 =?us-ascii?Q?qKZEzfevWcpQBCcxY/TRy15ryZBI46I80GlIWjZNJTTak1FsgcpOv1jQeDA6?=
 =?us-ascii?Q?ibP/Bazpn/xewPFqM3+zN4TjLTeU/GHMKeJbz59YdbGq+IP53agQhQ2R08Pk?=
 =?us-ascii?Q?YChpwUzuIWshGthtLBqx8JZogj1dwLtT4ilbpGeOit+OBTl59466eOyGFRrg?=
 =?us-ascii?Q?l6Zc9glJigDyCuz62s6KBlxoPGPLRb3zRuGEF9LMGvpewI09tEGLRIUcbChJ?=
 =?us-ascii?Q?8AkCpP3wmBcHdjrqehijKxHdARmdenOHLVeipId1ExBazMnCcKBjiVgscq5M?=
 =?us-ascii?Q?jRVRsLNKYVmpjcnKeWm+Zw8gY0S1N5DChu/sKayPnfruHykIn2KdIARuWulI?=
 =?us-ascii?Q?hXHA9cvTRXY5vROJr3Uth22WTgaSdlu8AIkDFZvKfbUQfzatGAXHGygY6gyu?=
 =?us-ascii?Q?ws0hvqj1qLH/0pq/+9b3fc49hnTf4Ifo1OYn7arjyJQ2OVVmsyZTMjmHf5un?=
 =?us-ascii?Q?2ezHzsVtYv37zdQ0uOmQirBEt97rHg5LI9rvHdHPQthbY5mnxxlSdilchiJt?=
 =?us-ascii?Q?kFoTvDrI5GLi4qR6Ftov3yCHWXvl3ZNWs+CgckzhynGbDgPnFViDM2gDTo4s?=
 =?us-ascii?Q?gXJct8e1xxEtnfvKLDWR+8JMah1HWGHhKhs0uEFZmswLBToVPWfGWOyhJxbF?=
 =?us-ascii?Q?qpB7DKga0fZq0tIj2OodAizdWsWfq4ORpzm0rDxYTxeamQBUS5Odl1nIBXlp?=
 =?us-ascii?Q?AgSLqBpna7hEnwhIXXoxJdaHvN/AvLrqoWdZ4Xp7qXI85PHLjEHgWtEOHEIq?=
 =?us-ascii?Q?0wAAmwSWyfw6L4qmVWo=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4154.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a96e4a6-eff4-4746-071d-08dc2871df57
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2024 06:47:52.2832
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: hk9zRfqIaN08kN8140lwHC8GklMHM0j6KCr7UtqR/G7ogBm3bKCuldmkbgKsV2jxcrCQCWyt+mQHwfQk2m/ITg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB5509


>-----Original Message-----
>From: Praveen Teja Kundanala <praveen.teja.kundanala@amd.com>
>Sent: Friday, February 2, 2024 5:09 PM
>To: srinivas.kandagatla@linaro.org; Simek, Michal <michal.simek@amd.com>;
>Akula, Kalyani <kalyani.akula@amd.com>; Kundanala, Praveen Teja
><praveen.teja.kundanala@amd.com>; devicetree@vger.kernel.org; linux-arm-
>kernel@lists.infradead.org
>Cc: linux-kernel@vger.kernel.org
>Subject: [PATCH V4 2/4] nvmem: zynqmp_nvmem: zynqmp_nvmem_probe
>cleanup
>
>- Remove static nvmem_config declaration
>- Remove zynqmp_nvmem_data
>
>Signed-off-by: Praveen Teja Kundanala <praveen.teja.kundanala@amd.com>
>---
> drivers/nvmem/zynqmp_nvmem.c | 37 ++++++++++++------------------------
> 1 file changed, 12 insertions(+), 25 deletions(-)
>
>diff --git a/drivers/nvmem/zynqmp_nvmem.c
>b/drivers/nvmem/zynqmp_nvmem.c index 7f15aa89a9d0..391d8e88b270
>100644
>--- a/drivers/nvmem/zynqmp_nvmem.c
>+++ b/drivers/nvmem/zynqmp_nvmem.c
>@@ -1,6 +1,7 @@
> // SPDX-License-Identifier: GPL-2.0+
> /*
>  * Copyright (C) 2019 Xilinx, Inc.
>+ * Copyright (C) 2022 - 2023, Advanced Micro Devices, Inc.
>  */
>
> #include <linux/module.h>
>@@ -11,36 +12,25 @@
>
> #define SILICON_REVISION_MASK 0xF
>
>-struct zynqmp_nvmem_data {
>-	struct device *dev;
>-	struct nvmem_device *nvmem;
>-};
>
> static int zynqmp_nvmem_read(void *context, unsigned int offset,
> 			     void *val, size_t bytes)
> {
>+	struct device *dev =3D context;
> 	int ret;
>-	int idcode, version;
>-	struct zynqmp_nvmem_data *priv =3D context;
>+	int idcode;
>+	int version;
>
> 	ret =3D zynqmp_pm_get_chipid(&idcode, &version);
> 	if (ret < 0)
> 		return ret;
>
>-	dev_dbg(priv->dev, "Read chipid val %x %x\n", idcode, version);
>+	dev_dbg(dev, "Read chipid val %x %x\n", idcode, version);
> 	*(int *)val =3D version & SILICON_REVISION_MASK;
>
> 	return 0;
> }
>
>-static struct nvmem_config econfig =3D {
>-	.name =3D "zynqmp-nvmem",
>-	.owner =3D THIS_MODULE,
>-	.word_size =3D 1,
>-	.size =3D 1,
>-	.read_only =3D true,
>-};
>-
> static const struct of_device_id zynqmp_nvmem_match[] =3D {
> 	{ .compatible =3D "xlnx,zynqmp-nvmem-fw", },
> 	{ /* sentinel */ },
>@@ -50,21 +40,18 @@ MODULE_DEVICE_TABLE(of, zynqmp_nvmem_match);
>static int zynqmp_nvmem_probe(struct platform_device *pdev)  {
> 	struct device *dev =3D &pdev->dev;
>-	struct zynqmp_nvmem_data *priv;
>+	struct nvmem_config econfig =3D {};
>
>-	priv =3D devm_kzalloc(dev, sizeof(struct zynqmp_nvmem_data),
>GFP_KERNEL);
>-	if (!priv)
>-		return -ENOMEM;
>-
>-	priv->dev =3D dev;
>+	econfig.name =3D "zynqmp-nvmem";
>+	econfig.owner =3D THIS_MODULE;
>+	econfig.word_size =3D 1;
>+	econfig.size =3D 1;
> 	econfig.dev =3D dev;
> 	econfig.add_legacy_fixed_of_cells =3D true;
>+	econfig.read_only =3D true;
> 	econfig.reg_read =3D zynqmp_nvmem_read;
>-	econfig.priv =3D priv;
>-
>-	priv->nvmem =3D devm_nvmem_register(dev, &econfig);
>
>-	return PTR_ERR_OR_ZERO(priv->nvmem);
>+	return PTR_ERR_OR_ZERO(devm_nvmem_register(dev, &econfig));
> }
>
> static struct platform_driver zynqmp_nvmem_driver =3D {
>--
>2.37.6

Acked-by: Kalyani Akula <Kalyani.akula@amd.com>
=20
Regards,
Kalyani