Received-SPF: pass (google.com: domain of linux-kernel+bounces-57554-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 8 Feb 2024 12:52:35 +0530
From: Jai Luthra <j-luthra@ti.com>
To: Wadim Egorov <w.egorov@phytec.de>
CC: Andrew Davis <afd@ti.com>, Nathan Morrisson <nmorrisson@phytec.com>,
        <nm@ti.com>, <vigneshr@ti.com>, <kristo@kernel.org>,
        <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <conor+dt@kernel.org>, <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <upstream@lists.phytec.de>
Subject: Re: Re: [PATCH] arm64: dts: ti: am62-phyboard-lyra: Add overlay to
 enable a GPIO fan
Message-ID: <7zzhg5tgypia7nta3pz6ocu3linrfghmilnd7icdvsoupzyepp@4vbmmkh2jtc7>
References: <20240207172820.478332-1-nmorrisson@phytec.com>
 <acd3c7f2-930d-46c0-9924-9775e9795fca@ti.com>
 <033de6e2-4ca4-46bc-a0a7-e9921ed15977@phytec.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="nyrrqv4d76o3v3xw"
Content-Disposition: inline
In-Reply-To: <033de6e2-4ca4-46bc-a0a7-e9921ed15977@phytec.de>

--nyrrqv4d76o3v3xw
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Wadim,

On Feb 08, 2024 at 06:57:54 +0100, Wadim Egorov wrote:
> Hi Andrew,
>=20
> Am 07.02.24 um 23:20 schrieb Andrew Davis:
> > On 2/7/24 11:28 AM, Nathan Morrisson wrote:
> > > The phyBOARD-Lyra has a GPIO fan header. This overlay enables the fan
> > > header and sets the fan to turn on at 65C.
> > >=20
> > > Signed-off-by: Nathan Morrisson <nmorrisson@phytec.com>
> > > ---
> > > =C2=A0 arch/arm64/boot/dts/ti/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 1 +
> > > =C2=A0 .../ti/k3-am62-phyboard-lyra-gpio-fan.dtso=C2=A0=C2=A0=C2=A0 |=
 51 +++++++++++++++++++
> > > =C2=A0 2 files changed, 52 insertions(+)
> > > =C2=A0 create mode 100644
> > > arch/arm64/boot/dts/ti/k3-am62-phyboard-lyra-gpio-fan.dtso
> > >=20
> > > diff --git a/arch/arm64/boot/dts/ti/Makefile
> > > b/arch/arm64/boot/dts/ti/Makefile
> > > index 52c1dc910308..379fb4f31a1f 100644
> > > --- a/arch/arm64/boot/dts/ti/Makefile
> > > +++ b/arch/arm64/boot/dts/ti/Makefile
> > > @@ -23,6 +23,7 @@ dtb-$(CONFIG_ARCH_K3) +=3D k3-am625-verdin-wifi-dev=
=2Edtb
> > > =C2=A0 dtb-$(CONFIG_ARCH_K3) +=3D k3-am625-verdin-wifi-mallow.dtb
> > > =C2=A0 dtb-$(CONFIG_ARCH_K3) +=3D k3-am625-verdin-wifi-yavia.dtb
> > > =C2=A0 dtb-$(CONFIG_ARCH_K3) +=3D k3-am62-lp-sk.dtb
> > > +dtb-$(CONFIG_ARCH_K3) +=3D k3-am62-phyboard-lyra-gpio-fan.dtbo
> >=20
> > Why not call this k3-am625-phyboard-lyra-gpio-fan.dtbo to match the
> > name of the base board it applies to better?
>=20
> We are able to reuse this overlay for different SoMs (am625 and am62a) th=
at
> are using the same carrier board (lyra).

In that case do you mind calling it k3-am62x-phyboard-*? It would match=20
the existing convention we have for camera sensor overlays that can be=20
applied on SK-AM62, SK-AM62A, SK-AM62P etc.
>=20
> Regards,
> Wadim
>=20
>=20
> >=20
> > Andrew
> >=20
> > > =C2=A0 =C2=A0 # Boards with AM62Ax SoC
> > > =C2=A0 dtb-$(CONFIG_ARCH_K3) +=3D k3-am62a7-sk.dtb
> > > diff --git
> > > a/arch/arm64/boot/dts/ti/k3-am62-phyboard-lyra-gpio-fan.dtso
> > > b/arch/arm64/boot/dts/ti/k3-am62-phyboard-lyra-gpio-fan.dtso
> > > new file mode 100644
> > > index 000000000000..9c05748bdd9d
> > > --- /dev/null
> > > +++ b/arch/arm64/boot/dts/ti/k3-am62-phyboard-lyra-gpio-fan.dtso
> > > @@ -0,0 +1,51 @@
> > > +// SPDX-License-Identifier: GPL-2.0-only OR MIT
> > > +/*
> > > + * Copyright (C) 2024 PHYTEC America LLC
> > > + * Author: Garrett Giordano <ggiordano@phytec.com>
> > > + */
> > > +
> > > +/dts-v1/;
> > > +/plugin/;
> > > +
> > > +#include <dt-bindings/gpio/gpio.h>
> > > +#include <dt-bindings/thermal/thermal.h>
> > > +#include "k3-pinctrl.h"
> > > +
> > > +&{/} {
> > > +=C2=A0=C2=A0=C2=A0 fan: gpio-fan {
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 compatible =3D "gpio-fan";
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 gpio-fan,speed-map =3D <0=
 0 8600 1>;
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 gpios =3D <&main_gpio0 40=
 GPIO_ACTIVE_LOW>;
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #cooling-cells =3D <2>;
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pinctrl-names =3D "defaul=
t";
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pinctrl-0 =3D <&gpio_fan_=
pins_default>;
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 status =3D "okay";
> > > +=C2=A0=C2=A0=C2=A0 };
> > > +};
> > > +
> > > +&main_pmx0 {
> > > +=C2=A0=C2=A0=C2=A0 gpio_fan_pins_default: gpio-fan-default-pins {
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pinctrl-single,pins =3D <
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 A=
M62X_IOPAD(0x0a4, PIN_OUTPUT, 7) /* (M22)
> > > GPMC0_DIR.GPIO0_40 */
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 >;
> > > +=C2=A0=C2=A0=C2=A0 };
> > > +};
> > > +
> > > +&thermal_zones {
> > > +=C2=A0=C2=A0=C2=A0 main0_thermal: main0-thermal {
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 trips {
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 m=
ain0_thermal_trip0: main0-thermal-trip {
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0 temperature =3D <65000>;=C2=A0 /* millicelsius */
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0 hysteresis =3D <2000>;=C2=A0=C2=A0=C2=A0 /* millic=
elsius */
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0 type =3D "active";
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 };
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 };
> > > +
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 cooling-maps {
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 m=
ap0 {
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0 trip =3D <&main0_thermal_trip0>;
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0 cooling-device =3D <&fan THERMAL_NO_LIMIT
> > > THERMAL_NO_LIMIT>;
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 };
> > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 };
> > > +=C2=A0=C2=A0=C2=A0 };
> > > +};
> >=20
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

--=20
Thanks,
Jai

GPG Fingerprint: 4DE0 D818 E5D5 75E8 D45A AFC5 43DE 91F9 249A 7145

--nyrrqv4d76o3v3xw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEETeDYGOXVdejUWq/FQ96R+SSacUUFAmXEgTYACgkQQ96R+SSa
cUUexA/8CbWipRfeSHq2u7+K+hYoyjV2o/C3gUS8RfzLQyZvl9Ey8mODmJpsTZH2
YRBFvj5RT6w7foqhM1D0eWTkQR/Adm9Zr+WX5kZ7EB7A83pUNqDAkV322u5rV+Fv
Yk3Lh+Jd7aBgKuEGrBUjsQrX4EggOgB6L8npNhcAu7TYHG2Vc5Ymqs6LNJxm3LO6
MVmS0zN+1/aO6Yb/vfucnknYidEQPpJkEeomSxvTubNpFPPzlRdbPZ94ywmuAD9o
oJeSEnvIRCZgP9uyVFnUtzI4J8wfuL9rOXteinEOzOaxValZ2Hlqvi0ICs0/Wlic
LSv6NKmyhCuakGMuoCcgG0AK0dbV96rHYoB5tUcfSZgrGQeDtBJgr6djy9Ah22zy
JUQ+uRya/r4Xk1xoCD4ZN4asQo8+VV6yVqT3xAP5Hd3PFJhUHGbeLfOHdPVUPsa/
AA7r7zl35A1+CTCAlzwf8HxcWtC4/j+r4y7uLoCQf8UxP2wP1h6vaWZPQ9AA3+Ps
Wl4OIYjCa9rlEGG6nU4cIkfuaHQYhrHuJ4qKUeaQlnFpro3Z+/5/wR0y2eKGRDIA
Xfwi/kuB+/e3d2jF6wDRbQh/uwtNY2v5L1hC86exs0hrnOhGjWDcYT1xb9bh1iNW
CRxo6dsLh7J/ykJMmh32idfoD/mOvCDHx9NdssXVjaTdSTrzdiA=
=0Ili
-----END PGP SIGNATURE-----

--nyrrqv4d76o3v3xw--