Received-SPF: pass (google.com: domain of linux-kernel+bounces-57560-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240131134621.1017530-1-hayatake396@gmail.com>
 <20240131131258.47c05b7e@kernel.org> <CADFiAc+y_SXGtVqZkLoiWw-YBArMovMkuWw3X596QDwEtdBJ2g@mail.gmail.com>
In-Reply-To: <CADFiAc+y_SXGtVqZkLoiWw-YBArMovMkuWw3X596QDwEtdBJ2g@mail.gmail.com>
From: Takeru Hayasaka <hayatake396@gmail.com>
Date: Thu, 8 Feb 2024 16:34:49 +0900
Message-ID: <CADFiAcK_XjLNjzZuF+OZDWjZA4tFB8VgeYXVJHR8+N3XryGxwA@mail.gmail.com>
Subject: Re: [PATCH net-next v6] ethtool: ice: Support for RSS settings to GTP
 from ethtool
To: Jakub Kicinski <kuba@kernel.org>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>, Tony Nguyen <anthony.l.nguyen@intel.com>, 
	"David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, 
	Paolo Abeni <pabeni@redhat.com>, Jonathan Corbet <corbet@lwn.net>, intel-wired-lan@lists.osuosl.org, 
	netdev@vger.kernel.org, linux-doc@vger.kernel.org, 
	linux-kernel@vger.kernel.org, mailhol.vincent@wanadoo.fr, 
	vladimir.oltean@nxp.com, laforge@gnumonks.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hello Jakub-san, and all reviewers and maintainers,

It has been a week since I last received any feedback on this patch. I
apologize for the inconvenience during this busy period, but I would
greatly appreciate it if you could continue the review.

Sincerely,
Takeru

2024=E5=B9=B42=E6=9C=881=E6=97=A5(=E6=9C=A8) 9:59 takeru hayasaka <hayatake=
396@gmail.com>:
>
> Hi Jakub-san
> Thank you for your review.
> I apologize for the delay in resubmitting the patch.
>
> > Could you split the uAPI changes and the driver changes to two separate
> > commits? You should post them as a patch series, but combining them
> > into a single commit makes the uAPI addition to easy to miss.
>
> Understood. I will split the patches and submit them separately in v7.
>
> Thanks
> Takeru
>
> 2024=E5=B9=B42=E6=9C=881=E6=97=A5(=E6=9C=A8) 6:13 Jakub Kicinski <kuba@ke=
rnel.org>:
> >
> > On Wed, 31 Jan 2024 13:46:22 +0000 Takeru Hayasaka wrote:
> > >  .../device_drivers/ethernet/intel/ice.rst     | 21 ++++-
> > >  drivers/net/ethernet/intel/ice/ice_ethtool.c  | 82 +++++++++++++++++=
++
> > >  drivers/net/ethernet/intel/ice/ice_flow.h     | 31 +++++--
> > >  drivers/net/ethernet/intel/ice/ice_lib.c      | 37 +++++++++
> > >  include/uapi/linux/ethtool.h                  | 48 +++++++++++
> >
> > Could you split the uAPI changes and the driver changes to two separate
> > commits? You should post them as a patch series, but combining them
> > into a single commit makes the uAPI addition to easy to miss.
> > --
> > pw-bot: cr