Received-SPF: pass (google.com: domain of linux-kernel+bounces-57571-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 8 Feb 2024 08:46:44 +0100
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: andriy.shevchenko@linux.intel.com, Raag Jadav <raag.jadav@intel.com>
Cc: jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com, 
	lakshmi.sowjanya.d@intel.com, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/5] pwm: dwc: drop redundant error check
Message-ID: <qrwcje4t2pbbxilnlfz2q7njodcp6vl54uaypdbvjgvwhgvc5g@4eq5wvumpjjx>
References: <20240208070529.28562-1-raag.jadav@intel.com>
 <20240208070529.28562-2-raag.jadav@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="xlh5lne2t7smrnyn"
Content-Disposition: inline
In-Reply-To: <20240208070529.28562-2-raag.jadav@intel.com>


--xlh5lne2t7smrnyn
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 08, 2024 at 12:35:25PM +0530, Raag Jadav wrote:
> pcim_iomap_table() fails only if pcim_iomap_regions() fails. No need to
> check for failure if the latter is already successful.

Is this really true? pcim_iomap_table() calls devres_alloc_node() which
might fail if the allocation fails. (Yes, I know
https://lwn.net/Articles/627419/, but the rule is still to check for
errors, right?)

What am I missing?

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--xlh5lne2t7smrnyn
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmXEhuMACgkQj4D7WH0S
/k5Olwf/dwZIJw628t/aGAEw0FtU/HzoSUJ1BaFp000aDowWve+BF2cPDzakhFi4
BdLaB0m7H5BPs0FpeUv9mTaVEdCiXsQaOE2yPQTmbeiy5/cqMVftPkUfJvSx4oRM
uNAeg8VdiNC+7GrjJ9A9rcZwRbF9yoO8rjJ+1fH7M4q7IAfxWgKu2LcjhjFGRuAs
B4XRgoLdDBYpVtHX4IMFX3NVrk2nAFYMQmNd4mvjxteC7i3CRB9N8HDiFXzFTISl
1h7olr5Vq0sNB97QfZX100PeaJcdZo2o89NR/RMd3XWiL/fDPAnneWTgXduP3mxk
mbTudFFjPoRxG5POPxqzQYWo+yORiw==
=XhB1
-----END PGP SIGNATURE-----

--xlh5lne2t7smrnyn--