Received-SPF: pass (google.com: domain of linux-kernel+bounces-57590-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <fd81a6127a9b7abb6eae0785281836a238af8b57.camel@gmail.com>
Subject: Re: [PATCH 1/2] iio: adc: ad4130: zero-initialize clock init data
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: Cosmin Tanislav <demonsingur@gmail.com>
Cc: Cosmin Tanislav <cosmin.tanislav@analog.com>, Lars-Peter Clausen
	 <lars@metafoo.de>, Michael Hennerich <Michael.Hennerich@analog.com>, 
	Jonathan Cameron
	 <jic23@kernel.org>, Andy Shevchenko <andy.shevchenko@gmail.com>, 
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Thu, 08 Feb 2024 09:15:08 +0100
In-Reply-To: <20240207132007.253768-1-demonsingur@gmail.com>
References: <20240207132007.253768-1-demonsingur@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.3 
Precedence: bulk
MIME-Version: 1.0

On Wed, 2024-02-07 at 15:20 +0200, Cosmin Tanislav wrote:
> The clk_init_data struct does not have all its members
> initialized, causing issues when trying to expose the internal
> clock on the CLK pin.
>=20
> Fix this by zero-initializing the clk_init_data struct.
>=20
> Fixes: 62094060cf3a ("iio: adc: ad4130: add AD4130 driver")
> Signed-off-by: Cosmin Tanislav <demonsingur@gmail.com>
> ---

Reviewed-by: Nuno Sa <nuno.sa@analog.com>

> =C2=A0drivers/iio/adc/ad4130.c | 2 +-
> =C2=A01 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/iio/adc/ad4130.c b/drivers/iio/adc/ad4130.c
> index 53e19a863198..c7df499f9775 100644
> --- a/drivers/iio/adc/ad4130.c
> +++ b/drivers/iio/adc/ad4130.c
> @@ -1794,7 +1794,7 @@ static int ad4130_setup_int_clk(struct ad4130_state=
 *st)
> =C2=A0{
> =C2=A0	struct device *dev =3D &st->spi->dev;
> =C2=A0	struct device_node *of_node =3D dev_of_node(dev);
> -	struct clk_init_data init;
> +	struct clk_init_data init =3D {};
> =C2=A0	const char *clk_name;
> =C2=A0	int ret;
> =C2=A0