Received-SPF: pass (google.com: domain of linux-kernel+bounces-57591-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <bab0d763-2907-4412-8075-a7ebb25081c0@gmail.com>
Date: Thu, 8 Feb 2024 16:11:50 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] Revert "f2fs: stop allocating pinned sections if EAGAIN
 happens"
To: Chao Yu <chao@kernel.org>, Wu Bo <bo.wu@vivo.com>,
 Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
 stable@vger.kernel.org
References: <20240205031415.557879-1-bo.wu@vivo.com>
 <793fd834-fe28-4647-b2cf-0012acb95b43@kernel.org>
Content-Language: en-US
From: Wu Bo <wubo.oduw@gmail.com>
In-Reply-To: <793fd834-fe28-4647-b2cf-0012acb95b43@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 2024/2/5 11:54, Chao Yu wrote:
> How about calling f2fs_balance_fs() to double check and make sure 
> there is
> enough free space for following allocation.
>
>         if (has_not_enough_free_secs(sbi, 0,
>             GET_SEC_FROM_SEG(sbi, overprovision_segments(sbi)))) {
>             f2fs_down_write(&sbi->gc_lock);
>             stat_inc_gc_call_count(sbi, FOREGROUND);
>             err = f2fs_gc(sbi, &gc_control);
>             if (err == -EAGAIN)
>                 f2fs_balance_fs(sbi, true);
>             if (err && err != -ENODATA)
>                 goto out_err;
>         }
>
> Thanks,

f2fs_balance_fs() here will not change procedure branch and may just 
trigger another GC.

I'm afraid this is a bit redundant.

>