Received-SPF: pass (google.com: domain of linux-kernel+bounces-57628-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Liu, Yi L" <yi.l.liu@intel.com>, "joro@8bytes.org" <joro@8bytes.org>,
	"jgg@nvidia.com" <jgg@nvidia.com>, "baolu.lu@linux.intel.com"
	<baolu.lu@linux.intel.com>
CC: "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
	"robin.murphy@arm.com" <robin.murphy@arm.com>, "eric.auger@redhat.com"
	<eric.auger@redhat.com>, "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>, "chao.p.peng@linux.intel.com"
	<chao.p.peng@linux.intel.com>, "yi.y.sun@linux.intel.com"
	<yi.y.sun@linux.intel.com>, "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>, "Duan,
 Zhenzhong" <zhenzhong.duan@intel.com>, "joao.m.martins@oracle.com"
	<joao.m.martins@oracle.com>
Subject: RE: [PATCH rc 3/8] iommu/vt-d: Add missing iotlb flush for parent
 domain
Thread-Topic: [PATCH rc 3/8] iommu/vt-d: Add missing iotlb flush for parent
 domain
Thread-Index: AQHaWmgS9s4nHWTbYEOW0w2ULF5GvbEAHvWg
Date: Thu, 8 Feb 2024 08:38:37 +0000
Message-ID: <BN9PR11MB5276446E0F03C1F3EC6B2E298C442@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20240208082307.15759-1-yi.l.liu@intel.com>
 <20240208082307.15759-4-yi.l.liu@intel.com>
In-Reply-To: <20240208082307.15759-4-yi.l.liu@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?unhNa5l0nM15EqtRdnT3raRzlfHg4Gcq3PZgzGgH4HU9S/T5EWJJLMg0WtdY?=
 =?us-ascii?Q?TnYG27kFmwgSNheDd6TZ+Ewit9B4jMCkvATzezDdewy/FYYmnj33OQ5zDGBn?=
 =?us-ascii?Q?Xe6qbwAQaDApO6aVHTsKXBwSbjG26XynWacmiQ9VdXAhR+AST+fQKHixvnAn?=
 =?us-ascii?Q?IDKkgVtIU5avnwGk8Hnm47zDcCNfQtFw4Z0UiDFnSZ9o+SNtMcOcaAQRltPx?=
 =?us-ascii?Q?fvRqPzOPjrX6fgB1dh9oqNmHODeCDoNukr24Cb9UaWRLYIx59Hu+cryhdpBJ?=
 =?us-ascii?Q?Uph+7DcoReh3AnZBhUCBTzQxYvGGnU6aKupCH3C59Eb1HhuPe7ySNks5rMk6?=
 =?us-ascii?Q?v6IdvzzIkEJe7ZuldOT+QnJNKqVlqBexcEysg7lXvnffx0eWkpMCOQ8dHqYV?=
 =?us-ascii?Q?luxU49ekK0KBqxUBufwqlzy3BV/I9qWT1cNYAGjR97jbyyrIflrBevq0sQXO?=
 =?us-ascii?Q?iWGCj93pePmeI9v+YXOiHoxs9lsK353KJiDJA0LPHgRBC0JuMyOq/oX9uBlP?=
 =?us-ascii?Q?45AcufepluxDbQfnsTzW9VUMRe9qAtZ+T9CP0jmU/R6L+45J1tkCmWralVIN?=
 =?us-ascii?Q?JcLaHtT4AL8BjJKf9tXV3uU8tyCqFYGEjhh1yyhyykGvtCBfTs9Fh610fA8l?=
 =?us-ascii?Q?jPu3LKyAvqE5cVnbUGooB5c3KkzqFPZ1MLrQLBoq4YUmWMlV/TSuZymRaxcS?=
 =?us-ascii?Q?OM2TdEJIdcaEWUj8XkLv3ZteQGlkBin6LotpEjRkajMn6C6tn5hh/gmEniT0?=
 =?us-ascii?Q?BiB1SrP2OsgBwOUUqKaeXTrZFfdQDsz72rlbGxfKMQc8FKFxgmAxazbk49U0?=
 =?us-ascii?Q?ZjB4m05rCzGdfIO3tF4mVGqMNE2bKRUlBRvr9S813vZlGGgI5CcO0209NS9I?=
 =?us-ascii?Q?NjI/ffAJZl35lKt8IfskTYihafHd6USjOOcajClZNy4IJjuRQZko2FMyTKKi?=
 =?us-ascii?Q?vzNep32RzT4owp1pdIykhPklS1JmnHnpbSlJ9zRnKwnTEKZmUJ4dGxK9DBxw?=
 =?us-ascii?Q?+V2DKGwT/W5nXMnIutIuMRY+HcIN++sEsSC18M9vsdoQqhkvA4esDttJ6UHu?=
 =?us-ascii?Q?t5I7ugypA2sy9/TTY+tLr/XYwJwBosgjalvV1nlMHANoNtc1a9WHtrmY055i?=
 =?us-ascii?Q?Ojrxt/vxAI5A2yfUy1H3RS34cQlmoswVVSSbj6WWotxazBPgwYegfFvIHQmZ?=
 =?us-ascii?Q?3H4nR5kRhRbTk2EiFxS911Am6pa7Q8APT8EkVMfpRgBL5eWK2ARXP4O9QeSL?=
 =?us-ascii?Q?1AhpTbmFUcZYMjbUo+Oy4YUq2voZFky3PddMNmIS/AqtQ00XlnFIBF7ksvA2?=
 =?us-ascii?Q?O4Bom3dbnYVmz9lrJ79p1g1VqXBQ52bMVTlOs8aU1WdQodSgiS2tTX52KB6B?=
 =?us-ascii?Q?k44wvMq9q5QqdHwsc++cvY52Pk+MzsuHeZOWkJgQxur5TqYMBP5aXepRVfjR?=
 =?us-ascii?Q?b2AZkXuwKGDicWuNX7nz4knsCgpwJ0auba1ZZjqOk2VzMYHRgGrDuP0yXLlB?=
 =?us-ascii?Q?BIr+laOnlaJ7OEWjGG7S+L03IZU5dckDJEh0W+OwhO17KPS5muLoIfDgNX1o?=
 =?us-ascii?Q?ZChaowtfmgnWhFtIHU4dPaNnU7CJq9fQfpRQocL+?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 119f37c2-818e-4964-5bf3-08dc288157e9
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2024 08:38:37.0542
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xcVyTq5+THNg/4uRWDH7b5XBzd3dfpPRIb/RgSq/S2yrut/bQPm0ZixMmcFE8x+NQOXPeKXQUk9qikniCm/4jg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7393
X-OriginatorOrg: intel.com

> From: Liu, Yi L <yi.l.liu@intel.com>
> Sent: Thursday, February 8, 2024 4:23 PM
>=20
> +/*
> + * Flush the relevant caches in nested translation if the domain
> + * also serves as a parent
> + */
> +static void parent_domain_flush(struct dmar_domain *domain,
> +				unsigned long pfn,
> +				unsigned long pages, int ih)
> +{
> +	struct dmar_domain *s1_domain;
> +
> +	spin_lock(&domain->s1_lock);
> +	list_for_each_entry(s1_domain, &domain->s1_domains, s2_link) {
> +		struct iommu_domain_info *info;
> +		unsigned long i;
> +
> +		xa_for_each(&s1_domain->iommu_array, i, info)
> +			__iommu_flush_iotlb_psi(info->iommu, info->did,
> +						pfn, pages, ih);
> +	}

As Jason suggested before this xarray lacks of proper locking.

but given it's rc fix I'm fine with it. @Baolu we do need fix it soon so
this problem won't further expand like here.

Reviewed-by: Kevin Tian <kevin.tian@intel.com>