Received-SPF: pass (google.com: domain of linux-kernel+bounces-57631-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Liu, Yi L" <yi.l.liu@intel.com>, "joro@8bytes.org" <joro@8bytes.org>,
	"jgg@nvidia.com" <jgg@nvidia.com>, "baolu.lu@linux.intel.com"
	<baolu.lu@linux.intel.com>
CC: "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
	"robin.murphy@arm.com" <robin.murphy@arm.com>, "eric.auger@redhat.com"
	<eric.auger@redhat.com>, "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>, "chao.p.peng@linux.intel.com"
	<chao.p.peng@linux.intel.com>, "yi.y.sun@linux.intel.com"
	<yi.y.sun@linux.intel.com>, "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>, "Duan,
 Zhenzhong" <zhenzhong.duan@intel.com>, "joao.m.martins@oracle.com"
	<joao.m.martins@oracle.com>
Subject: RE: [PATCH rc 5/8] iommu/vt-d: Add missing device iotlb flush for
 parent domain
Thread-Topic: [PATCH rc 5/8] iommu/vt-d: Add missing device iotlb flush for
 parent domain
Thread-Index: AQHaWmgTXy/QKp+m406psCSd5N//4bEAIJQQ
Date: Thu, 8 Feb 2024 08:42:25 +0000
Message-ID: <BN9PR11MB5276890E8AE4C552A66CBEB68C442@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20240208082307.15759-1-yi.l.liu@intel.com>
 <20240208082307.15759-6-yi.l.liu@intel.com>
In-Reply-To: <20240208082307.15759-6-yi.l.liu@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qYp4U3Kl8M2uz56XEsHrbsWSXD8JayWiRkIFTmhB8+gRykO0tkYW24FsK9rN?=
 =?us-ascii?Q?f1UUmS3COdXCGJo8JnT2sQH6lyRxsYRhDpDUZIKZBEcPdAIJ4UKDE9k4yv3G?=
 =?us-ascii?Q?CP1ghhVRzbwuEufMeZUs61MA2I0ok7TF7JYhylj+x3Nr3tAwKPtNpzMmnnw6?=
 =?us-ascii?Q?KQ47IyEkkwvc4514WPmr98a/N9F4T5kxAygoirNuKuVqxkYqL2hUci/SXUMO?=
 =?us-ascii?Q?tvLe4jS93sDKMNY9bFV7jNn0PaNtBz1VMblF1Bk55/cXOfoUO3cNK+hSPxcr?=
 =?us-ascii?Q?aLK8zzmt/rTdiN13ZiH4fCLaDMh2ihXTBVlRP6Xjg2Re1y5btyY6WlHpiIRG?=
 =?us-ascii?Q?jvdsyV6H0nNfJjqI7Krz5s3UdZ7VSU9fNTnxeUCZL5dE7bQhKBYoySafcH1L?=
 =?us-ascii?Q?VjS9sXKugYpmbEaIADzAgJWIU4rFFaYTubTg/qD3VdU+KXXoACAjh1SlJ6G1?=
 =?us-ascii?Q?o6fL3lWqbCir69ptx4gMhOePyY31+4SD9/a33pShI0G+iC6wV+pDdNSPdMfr?=
 =?us-ascii?Q?mdr6CtnaxRk3odH075/wyjJPRL2tGFls57B5aLmM3EH5/dZFVh7x+0sKLtLK?=
 =?us-ascii?Q?rPdfpE917WQMYlwOq1IjxVogFSxq7PBx0WjhSUXdDUMQsjJraAgNrPUgM143?=
 =?us-ascii?Q?vFBVJBwVzqPPnMjgRhSmUWjOOoxQC5/fWEvvWosvAKdLHuaDGSTxKyMv5FXV?=
 =?us-ascii?Q?rzhTya61EoEH4UnSyAursw7yXdVUbRiqF9b+9O22Z+3BRo+1uwja7UQ7JedG?=
 =?us-ascii?Q?7/D8gSwOvxpJ6eFYfW970/6aI28CGfqrp/eDZruF/SxzqKWLtxgKCnHX8bY4?=
 =?us-ascii?Q?VyyjOtudlxz98m8/L0lqxDnxHaJ/IornPlc/8F2WzdsoXk2Tmzw5eSbmL4ut?=
 =?us-ascii?Q?iepQmh10B1FRpSrERu6mmX1GJHvOPck9/VUkILb7ytxpB0B6PXzV/RtCBR3w?=
 =?us-ascii?Q?LfmuJLT9k3CtUoaNz1pksqTa3RfIMKAVqlMfmVZsraUYSaoXS1IXUQRQMk3a?=
 =?us-ascii?Q?KRe19FncG4dJOmcUnf1UeAbbtzmx6wZDrr3ib5/5rFyLzC3Mujl02eTbu5ps?=
 =?us-ascii?Q?YXL4ZqlpTpqE3jB5oTupiSdOLUpjyTdMAMUoo4hjqLnbo+tiYb8Guw/IlZ0h?=
 =?us-ascii?Q?a23eRI/lSATD3jzhp0V8hO7KsVLrT0XFQxsMSFA70/RB90uKp0MHCJUsQr4S?=
 =?us-ascii?Q?yWljPHZwwjvSVJSg9g+6dZGlXSeDrgQO+Vq/qtmwMIUaO5evZHxpQT/sxqgE?=
 =?us-ascii?Q?kRzJCO5K3yY6qA7fiBCnIL0S4zHWGryXYa3up8y+osEY0oaKrZWC4z/SjuBA?=
 =?us-ascii?Q?oiyc5sKHK0+CvuHscpmYE8hh2M32AEYBr/O2eJg4zgaAUiBQP0kz4SXbjCPD?=
 =?us-ascii?Q?KNXPhfcjcFCYshv5v80aDViT32C1OxYCQtnVXUZz6PejrGXYVxw7qVp/Gjqe?=
 =?us-ascii?Q?EGQlL4WqkNO2sRPP2BTpyA78ZwxRIhv67abRc3C1oU8zR1pFxiAsto480O2P?=
 =?us-ascii?Q?cbqrY+jBNxBZ6eNgyMYONND4llWYcS/16QMcvc4J2ul1qAKlDBKCL2bbDoL8?=
 =?us-ascii?Q?dCaPHE5DH5D4Sq4DVE2jTYK/bqcZ19LeSerYEHjf?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 48316849-16e8-491a-0f0f-08dc2881dff1
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2024 08:42:25.2349
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: X9tnsXSCduV/x3e1FJk+ZiDXV0w1hXGMOLWIYGegoe8E4fcK+F/FTymDDybN/ZfR6Udtr51BTEiGSew2jvghgQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8255
X-OriginatorOrg: intel.com

> From: Liu, Yi L <yi.l.liu@intel.com>
> Sent: Thursday, February 8, 2024 4:23 PM
>=20
> ATS-capable devices cache the result of nested translation. This result
> relies on the mappings in s2 domain (a.k.a. parent). When there are
> modifications in the s2 domain, the related nested translation caches on
> the device should be flushed. This includes the devices that are attached
> to the s1 domain. However, the existing code ignores this fact to only
> loops its own devices.
>=20
> As there is no easy way to identify the exact set of nested translations
> affected by the change of s2 domain. So, this just flushes the entire
> device iotlb on the device.
>=20
> As above, driver loops the s2 domain's s1_domains list and loops the devi=
ces
> list of each s1_domain to flush the entire device iotlb on the devices.
>=20
> Fixes: b41e38e22539 ("iommu/vt-d: Add nested domain allocation")
> Signed-off-by: Yi Liu <yi.l.liu@intel.com>

Reviewed-by: Kevin Tian <kevin.tian@intel.com>