Received-SPF: pass (google.com: domain of linux-kernel+bounces-57676-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Liu, Yi L" <yi.l.liu@intel.com>, "joro@8bytes.org" <joro@8bytes.org>,
	"jgg@nvidia.com" <jgg@nvidia.com>, "baolu.lu@linux.intel.com"
	<baolu.lu@linux.intel.com>
CC: "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
	"robin.murphy@arm.com" <robin.murphy@arm.com>, "eric.auger@redhat.com"
	<eric.auger@redhat.com>, "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>, "chao.p.peng@linux.intel.com"
	<chao.p.peng@linux.intel.com>, "yi.y.sun@linux.intel.com"
	<yi.y.sun@linux.intel.com>, "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>, "Duan,
 Zhenzhong" <zhenzhong.duan@intel.com>, "joao.m.martins@oracle.com"
	<joao.m.martins@oracle.com>
Subject: RE: [PATCH rc 8/8] iommu/vt-d: Add missing dirty tracking set for
 parent domain
Thread-Topic: [PATCH rc 8/8] iommu/vt-d: Add missing dirty tracking set for
 parent domain
Thread-Index: AQHaWmgW6gj3lexfjk67ec6V2xTDRLEAIuLw
Date: Thu, 8 Feb 2024 08:53:31 +0000
Message-ID: <BN9PR11MB52761895C4DB8861C32A4B698C442@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20240208082307.15759-1-yi.l.liu@intel.com>
 <20240208082307.15759-9-yi.l.liu@intel.com>
In-Reply-To: <20240208082307.15759-9-yi.l.liu@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?t90KOK2St9FMEhvwAl69D0Zumn+xj4qkiYbmpwB00AnY0ZA9cpOOk9rXR+Jq?=
 =?us-ascii?Q?xn/8ci0x9iQaySV97nHU9Gy40jBhD9/PiQwepR5mGwdaPMHAbwfgfsEuGZ4+?=
 =?us-ascii?Q?vI0zMTp7Ok4WMMoKqZW78PykYUFv6Tz8pECqFzhLqfcBgDbIfc4mRWMJRMf+?=
 =?us-ascii?Q?jE89Q9snafZjwvrU6p5jf7z1uZDKfsQWc2xQIKYT82xMHEnbNvfQBsNT7o3M?=
 =?us-ascii?Q?uiMYa4Pu5nOKQU8CnRPPsACYo9b/H/A6XsQuLtekLyA8FnllJ1K2LCqOdftC?=
 =?us-ascii?Q?Ush5TeemRP5LOIKCb/hZDomxhuvLRAnGeF1XculqbSZFNRVBdMNPBfQoMf2d?=
 =?us-ascii?Q?XOiKIzHJtkxsTpfA9OMA0B92h8pqdDKnbqb8eZgHn/vMJpq6/ZiiVIxoS5m+?=
 =?us-ascii?Q?eEQlk3qyCs8lR9RGwz8sxDrfuOlEz3sfxC24xHfS4QMthha2AlmzNRaWTFZJ?=
 =?us-ascii?Q?FRGKJu5GoUm6vEFSLjOZ0uqWgA+oiqRKKQ+FOpvfZxR1zsn4Wd+/AZ7NB3/a?=
 =?us-ascii?Q?cvsLR6gWPxjA/jTL1gmc+pjGBkaW9jQPkZ34kPF101x3iow+aSszw/9PgZ3o?=
 =?us-ascii?Q?HX4cvJFcDb9ZtFR615AK66XRT+FFq2PncOAyewhmlZPXbugYgwwo7BQgC0FV?=
 =?us-ascii?Q?EbrxUkF7onL3jII++VidGtZBUsX0yR11V93/W53Y7ikHHF+f7Eki3tydXbBf?=
 =?us-ascii?Q?Y6MrpFG6fTC4m9F55MAakYko54GJa1UlDwZlgyjEEkx9oT7V4pRBIG0lCUtx?=
 =?us-ascii?Q?LhCu8dWCvtZWVg/lRdm0HeXaN2gCV8xjbxH0yWp5WxPxI+NmazfPub/Ycwzg?=
 =?us-ascii?Q?JBp94pqYNmZZjdQqYM/ms1rNxkAU+vEZE7ahU2By9FrVASqa3ovLUghK5mqt?=
 =?us-ascii?Q?F+64lCfnY1xcOaHh9yup4/Thr9p2WELXIq1wQ/RDEE0touTf8GOBPCVeKmzN?=
 =?us-ascii?Q?XeqT9R9M0H65NWc963AgXjD+nz0qWCC3rVcVINDtgi9JK35KPg6NTzmAqMag?=
 =?us-ascii?Q?AgOrp/jz3RjPwd2Ylo9sMuYf4I9LSNpSiHHP7UCWSQ4fusqQUBwroEPOf5Ae?=
 =?us-ascii?Q?VAxaPSPKrvVoWK4Ue3pPIs/ad8GD/4tar6hHPTUGEPAu+PLkQHKbPiu4u3c9?=
 =?us-ascii?Q?SfKQ4SsRuR8SkFx5AYRgb31EeocQ/gJ6gMZinBEgi1BTIzTddOX0l1QagE5a?=
 =?us-ascii?Q?jhVndI6wWx8DxrqzFqXsd3uklqFWbnCLt07q+2/GMD3txgmmVEaIIpVMbM4x?=
 =?us-ascii?Q?jel7tyaCmvpsE+no75RKUyZLrn8o9FYrQfLgTfvHaYw4t84Ftzf1+tZkpyPx?=
 =?us-ascii?Q?siuaA+Hw2OyL1vYZvBMxjclEtrf+P44ebnmrYXclH3sSQ6IJkto5TEtixJJq?=
 =?us-ascii?Q?0/WUa4k2hWpgrgDm4lJa+09K3M1x7F8TGulnbLXXZUURm5xyZOwJL5/Oeuck?=
 =?us-ascii?Q?1ST3ZLFIA4fziLCcjqkadFpLmnSYHkK4mhmeRe3ivfTR/Mqn6QXo9EOQhFNS?=
 =?us-ascii?Q?yXCYc1sBg2Jv0hAiws8+V0kmoLZAIrBgWukLPyDTz22SnvgvjyUx1Jj5vSEX?=
 =?us-ascii?Q?NVzx92VoGef2lVoTmpKH7bIzjd1ugb4oyE+CgIYI?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c8d14cc9-e772-4033-f95f-08dc28836d18
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2024 08:53:31.5329
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: BhTTWyc5t1M8i8Wd2lD83qpLrBzhPVwEVSNON390TpZtX0zfmPKj8jFZQjA/agEmHCapjbgsY40a27tZRaXzlQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5513
X-OriginatorOrg: intel.com

> From: Liu, Yi L <yi.l.liu@intel.com>
> Sent: Thursday, February 8, 2024 4:23 PM
>=20
> @@ -4760,6 +4790,12 @@ static int intel_iommu_set_dirty_tracking(struct
> iommu_domain *domain,
>  	if (ret)
>  		goto err_unwind;
>=20
> +	if (dmar_domain->nested_parent) {
> +		ret =3D parent_domain_set_dirty_tracking(dmar_domain,
> enable);
> +		if (ret)
> +			goto err_unwind;
> +	}
> +

there also lack of setting dirty tracking when a device is attached to the
nested domain while the parent already has dirty-tracking enabled.

but looks even w/o nesting this is missed in the attach path.

could be fixed separately. so for this one:

Reviewed-by: Kevin Tian <kevin.tian@intel.com>