Received-SPF: pass (google.com: domain of linux-kernel+bounces-57712-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <ba25e0b1-fd7f-4813-924d-b116a88dbb5d@intel.com>
Date: Thu, 8 Feb 2024 17:23:06 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH rc 1/8] iommu/vt-d: Track nested domains in parent
Content-Language: en-US
To: "Tian, Kevin" <kevin.tian@intel.com>, "joro@8bytes.org" <joro@8bytes.org>,
	"jgg@nvidia.com" <jgg@nvidia.com>, "baolu.lu@linux.intel.com"
	<baolu.lu@linux.intel.com>
CC: "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
	"robin.murphy@arm.com" <robin.murphy@arm.com>, "eric.auger@redhat.com"
	<eric.auger@redhat.com>, "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>, "chao.p.peng@linux.intel.com"
	<chao.p.peng@linux.intel.com>, "yi.y.sun@linux.intel.com"
	<yi.y.sun@linux.intel.com>, "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>, "Duan,
 Zhenzhong" <zhenzhong.duan@intel.com>, "joao.m.martins@oracle.com"
	<joao.m.martins@oracle.com>
References: <20240208082307.15759-1-yi.l.liu@intel.com>
 <20240208082307.15759-2-yi.l.liu@intel.com>
 <BN9PR11MB5276FA50EE70CAA0DDB758578C442@BN9PR11MB5276.namprd11.prod.outlook.com>
From: Yi Liu <yi.l.liu@intel.com>
In-Reply-To: <BN9PR11MB5276FA50EE70CAA0DDB758578C442@BN9PR11MB5276.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WlZ1cnNFTURRVlc1dElNYkhNR2ZmRHVqNHowUGZ0US9DV1c5ckw0ZU51OGZK?=
 =?utf-8?B?RlQ3alMzb1p4bTFIRDkwMWo4cElVb2lDMUZqQnF1ZS9TRWh3cFpQS0tJaXhN?=
 =?utf-8?B?aFZNcHRuNzhvRkJKVDIyeWUweEVFWGdyV3loVldhS29rZjNRM0pld1lLY1h5?=
 =?utf-8?B?SmErWitoaHBQaFFwanVKR085SEdkWGVkbXlqYm9XakZuZ28vbktaRUNsTVkv?=
 =?utf-8?B?RFJKbGN5dkVhbjU2Uy9NbEFKK0sxVllreGI4eFBaaGVEVFRBNndZTGhMZjc0?=
 =?utf-8?B?VFgyNGd5M2tjckpGOSs4dC9jcWJQSnVNa28yTUM0ZVRzZzNjb0hjYWY3YjZ3?=
 =?utf-8?B?NjdKZnZvNWhmMGh5M0F4Rmw0SjlOYjlqQUNjd1dpSEZUcEhXeWhLUVpKeUhT?=
 =?utf-8?B?L2VBc3Q3cWswbExHMVNIZ1lzOWFTNTJmcytOTlRCbDFqaE5hVHZ6M1pEZEZ5?=
 =?utf-8?B?Mm5SY2RYR1ZRNnhIN1dvbUJpckdPV1ljUFNEMlQ1cTd2VTA5SDlzUnFTZVdB?=
 =?utf-8?B?dDcwM0t3ZTR5OXMvWVpzL0JqdFY0cVRkaW92R2J6RlRKQWY4ZTVPYStLVWxJ?=
 =?utf-8?B?Nlk1aEFPTTBZcVhGb2twZEx1ZWZkamt3Z3Mvcmd3cVprTDZhMHZrWGdZUXVY?=
 =?utf-8?B?V0YwYzdtL3VMSU5iSWpoRlUwTTV1UlVIMHlyNWk4cEU4R08vYUVtMTZkdXRV?=
 =?utf-8?B?OWx0RTBEdWdodjd5Qk5RMXUwbjJ1ZDVzN2hHQWFXRnFvK1dGb0EzMkVPeHBF?=
 =?utf-8?B?ajlVOGxmTlYxMEoyVDFUU09NQzlWeXJQZVBsZjRla3ZvVGZURXFNcGJJWXBB?=
 =?utf-8?B?YXFZcFhXSFdPUmRubVpnWjhaQUp0TW5PUkFUbHdJWGhFa3Vrci9wQjRKcVRu?=
 =?utf-8?B?T2pybXFKVkY5VTVSUTBHNXdyNVhFZFlnQ1RBaWFFWjFHM1pFUUdCVy9RbkVy?=
 =?utf-8?B?TU00OGZUYzgvY0FzWkRlUWxUeVFsOVQ2WHQ2czAvdFhnSS9JSlpzTFVNcWlY?=
 =?utf-8?B?ZG5qSmRWeTcreXhkd1orcmNxQ2kyejdzYmZiNlZlU05qT09icE5hTm9KYThm?=
 =?utf-8?B?TkhUYjVMckMyREtvUWVLRDNBZ053TlJ3bUlRWE1seWhldVpZM250UmpjaTJ0?=
 =?utf-8?B?WFNIaExtcHVDSmo5eGZ0M0UvdlJUWXFzK0kyenY3b3Y3aUV0dkI1cVJtQ3JY?=
 =?utf-8?B?cU1wd3ZlYU4weU1tdEZ1Z1RHVUx4d3d5cEJ0YmNBOUUrMnVseWFEdFhURHFR?=
 =?utf-8?B?b0pIVjVsREZEK0Fyb0RGdGpFVUM1YTBIajlqSER5VnhzTERXSEpKQ0hsR1lS?=
 =?utf-8?B?enVZTExRSzBsTHk5dDFIRldlWHE1RU5mL0tMSUNWNU1qd0hCbHhzODNzdVFQ?=
 =?utf-8?B?NE5pNERpVVFPTlNxdDNITjQ1V2lnSzB6aVd0TWttUUVlZVQ0WXpRSXNJdTVj?=
 =?utf-8?B?ZkZXVFJ3MEZ3NjlnMjFXVVA4QStrQ2hvY2dnM2ZrQ0RmWU1NYVpOOWFaNXE2?=
 =?utf-8?B?TUliVXpualRWeXhheXkxSFFhc2tlN0RBNG9KcHdPTE9WQ0h6UXRuT3cyblpt?=
 =?utf-8?B?cmkwS1hsT29xSDB2aFJQZE5rTXEyNjU1aTRRNW9LUWxFc0orZzBJTENIOHV0?=
 =?utf-8?B?aGI2ellxaDJUQjJnaXptd2R6d1Z3Qkw5cThrWkFqWmtEekQ2VzE0dE1KNHRz?=
 =?utf-8?B?SWtPMkMvSzErWlZVRDJJOXhMQlRISlFjelBicHVqNTJzdytoTlprRkJSa0Zs?=
 =?utf-8?B?UWx4VnAwZnVOWGVWYzlXVFVlTFRmMDEwSlk4TEVCSjBTNUI2elRwYXZtVUFw?=
 =?utf-8?B?MWVPd0NqTjRqTnc3WmVEazRNTUJLaGZHd3kvWWU0RWpEUHBCUUhqNWdESDF0?=
 =?utf-8?B?NFozUXdrdk9hcEd5RjB0ZGRvOWk5N0tSRTJGbzVWMnBBWnljT2tYWnVjbk9L?=
 =?utf-8?B?dk02SnFQZ21rc3Z2eU1FcFRIcE5CeDUrWTFVZG42TXJ2YWRVVUtLdDVXMDRj?=
 =?utf-8?B?bHR1N1lFc0NOUXlsQ0tiaTVvUmRGdmZHSTJHU3MyRko4T3ZPT2YzVktTOHZo?=
 =?utf-8?B?UVhwVXpkQmZBZ0o4NWZtQWlrSlpYeU1lbXJjT0lCR0puWnhjeHdEVW8rUEps?=
 =?utf-8?Q?crgoISDcUl4dpm91iQVkvzYsM?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b731559b-ee62-48d1-86f5-08dc28871f72
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7529.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2024 09:19:59.6139
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2NUT5g6P4Yk+bXwlf9rvJYBg9wqXPIPrH+Fr06pj1WMDdoZvyWbkTq2ojM6I6jK/k/aD8zKHMfIOIR/hYYyKVg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6307
X-OriginatorOrg: intel.com


On 2024/2/8 16:28, Tian, Kevin wrote:
>> From: Liu, Yi L <yi.l.liu@intel.com>
>> Sent: Thursday, February 8, 2024 4:23 PM
>>
>>   static void intel_nested_domain_free(struct iommu_domain *domain)
>>   {
>> +	struct dmar_domain *dmar_domain = to_dmar_domain(domain);
>> +	struct dmar_domain *s2_domain = dmar_domain->s2_domain;
>> +
>> +	spin_lock(&s2_domain->s1_lock);
>> +	list_del(&dmar_domain->s2_link);
>> +	spin_unlock(&s2_domain->s1_lock);
>>   	kfree(to_dmar_domain(domain));
> 
> use 'dmar_domain'.

Oops. yes it is.

> Reviewed-by: Kevin Tian <kevin.tian@intel.com>

-- 
Regards,
Yi Liu