Received-SPF: pass (google.com: domain of linux-kernel+bounces-57715-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <defdccc8-449d-42a7-aee6-8ac212a777ba@intel.com>
Date: Thu, 8 Feb 2024 17:23:59 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH rc 8/8] iommu/vt-d: Add missing dirty tracking set for
 parent domain
Content-Language: en-US
To: "Tian, Kevin" <kevin.tian@intel.com>, "joro@8bytes.org" <joro@8bytes.org>,
	"jgg@nvidia.com" <jgg@nvidia.com>, "baolu.lu@linux.intel.com"
	<baolu.lu@linux.intel.com>
CC: "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
	"robin.murphy@arm.com" <robin.murphy@arm.com>, "eric.auger@redhat.com"
	<eric.auger@redhat.com>, "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>, "chao.p.peng@linux.intel.com"
	<chao.p.peng@linux.intel.com>, "yi.y.sun@linux.intel.com"
	<yi.y.sun@linux.intel.com>, "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>, "Duan,
 Zhenzhong" <zhenzhong.duan@intel.com>, "joao.m.martins@oracle.com"
	<joao.m.martins@oracle.com>
References: <20240208082307.15759-1-yi.l.liu@intel.com>
 <20240208082307.15759-9-yi.l.liu@intel.com>
 <BN9PR11MB52761895C4DB8861C32A4B698C442@BN9PR11MB5276.namprd11.prod.outlook.com>
From: Yi Liu <yi.l.liu@intel.com>
In-Reply-To: <BN9PR11MB52761895C4DB8861C32A4B698C442@BN9PR11MB5276.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ejVNN0twMjlYdWttYW9WZjl5WHp6YTBuSUlaU3BwNXNGbDhlYzFWekgvUDRD?=
 =?utf-8?B?N2ZxSzJpTXZqeWZOTTl1SCtUZTZxRUFzNHpuM3dZckZOSVlwRjBoZmxpOGFs?=
 =?utf-8?B?bmw4MUhaV0luUS9pMmJjQ21LMUpERmdIZTl1Y0d4bmZCNUFMUWtPVFBKSC9Y?=
 =?utf-8?B?ZjlESHVKNWVodTdWaDdxQUF3aUJmTkZaYUgyVWQyM1dKMjZubG1UNGJpSktv?=
 =?utf-8?B?OVNaN3lHNmVzYW9POXBwaVZ3Y0kxTlc3ZkF5OVZYcytmeEpEWjhpSGk4Y1hU?=
 =?utf-8?B?NE43UjhtTWVrUXhaV2xpYzlzbGNRR1dyYktBd0JCVU1hWldiVGxMejYzWnVq?=
 =?utf-8?B?cXQ3ckJMeXdOaVZ3R3l4MTRIODZaSTg4UzFPUENtQkg4SXRnVFBxcStvbm1j?=
 =?utf-8?B?L3BrSGhLL3pQVk1ic3NQU1BzeDBRSW1uR2FGUHFOQXlhb1FPOVZvU1dMUHp4?=
 =?utf-8?B?d1ZqWTFrN2FORVFKZHBtTjFQM1pVbnI1VkNQRFdMdDMzSzJqR3A1UUhpQlU1?=
 =?utf-8?B?Ulp4QS82UlRONXdzL2ltOTdYOFUzSnplS1dpNmFRSXFhMHlieFptUjJBRDFE?=
 =?utf-8?B?RGFCL0UwVzhFdEpYNitBdFU4T3JSZ0VPMHY1eWNUSzBiWkNNZFA1SlFueTBZ?=
 =?utf-8?B?OS9MWWE0alBVNEJPaGpHenJmcU5kYlYrWk5iY3JtS3dFaW5ITFRRQkk0bkFl?=
 =?utf-8?B?RFh6dVc0Q1NiVENuTzEvQUdMSzdyR1dDMXRpeGZJNEU1TFZiNXhuNnFhNzZz?=
 =?utf-8?B?NGNsZ3hpY1BNYlZOODdSS01OWkgrR0lMUElZOWMvRmdMekU4eTZEdVkrTDJO?=
 =?utf-8?B?UDJyeXFGQ0c0RGJhT0RQODlvV1ZJQi93Kyt3RERVUVI0TFloWVhGc3VrdVJI?=
 =?utf-8?B?bkMyeFJ0cldyajJLcHd4RjB4UkxjcXV4K0VRMFZkUXhzWGlMaGt1R0paYWRj?=
 =?utf-8?B?M3A1SmdnWnMyZEdYSW1kWUNuZUVxeEMwS2N2ak1OY1hrTGJnMVNVVTNNdGY5?=
 =?utf-8?B?WUI4eVVPSThPUldhM2R5V1dUdndCQmVjTU5yYmgzTTMreUV2S2hvUDNFZ0pD?=
 =?utf-8?B?VlVQNi9idUlRTW1WUForVGVKbjZJdmhXNFNqVWNNZzVXN1VLbG8xSDhEQlhZ?=
 =?utf-8?B?dlNEdGtZMDRkR2pqVmxsbUg3UmxSeVMrYWdRUUZZMHdmSDN5a2hueW1NbnFY?=
 =?utf-8?B?N2JMSTBQWVNPbXZuMUVReGNTcXBLWlhBQ1hyaDBuay92TkdVMHpQdE5VczZ2?=
 =?utf-8?B?NStGTlpmUXJEU3lEWHhSdE1kcjlnMGYxWTdENm4vOWlmWTExR1NMeDhtaHZU?=
 =?utf-8?B?UjJwK2ZwTHQ0ZVpVNm91TFMxLytMMEt2Q0JNOHZiMjN2Y1doUVZ0dm5kNStD?=
 =?utf-8?B?Y2J3WFVNQllmd1liWjVqa1EwcUpxRG9JTEQ3MWs4YitrTFV0MTQzSm5CR2Zt?=
 =?utf-8?B?VStsZHZUSjQyUWk1azJxMFRHc29sWHdyUFdmZHRqaTJ4QnhueDFXbWdTcTdE?=
 =?utf-8?B?M1ZkQkYrcFdLTUdvb25OZnhqekZzR1lMY3hSSGpXM080aDZ1ZnBhcHprZXgv?=
 =?utf-8?B?d2E2ODZMWjNmay81bE9xMXpBSzhqTm9JRFNsa0tmczEvbFd0cENxM1JiUmFV?=
 =?utf-8?B?ZkpVK2JPSlJBdUsvQXVwNUJZSTJMcHlYbk4yalB0MlZOblhqaGJsejVaOEM0?=
 =?utf-8?B?N3MwZDJJN1Z6YTU0VDFaaUJqS29uZ2VGVWE1WVk5czFNVGtiaFVkNHlXTzMv?=
 =?utf-8?B?cUZkZ3NMUjg2OUtMWFJmOERxQjdKKy9pQ0xMZHRQTTZlYVFNalBTTTg4eDVp?=
 =?utf-8?B?eUlUQkdpZ0JIcXZRaWVGWFczK2FMVmx6WkEwNFhiOTkrajM2K0NJUzBmalhX?=
 =?utf-8?B?YTdUNkdKc3haaUdiLzRTSVBpWnc4RjRtcE5wNlNkbUpMQW9lOStJbHJXUi9L?=
 =?utf-8?B?WHVoalNybElLR2lqbDhvSUxpczRqM25UU1NUdGl4YUk5OVA0cFFtbm1GMDlw?=
 =?utf-8?B?WW9OT1l0MFZudVVSQlN6RndEa3JRNEZnYTV1K1FydkdhcktOUjBodUNRZ3ZS?=
 =?utf-8?B?NnM5WXQ5Y1JLaUZvY3p3YWNlWGptSTR3Z1FUMWFvQXpyQ3lidjVnV2UwNkY2?=
 =?utf-8?Q?CA7qqHuGb1OX+k6FGqAvwSfS4?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1126a100-1f15-4012-6a16-08dc28873d67
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7529.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2024 09:20:49.8558
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ufwvDpvpZ/yF1qBblTLEOOy58dz0G6SQBKJWEuZdR0aL6QFHtUBwQsX2lwLu2uKzZIXgWMl+67cHmvlI3G2ngQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6307
X-OriginatorOrg: intel.com

On 2024/2/8 16:53, Tian, Kevin wrote:
>> From: Liu, Yi L <yi.l.liu@intel.com>
>> Sent: Thursday, February 8, 2024 4:23 PM
>>
>> @@ -4760,6 +4790,12 @@ static int intel_iommu_set_dirty_tracking(struct
>> iommu_domain *domain,
>>   	if (ret)
>>   		goto err_unwind;
>>
>> +	if (dmar_domain->nested_parent) {
>> +		ret = parent_domain_set_dirty_tracking(dmar_domain,
>> enable);
>> +		if (ret)
>> +			goto err_unwind;
>> +	}
>> +
> 
> there also lack of setting dirty tracking when a device is attached to the
> nested domain while the parent already has dirty-tracking enabled.
> 
> but looks even w/o nesting this is missed in the attach path.
> 
> could be fixed separately. so for this one:

it's fixed here. 
https://lore.kernel.org/linux-iommu/20240208091414.28133-1-yi.l.liu@intel.com/

> Reviewed-by: Kevin Tian <kevin.tian@intel.com>

-- 
Regards,
Yi Liu