Received-SPF: pass (google.com: domain of linux-kernel+bounces-57863-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <63070cc2-3dee-4da8-a76d-0e4a54eafff5@oracle.com>
Date: Thu, 8 Feb 2024 10:29:09 +0000
Subject: Re: [PATCH rc 7/8] iommu/vt-d: Wrap the dirty tracking loop to be a
 helper
Content-Language: en-US
To: Yi Liu <yi.l.liu@intel.com>, joro@8bytes.org, jgg@nvidia.com,
        kevin.tian@intel.com, baolu.lu@linux.intel.com
Cc: alex.williamson@redhat.com, robin.murphy@arm.com, eric.auger@redhat.com,
        nicolinc@nvidia.com, kvm@vger.kernel.org, chao.p.peng@linux.intel.com,
        yi.y.sun@linux.intel.com, iommu@lists.linux.dev,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        zhenzhong.duan@intel.com
References: <20240208082307.15759-1-yi.l.liu@intel.com>
 <20240208082307.15759-8-yi.l.liu@intel.com>
From: Joao Martins <joao.m.martins@oracle.com>
In-Reply-To: <20240208082307.15759-8-yi.l.liu@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?OHBnV2JPa3FwT3RiMTB3NmZURFBiSDdyTFQ5Z3ZJTTlaZEZTMndIMjQrRGpR?=
 =?utf-8?B?dkNHRnpXU3dvOCt3L0pJOWo0dmVVNUovQ21jUWJqOGFLSkVMeTIwNFdkTWVF?=
 =?utf-8?B?NnBBRFVDenhoSXYrWng4YjZZRjlzclcvUDVtZUl5UmtIbUw4bnVYT2NWZmli?=
 =?utf-8?B?eW5RL1RVOTg2emN2V2tMS0lQeGtBUk9VcVU4dkw0V3hCM1FQWkZKQVQ1Ulp4?=
 =?utf-8?B?WGJmcVNkYUFxSnZtbkp0aDJOKzQ5N284bFRCbWJ5YXVreTRlSWwvblJaQXFR?=
 =?utf-8?B?SGtzTkNtb1BKdkFxUll4bGJnWndtVmE5Y2hFU0ExRkxwTmhNYU5YdEh1Rlho?=
 =?utf-8?B?ck1lU3c4R0pwSlBmdVVmRUMyUXFMWVMyYmRRR1RmeTJmL1g3c2p4SElBQk9p?=
 =?utf-8?B?dUpUWXF4SFZDNDFQSXVQaFduR3BHL2YwaFR2aVRYMGt0akMrczhhSzBBMEk0?=
 =?utf-8?B?VWRlZXlKcnZZNzR0ZVhiYS9iRUxkZnVPVm9ta1V3VE1HTk4zbkFEUmdRbTFV?=
 =?utf-8?B?cE1CTWtZM211NTVybk8rYzU5UENSMlpwaVcvWDZ5clQ0Y1BBOEtadXdxZVdp?=
 =?utf-8?B?VFNkYUZtRk1HbW51ZC9Ka1Fyb00ycG9hWkUxT0dIR0lGZ1NTa09kYmVyWHJt?=
 =?utf-8?B?U2JEakdMY3FRVkJ1WVJPRFZWWkNQeEZCai9RVWNVWUl4dlB3TFhmRktTUzJN?=
 =?utf-8?B?dEZyNXpqa21JU3VWM0NOTmxhdHd3YzRxT3BDa1R4L0N4T2UyV1V3a0lEUHVl?=
 =?utf-8?B?cnViRWI3cjV2ZlJwYW1GL0swRW5WN3JYbDBzU0V5ZVoyYUN2VUhkVS9PWkJB?=
 =?utf-8?B?eDU2cU9jK3lnZ1dOUTBBTkFLMGpjVkxDNnlKZ2tIbUwxUWpiYXlxQm4wbDM5?=
 =?utf-8?B?U2ZQZVQyRjFrcXF4aVYrRVlXSHU1ZkNnemE5aHRvcDliQkxkTlVJbk44R2wr?=
 =?utf-8?B?MG1HSGpXODAyb2o2QTIvNkpTUkVaS1BlQkFkWFFlSnV3eTkrbkJOanNQSzJk?=
 =?utf-8?B?K0p2bDYxNVhLQUlzdHVrenJnenk1MlhYb2x1aS9kU2dhWmRqdFNPS3BsVEl1?=
 =?utf-8?B?UVpwU2ZNaDJ3dnhKU1h3Z243R0J5WUxWYTBNMzZoQkJHMHdrQ1pWRGRHQmxj?=
 =?utf-8?B?QmlWT2RuMThabjRzZkdQY1RIRXhUVXlieDk5SWk5azRvZXBWR05qQTdyOGNM?=
 =?utf-8?B?dzJXVVJtekNqaGVtaWNDYXdkeVJ2WktuU2g4eU91eFk2clI4YXhXSHh2SGNL?=
 =?utf-8?B?VzRXZ0hodTRRZEVleWg3SElpLzNlNXYyVGFmS09iWVRIcTJiejUrelBsRDNr?=
 =?utf-8?B?dGUzWnBsSE9CRUNLTE02MnhZZVFzcHM4WWd4WU1VTmxEa1IvNjAxekJlU2lu?=
 =?utf-8?B?Y0FVWUtVOFNPbmo5TEhaQjViMjdrUjAxVXk5NG1rdktIcjRVaXVXNWFlOFY5?=
 =?utf-8?B?WSs2QUxlamdlZjRqb2Q2dlEydmZOQXVKRm8rRWhOVVJsbTZFODJmY2p0TEVu?=
 =?utf-8?B?Wk4vY3hUbEZuZ01qcDFwZWdOdW1JRmp5dUFkOEFadHY3Y0JQLzhkMS9GNjNr?=
 =?utf-8?B?RDV5TmNtcC9pY0xKVTlwbXhoTHBSaktwa1M2M1hrT3NGb3FsRmxyQ2FtY1pw?=
 =?utf-8?B?SFhhcVZoL0NnU0VCa3AvLzZXQ2s2blFUSS9scERjdE53U251V3RNOWRienFw?=
 =?utf-8?B?TEZPT2RBSUJwTVU5M3RHWEFNTTFrK05DMklNaE1DY2pnZGRMK0xraUNVbGZl?=
 =?utf-8?B?K3Z0Vy83aCtjWmFDME1oT0NtNHoycjN5RTJqUWRXQ2tJSlZlc0I5VDl3Q2t5?=
 =?utf-8?B?Q2JmUG84NDJVMWtUNURPT3pxcmQrWEwwd0NxdSs4ZjZaN0V2Y202SFVENUtD?=
 =?utf-8?B?OWd6WWZoUENmSjJTS1BYZEFENlYwc3dHR3cxbjNsV21WT0xxMTExdUdVdG9q?=
 =?utf-8?B?dzFqWWlTUjdOelBVSUNacEhTcTdoOGxQdGhrUEVjM3RNMU9LWFFvMWs5SFMv?=
 =?utf-8?B?K3BMY0NPVk81NytMenh3akdjdzF6SzBNSmJaYloyZjdnN2pRdmhmQ3dxd3lQ?=
 =?utf-8?B?MDhONXlvZTJ6WHpaRW8rNEhjR1VFc0sxSDNjY2hCVGZZUlB4dGxQTHJRdTgz?=
 =?utf-8?B?Ni9zSTV6NWxGYzFVU05lcWo5cEJzTFYxeVJxT0VVaHNUQVBYQnFJMnZHZFBL?=
 =?utf-8?B?Znc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	9nf9LO0iU4jjsZ11XJ0itv+rvx3dTl1ZL3lQN3gEyWJEdeCrvAC2/PYzn6WgN4uyKR8h0VzdBr2MrpcxDji0T48638uJwYj3fpY8WEhWn5UjpM77M8L7eXtNLZm0GvmefhpAL3Oacn/xPMmSy5s3i4V6fUdjFSW4EnFiJQT+wEbWYYOqQ6ieiwAhZ9cqpU9GIRp1AGxUOv6OBRmZmk/j7QALqikyFypDOe/tmsjsU5wVeHY7q7t3IJ58ZjrAcn7caBrkNdwme6H1pPTFwuw1Jjqp51huSQZlu3X+LMfaVnB2+skeSqkRjV2xkkZAOANkrlz9Ekw5gzK14kTmmsJXerbCnrzBRpCjo9d+bMYr4psRxYMECNYK1H0v7ty5QWvGdaPTkFNsss5WqFou2+tDpHaifIHunDJkfZ2+qsLiGDvEYajrYDrspLC241/aiUpSqjmpoLjwxM7NEfYOZLlCM76TXSC2f215oveZs5SGJlysH4Is3o1ARciyD07HPj7ZDkSSp2dHf+GygQ09sW0KAWlwPfu0vWxJf2LtkHwWCWm7R2MKjc7/zJU1RH5K+Tr8y1jOp6nmavmyHr1eyI0YBPoAtWn66WBiBGWvPQAZSm0=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5ee1e054-8af2-4fdb-60b3-08dc2890ccee
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB5893.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2024 10:29:16.1155
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OgeEQXMqjJ2HavtxDZet2EVexlBVy5DJXXNVO2xxk1m73jdWOyfo1V5OErbnWFeVX0PQUf53ky/uwI6EOmguUyAnnWVZtM4oeGrK82Z3b7E=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4260
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-08_01,2024-02-07_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 phishscore=0
 spamscore=0 adultscore=0 mlxlogscore=999 malwarescore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402080054
X-Proofpoint-ORIG-GUID: 7-Rs0bO3VnMPvCEbltbpOIgj11KfNs4e
X-Proofpoint-GUID: 7-Rs0bO3VnMPvCEbltbpOIgj11KfNs4e

On 08/02/2024 08:23, Yi Liu wrote:
> Add device_set_dirty_tracking() to loop all the devices and set the dirty
> tracking per the @enable parameter.
> 
> Signed-off-by: Yi Liu <yi.l.liu@intel.com>

Nice cleanup,

Reviewed-by: Joao Martins <joao.m.martins@oracle.com>

> ---
>  drivers/iommu/intel/iommu.c | 32 +++++++++++++++++++++-----------
>  1 file changed, 21 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
> index dae20991e036..7636d3f03905 100644
> --- a/drivers/iommu/intel/iommu.c
> +++ b/drivers/iommu/intel/iommu.c
> @@ -4730,23 +4730,35 @@ static void *intel_iommu_hw_info(struct device *dev, u32 *length, u32 *type)
>  	return vtd;
>  }
>  
> +static int
> +device_set_dirty_tracking(struct list_head *devices, bool enable)
> +{
> +	struct device_domain_info *info;
> +	int ret = 0;
> +
> +	list_for_each_entry(info, devices, link) {
> +		ret = intel_pasid_setup_dirty_tracking(info->iommu, info->dev,
> +						       IOMMU_NO_PASID, enable);
> +		if (ret)
> +			break;
> +	}
> +
> +	return ret;
> +}
> +
>  static int intel_iommu_set_dirty_tracking(struct iommu_domain *domain,
>  					  bool enable)
>  {
>  	struct dmar_domain *dmar_domain = to_dmar_domain(domain);
> -	struct device_domain_info *info;
>  	int ret;
>  
>  	spin_lock(&dmar_domain->lock);
>  	if (dmar_domain->dirty_tracking == enable)
>  		goto out_unlock;
>  
> -	list_for_each_entry(info, &dmar_domain->devices, link) {
> -		ret = intel_pasid_setup_dirty_tracking(info->iommu, info->dev,
> -						       IOMMU_NO_PASID, enable);
> -		if (ret)
> -			goto err_unwind;
> -	}
> +	ret = device_set_dirty_tracking(&dmar_domain->devices, enable);
> +	if (ret)
> +		goto err_unwind;
>  
>  	dmar_domain->dirty_tracking = enable;
>  out_unlock:
> @@ -4755,10 +4767,8 @@ static int intel_iommu_set_dirty_tracking(struct iommu_domain *domain,
>  	return 0;
>  
>  err_unwind:
> -	list_for_each_entry(info, &dmar_domain->devices, link)
> -		intel_pasid_setup_dirty_tracking(info->iommu, info->dev,
> -						 IOMMU_NO_PASID,
> -						 dmar_domain->dirty_tracking);
> +	device_set_dirty_tracking(&dmar_domain->devices,
> +				  dmar_domain->dirty_tracking);
>  	spin_unlock(&dmar_domain->lock);
>  	return ret;
>  }