Received-SPF: pass (google.com: domain of linux-kernel+bounces-57867-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <a945cd6c-7737-4d66-a319-613e1dbc3798@oracle.com>
Date: Thu, 8 Feb 2024 10:31:36 +0000
Subject: Re: [PATCH] iommu/vt-d: Set SSADE when attaching to a parent with
 dirty tracking
Content-Language: en-US
To: Yi Liu <yi.l.liu@intel.com>
Cc: alex.williamson@redhat.com, robin.murphy@arm.com, eric.auger@redhat.com,
        nicolinc@nvidia.com, kvm@vger.kernel.org, chao.p.peng@linux.intel.com,
        yi.y.sun@linux.intel.com, iommu@lists.linux.dev,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        zhenzhong.duan@intel.com, jgg@nvidia.com, joro@8bytes.org,
        kevin.tian@intel.com, baolu.lu@linux.intel.com
References: <20240208091414.28133-1-yi.l.liu@intel.com>
From: Joao Martins <joao.m.martins@oracle.com>
In-Reply-To: <20240208091414.28133-1-yi.l.liu@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?SVdxRUNGK3I3bDEreWVlaldlR0JkbVh6SFdPa29ublp6N0hOUWhUNXlUaEFE?=
 =?utf-8?B?WGEzTXJOcTdHbGFtNlF3SVYyNzFTY1dFNHdraGFDSXE5YWhYL3ZqV3F5VDJG?=
 =?utf-8?B?OGMxSWFnTXczNVNtWVRuYndnSVN0QkxFV1BCMlNtMmFMeGdNNmhpUitsWjdo?=
 =?utf-8?B?b0RLdUJOcjVqNDBhSGJoaEFPaS8zeVdHbFdNNDNzTWtOVWpXZ0dmcmJXMjZn?=
 =?utf-8?B?YWJOV2xUUW1ZK09nTjQwdTE5aEFrd0Q1MkNveUV1TlRCem8yVWw5d3ErWUR1?=
 =?utf-8?B?aUZhL0FkUjZaZDVJdjgwT1hKdXZvellmcWU5SE1jc1g2UEtxS3RSNUozNWhK?=
 =?utf-8?B?bUZlcnFybm9MVmFicmN1SXdGak1KSVZMd2tVWWFqTWU5RWtWUUQ4V0I2RjFJ?=
 =?utf-8?B?QVNtYmExVlV6RXQ3S1ZnYkFzSDdFN003b2VsYjJLYWFlQXp2K29EOUV3eXBW?=
 =?utf-8?B?d3JRM2ZqcWxONXBFQnRFbTBjZzU3OGE1R0thY0xtSGFWV3R3QVZpcXhZYWVC?=
 =?utf-8?B?SzVYSmhBN2lXUFN2L0ZUZmZ6eldkbVZsQlRnZHoybFVnOEwwWElMaXBxM3R2?=
 =?utf-8?B?YjBScTZXYVJrVDFiNXFhaTFpamhOM1Z5Vkptbm02R2FIdFYzVlpJYStPYlkv?=
 =?utf-8?B?MWlpLzJ2UEVidjVxRENJVDMyWkNjR3hyclljQWtEK1VZM09vVVZwY0M5eFVS?=
 =?utf-8?B?aDg3SFErdFJNakJVQmcra1lIWFAyRnZRWkUzNFNVSGx5Uk55aVlNUkdhbUQz?=
 =?utf-8?B?NSsvQlNZb3RHWkpRRmthOG5RajV6ZG5pUFdKL3RzN1pDQ2tubHdMQlFqam5w?=
 =?utf-8?B?OHpxWW5qMXpvL0xGZkMrL1NmQmxob3R4a2NSVU9lSFVrRWgzMmNudmVLdUp2?=
 =?utf-8?B?TzFuVS8yWllkcnB1L0NQVDZBaWFZZHRDTi9YdDUvT2Z5cWhsY0V1UC94RUhs?=
 =?utf-8?B?MDZoSHp3UjFzNk1odHRYOVZmbFNnOGNFdmJVYThHcWZiSFIzRHl1L0dQQktI?=
 =?utf-8?B?S2NOWkQzQ0wzekFSVGRmaHVNQTNRTnhXOUxPc1FlTGFvYTEzRGFKaDZJVHZx?=
 =?utf-8?B?N2NSMkwwRmc4ZkxDSng3RHE4NjMzNTV3cmh2Q2RIU0RNYTFPeWZJZzZpWCs5?=
 =?utf-8?B?dzFSaDFJdEtjUDA0SUJha1ZBNlVydmhWU25IanFkSjhsdko1aGMxaHJMNHY2?=
 =?utf-8?B?RnBFRTZ1Wnc3bXpabHJQdGY1ald5VzNFS3Q4U1hvZ1pFZGVmNXFtdWw3QWZv?=
 =?utf-8?B?YVpUaWt5Q0YxMnVWNjQxTGxxUytobzFTbkg0RU9OaVk3ZlJ5SzY0bStsNlNN?=
 =?utf-8?B?Z25XSVB6dVBMOU1LNSsxNElGcGY3NWNMUEZQYWl6NDR3TlZnTnA5ODI0STRz?=
 =?utf-8?B?d3ltdEdocDBLODZVU2lycWpKZjExY2prOU1LN1oxSTR1d2RHdEpmUVVCd01w?=
 =?utf-8?B?WlNtQ2pEeHp3Sk1kRVpkVFBEZHJHWG42WlJDT0pXQlhNbnlaTFJXTWRvZ1lX?=
 =?utf-8?B?WGZ6d0Y4aTBBb280TXppYllxbU9wTnF5dm15SVRVemhBNWtnaHJqdmlJMnVD?=
 =?utf-8?B?ZUxMSzlDekJNL2hMZGxIRVRpYSs1UzhxS0FxYXZRZnJrcmY1NlBvOGNVeVV1?=
 =?utf-8?B?cERQTXh1S3h4c3JNMzNGV1NTbTJKQ0pGSlhBay9RcGJLWWl1ZEdtOEtXMlZ1?=
 =?utf-8?B?MkI2SDhsOUNNdis4SGRNbUplME1oRXV1RGJVSGF0ZDdUSUJQcld3ci9UYmxZ?=
 =?utf-8?B?RjJFcW1SWFBxSlVGZ1crRE43SFY2dEp1dHNnakVqclJCQVdwK3grTXdFWlBC?=
 =?utf-8?B?QVZTQXhFSEVMZ3BqVFpKcFFJbk5iS0kvS0hXV3o2OUNGNnpSOUhydXpZVVY3?=
 =?utf-8?B?TWhGWFJNNnhJMWdvazdIS2dmS1h0ODI0WGg2LzNYNmVSbkV1ZXhLbWlGR2Fo?=
 =?utf-8?B?WmJuc0s5alNPQThuNEMyQTJXaWRKY080OUxWSzNyT3BEaXRraktMc2lhQlN4?=
 =?utf-8?B?L05XVy9nRlZXN1M2S2kzUTgwbkM3TTZVYjdHdGVOTXVScWE5a0VVc0I2WmJ3?=
 =?utf-8?B?UkZic0JXdDNZUW1xSllpNFdkQnd1WlhkcEpTYWw2UDc2OFhEVXRuOHFIeDZK?=
 =?utf-8?B?TkltUEllOXI1dktXNXdhbW8xM1RvQmxlY2tla1lYRmR2aHdxTGFuMWJyZzMy?=
 =?utf-8?B?Rmc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	iqTgV2v83L0tlHJBReuCNTYrTT/M21Q398rILog9RMMXI7ZI8Cmvd4PIiscYKcZlZ7D3iAM9yEuRon1bwbftBXuX8/6cLp8cvTS6i0jgv5xWk9Gg5sAoa4v6ueCqxi7fiuJDoFExER+AyJIVHyrq6P/SM14+KENLpx+5upN2RqJwUZiAKET/mpQhrFcSpM9Q2Y4ZG78MjLgOdrYGSoLSwKY733wvmo/wAoroa3sZsStvyHp7a0mxtEUzdWhdy051I8vW4f8F0h1DB7fi8hIyxx3x9vQ6nI1lly3BzK0wMiztQPCpVHrjVAXrZOtuSlLvC8IOOLyzov7Q3jCj92EpuI1vCZg44+gUP23Ddtvq6PTJEoLNAS72Bl9vD9FV1ty5MDcyot9lFVHzZ+B1DMYyXTaTa2PyrbhXWuduCpZgvvLLgmXUxK4nCaX4LupG/DQYLNiA93WWgXDeLo8MEm3R2roUSX+Scifz5m1maFoMKI/9H5JW7US6jnAM3r0hL8bIR3j2rPaFnXy3Suk/caK96wufY24svnCkJuioCO5Y53O+dUnAnabxCjgYDPRqeQxVzo/FwYZkal3aFgCLyK5YXy9L0yuhcZT74UlDFwBlu1M=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4f3e97bd-6a0e-4824-3427-08dc2891259d
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB5893.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2024 10:31:44.8457
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4Kw9Dxj+Wxui4Cgzx0XRRw7rr5KFIC1MtpBIAFBBhqFyjsBHrDJGSz/PiFHuj74cSi4VYJLtG8ZVfIKtL5LKsoeupigMxm8YoV/LlYV9k8Q=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7680
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-08_01,2024-02-07_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 phishscore=0
 spamscore=0 adultscore=0 mlxlogscore=999 malwarescore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402080054
X-Proofpoint-GUID: _zbO5R9M7lwNemlD30IFPeUFET5VufSW
X-Proofpoint-ORIG-GUID: _zbO5R9M7lwNemlD30IFPeUFET5VufSW

On 08/02/2024 09:14, Yi Liu wrote:
> Should set the SSADE (Second Stage Access/Dirty bit Enable) bit of the
> pasid entry when attaching a device to a nested domain if its parent
> has already enabled dirty tracking.
> 
> Fixes: 111bf85c68f6 ("iommu/vt-d: Add helper to setup pasid nested translation")
> Signed-off-by: Yi Liu <yi.l.liu@intel.com>

Reviewed-by: Joao Martins <joao.m.martins@oracle.com>

> ---
> base commit: 547ab8fc4cb04a1a6b34377dd8fad34cd2c8a8e3
> ---
>  drivers/iommu/intel/pasid.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/iommu/intel/pasid.c b/drivers/iommu/intel/pasid.c
> index 3239cefa4c33..9be24bb762cf 100644
> --- a/drivers/iommu/intel/pasid.c
> +++ b/drivers/iommu/intel/pasid.c
> @@ -658,6 +658,8 @@ int intel_pasid_setup_nested(struct intel_iommu *iommu, struct device *dev,
>  	pasid_set_domain_id(pte, did);
>  	pasid_set_address_width(pte, s2_domain->agaw);
>  	pasid_set_page_snoop(pte, !!ecap_smpwc(iommu->ecap));
> +	if (s2_domain->dirty_tracking)
> +		pasid_set_ssade(pte);
>  	pasid_set_translation_type(pte, PASID_ENTRY_PGTT_NESTED);
>  	pasid_set_present(pte);
>  	spin_unlock(&iommu->lock);