Received-SPF: pass (google.com: domain of linux-kernel+bounces-57871-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 8 Feb 2024 11:36:02 +0100
From: Sebastian Fricke <sebastian.fricke@collabora.com>
To: "jackson.lee" <jackson.lee@chipsnmedia.com>
Cc: mchehab@kernel.org, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org, nas.chung@chipsnmedia.com,
	lafley.kim@chipsnmedia.com, b-brnich@ti.com
Subject: Re: [RESEND PATCH v0 0/5] wave5 codec driver
Message-ID: <20240208103602.bnkhvoy5jnzns44i@basti-XPS-13-9310>
References: <20240131013046.15687-1-jackson.lee@chipsnmedia.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Disposition: inline
In-Reply-To: <20240131013046.15687-1-jackson.lee@chipsnmedia.com>

Hey Jackson,

On 31.01.2024 10:30, jackson.lee wrote:
>The wave5 codec driver is a stateful encoder/decoder.

You don't have to re introduce the driver here.

>The following patches is for supporting yuv422 inpuy format, supporting
>runtime suspend/resume feature and extra things.

Could you provide some test scores in your next patch version?
Interesting would be your score on V4L2-compliance and also the fluster
score for the decoder.

Greetings,
Sebastian
>
>jackson.lee (5):
>  wave5 : Support yuv422 input format for encoder.
>  wave5: Support to prepend sps/pps to IDR frame.
>  wave5 : Support runtime suspend/resume.
>  wave5: Use the bitstream buffer size from host.
>  wave5 : Fixed the wrong buffer size formula.
>
> .../platform/chips-media/wave5/wave5-hw.c     |  11 +-
> .../chips-media/wave5/wave5-vpu-dec.c         |  86 ++++------
> .../chips-media/wave5/wave5-vpu-enc.c         | 159 +++++++++++++++---
> .../platform/chips-media/wave5/wave5-vpu.c    |  68 ++++++++
> .../platform/chips-media/wave5/wave5-vpuapi.c |   7 +
> .../platform/chips-media/wave5/wave5-vpuapi.h |   1 +
> .../media/platform/chips-media/wave5/wave5.h  |   3 +
> 7 files changed, 255 insertions(+), 80 deletions(-)
>
>-- 
>2.43.0
>
>