Received-SPF: pass (google.com: domain of linux-kernel+bounces-57823-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <3e2c2def-e7d6-458f-81b3-ab666b41ad21@oracle.com>
Date: Thu, 8 Feb 2024 10:08:10 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH RFC 0/4] Introduce uts_release
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: mcgrof@kernel.org, russ.weight@linux.dev, gregkh@linuxfoundation.org,
        rafael@kernel.org, rostedt@goodmis.org, mhiramat@kernel.org,
        mathieu.desnoyers@efficios.com, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        keescook@chromium.org, nathan@kernel.org, nicolas@fjasle.eu,
        linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
        netdev@vger.kernel.org, linux-kbuild@vger.kernel.org
References: <20240131104851.2311358-1-john.g.garry@oracle.com>
 <CAK7LNATDMjzmgpBHZFTOJCkTCqpLPq8jEjdrwzEZ3uu7WMG7jg@mail.gmail.com>
 <23c67ffc-64a5-4e19-8fbd-ecb9bfe9d3ff@oracle.com>
 <CAK7LNASfTW+OMk1cJJWb4E6P+=k0FEsm_=6FDfDF_mTrxJCSMQ@mail.gmail.com>
Content-Language: en-US
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <CAK7LNASfTW+OMk1cJJWb4E6P+=k0FEsm_=6FDfDF_mTrxJCSMQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?ZVUzWXVOM1lBb1Zub2xKOG50ZnM0UEdFZnV2aW9US01pTlUzNVlMbHZBZCsv?=
 =?utf-8?B?SG5oeEZKV3JhRDBPWkErOUZxYm1ZTGRKUkd5dWdsbWhzeWZKckxlRlJ5MVlQ?=
 =?utf-8?B?OFRHZ3VWY3FNajBKUUNjMUhoeGhCczRsZlBrQ29lMnV5ZzBocmF6T2R6SGEv?=
 =?utf-8?B?V2NKZEZhbndEMXRPdHFMazdRaVMxNkFxNlFubnlDU0lpbzQybHcrVjVFVlhO?=
 =?utf-8?B?RXRid1ZIM3ljQm9TWmRFNFJmMXNXSC9IeFc1ZlZIaDVwaVpqdkFBMXhiSUxJ?=
 =?utf-8?B?RXJ5REpFQk5mNHVzNXordk52VGs4emFMUkdsdjhxM29GRUx0aC9hdmt4SjMw?=
 =?utf-8?B?UkxkMm5mZ1Q4OE96akc1clpqMVIzMWNhVTJZU2dsWWdjREtQK3BweXo5c1Jm?=
 =?utf-8?B?a3JRR1B3allQMkFDWjR3Y0NQUDdiNDFKUWFvbjJMVnRlMkJiT0NrZENFWWND?=
 =?utf-8?B?RXBObHI2Qi9JYU5VQytCVEtFRUJNa3BYd2VLbTNCbTRKLzgrbTlzVkZNM2hN?=
 =?utf-8?B?dGEwMXgrNEtONTlJVGxieGlBVkxia0d3YnYzNU5ROFk1Qk1xei8zaWU1cXpv?=
 =?utf-8?B?TXdXSXBueno0ZWFxMFZZRjBCdjF6QTRvcXlsUEpRL3RFOWdDajhwQ1VoLzQ0?=
 =?utf-8?B?VTdJSk1aTXpOcFl4VVRVc3pZdmFKV1ZMb1NpejNQdlhnTEF5TXFGbjdhYTU3?=
 =?utf-8?B?dnZGNUhLUEhEY1lONFUweVo3SURhNU5qTVdEQTN6YXJpUmd0eXUvWTdnTnEr?=
 =?utf-8?B?RDRqZXFtWjB1ZDRlWjRTS1UyQUN6WU1sUkdXOUhNVHdKOHUrZkQ5VGpmQWky?=
 =?utf-8?B?VHZiSVlGRG1pZTFMcTBnRUtXS2xqSEtJck9KazQ3RWpDdGxZQzRtdktxbU0z?=
 =?utf-8?B?bTl4WWlWZjB0Z3JzRTZRZ2V5SmFtZGlva081aUNCbzQ1Q3NZWmt0V1Z0SGZR?=
 =?utf-8?B?bFJMUjVFWEpQR01pQlV1eXZuQjZGbUNsZUtDS2lWaWN0NWIyY3Awd013YlpT?=
 =?utf-8?B?KzlpRWlkUjM2MFgvYlVOOC81NzA1MEVScUFEeEx6YkdwaEpXREkwdjF1c0pz?=
 =?utf-8?B?VVFFNmFyVnd0WktwS3JubWx0cHZPVHB3YzE5aHNMR1FlQ3BGUDZPdjJaL3FH?=
 =?utf-8?B?WG82MEM4STh3U1dkVXZ3MjZYYnFkbTdueWhoNzk0b0JVUTlrY2YzcVRhUnNO?=
 =?utf-8?B?OFByMkViMTJyOU1SeG5QYUcvbjBTUnhQb0dxUmNDSytjalJKcG8rTUNrbU9N?=
 =?utf-8?B?VzRPNUE3RmYrTG5kUVhzWk1rSnBJUGJmWlpYMk1MT281RWVNTzlkeldneE9R?=
 =?utf-8?B?ZjB6VW80TmFhTkdndVZGeUN2YUxrclpJcXR3OWUvVkMxMko2bkpPL0hyWElT?=
 =?utf-8?B?WDFlZ1FVT3lFaUY5anRuL2Z3NWVTZURjUW9VRHh1RHJqUndObW9WZGt2elFU?=
 =?utf-8?B?c01aalFQUmdVdUZxd25lQW1CY3pJWjQvRGk1WE05eHZtaXdKOEpDOTFpVEY1?=
 =?utf-8?B?SWhvQWVzSFNrOXlSbGRjNEVOUFZpdWVzYlN2U3YwWHc0d0ljU3ZVR1VZT3FO?=
 =?utf-8?B?ZWNOVFJMQlE3SFdZM1ZTdEdtMVBuUzJUOFU0MWt1MUN6RFF1cWd3QS9JK0x3?=
 =?utf-8?B?QVFRckgzS2F2SWwwOVF0VktNbzQ4emcralNtS2dXVm9SeVFwVVB3OTY4aDE1?=
 =?utf-8?B?bDh4RkhPY2pCdHoxWHpoL3dzZDVsTk9XSEVWUWpGQWxPNEU5aDV2SDEwTGxN?=
 =?utf-8?B?cUI4QnIzN0hzYnlRWVhFZ1QwdC9sRWE4ZGxVTlA0RURtbFpieWMyZTVDcndV?=
 =?utf-8?B?dzRSMDF1aWQydzFIVGZVSndqeFA2bzVwcXcwcU9RSHl4NGt4OXdRbVYwa3l4?=
 =?utf-8?B?R1gxdE42a3RxSjFxcnEvOVVGdnpkbU9GUE15Vzg1OGVZbWdZWXlvNFBMMUhh?=
 =?utf-8?B?d25sV090OERRVFl3OHYyV1l5UmtxaVN4TkV1SkpybUxqODZ1MVI1VVh1VzFr?=
 =?utf-8?B?aHdtRDI1L2NsUnJodEo0VGJHM0Z1TjhwTWpqWU1lZWxWTUZXQWtJYzFWREhX?=
 =?utf-8?B?Y00vQitXSWExUkhvVFdTT3Q0ajhIanY0WTBLSXF2bCtJNmVSelZWTWdKSmdH?=
 =?utf-8?B?dS84VldUblRyRnkvTDN2dmNoNmgwSTlHMjdoZXIweXRqUUgvUnIxQWNhOXFQ?=
 =?utf-8?B?NGc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	xIZ7fd2mCLRZTpye5npv/N2NuH/ow2m+rdDAtVujVH5kGraWLnQaH3+p0T6B08xYDyyt2Pda0plvNE72xAtO/nfN1UYE7//u+CpxB1wNCmsuuB9Co5l62Si+MB2dQgIBNzmiBVW6ztAfr8R1ll+ru245g1lOjv1qIQZX8nI49nji1Lc3aoGZ/r7qx0o8ouzLQ1pHG1/uv1cYPmyn6dUI4qXVJptLJbnDOk7HO430wpmUBfvu2QHCtHPOjSlSdAk7sh21hDyTbHFFyBsd8vrbO/6Q7puRNbnEHOpWB03rgB3p1Y/JAqbf6tfpJ8LIG+xQYCMh6SNA9Tjl9xhbeSB7qBftlGYik0xIBMC/zdcNFQ1GQzFBccf2tY2kLoUzh2X8JuMy3lj6fHuGGx33bIeoqJesMVK2R2lMhnwVC2syTTjTKPxWa2ctDb86uo2ORG01V+8Gw0u2GejPDtzlXnNEpovADom2FZ+Aep7I9UV9DWkrJxvsokCUJplrDqVGGwdKwX2alXME/ihHP05sVp89AalrTa2vk8SszdzLPPp6bokIIegbtI/a8oDy3Toyj+oW1Fqt1A/C3saTNzm5+B7rzlwLmPH/Ky2OZHXtKAd87Zs=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1284bc53-1623-4de5-f79c-08dc288ddd25
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2024 10:08:14.7512
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JJ6D5uKaYPJhuRtwIUCa5sxHXuvZOQKSJpewKv0PHHwQczs4kC1O9OQEMaxIEDHxABBP7nO9E6Kp+zzu7Mepsw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB7545
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-08_01,2024-02-07_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 phishscore=0
 spamscore=0 adultscore=0 mlxlogscore=999 malwarescore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402080053
X-Proofpoint-GUID: FksGEgrOWUpdDHoplmvNS-umbnPlQ2fB
X-Proofpoint-ORIG-GUID: FksGEgrOWUpdDHoplmvNS-umbnPlQ2fB

On 05/02/2024 23:10, Masahiro Yamada wrote:
>>> I think what you can contribute are:
>>>
>>>    - Explore the UTS_RELEASE users, and check if you can get rid of it.
>> Unfortunately I expect resistance for this. I also expect places like FW
>> loader it is necessary. And when this is used in sysfs, people will say
>> that it is part of the ABI now.
>>
>> How about I send the patch to update to use init_uts_ns and mention also
>> that it would be better to not use at all, if possible? I can cc you.
> 
> OK.
> 
> 
> As I mentioned in the previous reply, the replacement is safe
> for builtin code.
> 
> When you touch modular code, please pay a little more care,
> because UTS_RELEASE and init_utsname()->release
> may differ when CONFIG_MODVERSIONS=y.
> 

Are you saying that we may have a different release version kernel and 
module built with CONFIG_MODVERSIONS=y, and the module was using 
UTS_RELEASE for something? That something may be like setting some info 
in a sysfs file, like in this example:

static ssize_t target_core_item_version_show(struct config_item *item,
		char *page)
{
	return sprintf(page, "Target Engine Core ConfigFS Infrastructure %s"
		" on %s/%s on "UTS_RELEASE"\n", TARGET_CORE_VERSION,
		utsname()->sysname, utsname()->machine);
}

And the intention is to use the module codebase release version and not 
the kernel codebase release version. Hence utsname() is used for 
sysname and .machine, but not .release .

Thanks,
John