Received-SPF: pass (google.com: domain of linux-kernel+bounces-57862-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <9cc25d3b-58d1-4f87-ac68-0aa0310297e6@oracle.com>
Date: Thu, 8 Feb 2024 10:29:04 +0000
Subject: Re: [PATCH rc 6/8] iommu/vt-d: Remove @domain parameter from
 intel_pasid_setup_dirty_tracking()
Content-Language: en-US
To: Yi Liu <yi.l.liu@intel.com>
Cc: alex.williamson@redhat.com, robin.murphy@arm.com, eric.auger@redhat.com,
        nicolinc@nvidia.com, kvm@vger.kernel.org, chao.p.peng@linux.intel.com,
        yi.y.sun@linux.intel.com, iommu@lists.linux.dev,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        zhenzhong.duan@intel.com, joro@8bytes.org, jgg@nvidia.com,
        kevin.tian@intel.com, baolu.lu@linux.intel.com
References: <20240208082307.15759-1-yi.l.liu@intel.com>
 <20240208082307.15759-7-yi.l.liu@intel.com>
From: Joao Martins <joao.m.martins@oracle.com>
In-Reply-To: <20240208082307.15759-7-yi.l.liu@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?NVhPVnlJdU93UHA5cC9ubklRL256UXh2cTZZdW9hTDIyY0JvWDh5aVQyWTBR?=
 =?utf-8?B?cmNjSURPakVLNmdEVTBkWldFNEd1TU9BS1JkOUpzSm16QVBWcXhtclRsUlI3?=
 =?utf-8?B?RTlFVHc0NUx0UzcwcERDL2RRQ3JNSDVnZzVLdG5ldDlZRFdBRWZ0WktkSXpN?=
 =?utf-8?B?aVZyYUxIKzRLTFlsdXpDZjlOZFRoSmFISEUvc215VnkvVjFRTGp0ZHJyUUd5?=
 =?utf-8?B?Yk55S3lIeGdHenZia01TZVpBb1p6Ni9FODFTbUZiMmdjUHRWZDNyQzI3SUcz?=
 =?utf-8?B?N0gxUDZ2YnZ3MmY3c1EwejRmSUVSYk4vNzN3d2pCU1g1QUNETEdXeW1YRUJ3?=
 =?utf-8?B?UWJ1VFNpaHVMejFnVWMyWkNURUVHREdhdWpkQzUrSUdRbWU3cTY4OWdWaFA3?=
 =?utf-8?B?Szc3RXJrNGdYTFg2ckJJS0ljOVAzZnJkeWJ0cFRQTkl4Tk93NDBCeEJ2MG5S?=
 =?utf-8?B?QmVDNEUzaWJNQXlKNlZnSDQxdjhIU0xYNVcrWFp3QzF0aUxkWTBSK29GM3FK?=
 =?utf-8?B?emZMVE1BTjhyNEN1djluUitmVE9tRy9Db003NGhYTjZ0ZkZtMDhJa1M0V0l4?=
 =?utf-8?B?US9oM3NlWlZoMmZGZlpabDFmZjBvRnJnNEJ5TzcxMmtFcWtyQy8wLzNFU2dS?=
 =?utf-8?B?L0FTZmNoYmdTbUQrNEZYclQvRktLc0lMdXp5K0Z5VFJZV25FaWtra0swaFhr?=
 =?utf-8?B?dDdLb2VQekpyYThlRWVDazFCRHBnUklEamFWczVoTzJRcTIrOFhKMTNScTNi?=
 =?utf-8?B?UGtPZTZvZmNPSmE3LzZRcFN5RVdQZVROZlJoSEt2S2F6T0lWK2tHZ3NGOVp2?=
 =?utf-8?B?YkJxVDNaUkl6cHNHOFR3MENIN2l3YzRrRWZFTGJPUWllcHdXMk5YdUNhbGpQ?=
 =?utf-8?B?aFU0Njl3YUsxVDhabUdRMTJleEZTSmN1bHVRTVloZnlkZFB2RCthbzZxWUdM?=
 =?utf-8?B?M3hrdnpBeHlwNVRnTlVGYkVVcURLUnI2cVNPMlB1SWNKVTkyYXlzakVXOEpH?=
 =?utf-8?B?Ykd0WUh5SG43QkZRRjh5SjFadEZNMGFvN3VRblQ0NUFJdHI2V2VhY2NjYXJo?=
 =?utf-8?B?T0ZOMlZPTFJQK09Lc3pGSHFxTXNOL3pJR2pSL0o2b2dwUkxXb1ZMQUh4RnNT?=
 =?utf-8?B?MFU5YnByajJTbk9zcUJqWTNxTDZDRER5Vm1rQTlQd0JVK2dQNms4RGpreHdZ?=
 =?utf-8?B?cEhnU1YvNW9ienlTK2dvU0tFdzlhSlduY1RQRTEwakJveXVJNTBLby9kVnA0?=
 =?utf-8?B?K0VTajg5MDBycHBYa0JWZ1B6QUVIdTk1TlhUZUsvWEoxWG4zTEg5OWgxczU5?=
 =?utf-8?B?M3hpTDBhenZNUjQ2ZTNhTnVTOVArak94R0IxWTJjZStESkRDZTJXNjFDdGpH?=
 =?utf-8?B?T0k3OWlWR0JTNUwxaW1xMko2Sk4yMGdSRzlNeW5GbzBQVVpIaHdJTDBlTWgz?=
 =?utf-8?B?TDI1NlBNVGd3Qy9pTjdiek5PZHREWWN4cXUyeHlOVEI0ZWNNeE9LcjlHNCs0?=
 =?utf-8?B?UTd0SHNnZU5qRVIveHBCbGdkaVFYbUNYMkFZMXo4LzA4Y2IwNG9MbEtlWlBq?=
 =?utf-8?B?THpPdU9SV2g2dE1VRjBZcm9CdHQ5ck9yV3pGVmdsZmFsWTVIOHlrMVUwaGxx?=
 =?utf-8?B?S2hrMFhXdXplNk1PSFVJSjJPMFRBcXhBcUViNCsyRUI4dWl4eHlVc2xBcXNN?=
 =?utf-8?B?UlRkc2poVU1LMVc0SmlyYXdFb1kvNFp6d2tvV2djMUM1Nm5Dd0doNUtHOEVL?=
 =?utf-8?B?UU5pdWJMRHBqb1daU1YwYjRaa3ZUVzI0cmJkUzhFSjZTanhaQUc4V3Voc1ZY?=
 =?utf-8?B?NERFZVJubkFCL3ZLMXV0SlloMTJ0cHF6VXp2YlQ0dXpGVGR0TFFmeWJmejFD?=
 =?utf-8?B?MjIzbDRYNGdua2VBNkdWM0JrZWZkTEhhSzJaMU5rcStqeUo0cDVsZ0tvdWhk?=
 =?utf-8?B?NDVZZlZqZXU3S25GT3pZUmtMN2FuNXVnanpydEtqZ2tCZ0QrOFVGZEo5OHM2?=
 =?utf-8?B?czFTRzd3clpSTmtFU1V3TG5xVUZaZ3U1b1lFSUo5cklibG9XaXZJVW5CMGJV?=
 =?utf-8?B?c1BYVGlCcnhSeUlFbmFabVlkdjZMK3pZTzIrQXEvMXlvSDY5aXVPRmlwT1Vs?=
 =?utf-8?B?TlhWU3QwYjZ2d21rRGVTM2I2WHBsZ3JYMHRyMUlieWhGWlVvNGtZaWtwc1Q4?=
 =?utf-8?B?R3c9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	uSZ661dglNrbYOMs7agg1djvQUHOuGrIFIp6tNTQVkLEI8+FsJq160kmVtsPPGnoBMtGi6zhayXzkBOIZYhHGcgyhxMLtBNQyY3QmpnRvdF67iCEdMqTdTy2pn/6ser/igjKKKJViG7TE+78/270pAfz2IKSM8DXDl5FAEDHzOuds0chcRkgmn71NjSMMVapZNejXTlhKOX4AfsvaaBd6Ds2Ur8+0/Caumh/F09/5seWh7/DyuYFP1HjsAkpO0+aHvYjfsF37YRarm+e08fI4cWGKkiWMtl9U8WYeKZD8hTozM4q6/NLQG12PNWM52iNiozRx/Ys0JO3gKcD3G8BRX+T4/xBPpXgZKg6pMXTId3qoG3jeUCW6xthDg3dwebmrjFb+kI7vinT094+GYItt8LZja0c1ykDy7pt2UuUG9meEJDHnmtHy6Plog6DBsB8OjjEWKRJAz8/8A1Mthr+4gYXPXMoHUF5hPBarry42hBJAwddwW5JXuq7onpW+4pppqgND9YdYAexquzQQDhJssU2Bdn9NB9gmMIPX8Y5XQTtn6CO01oWjgVW0Wt+0nldgqYsWZDbyoDSE9yazDxSqnM0b/2Yc/F+GB0p2MH4HMs=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 813d2caf-eb79-43e1-98ee-08dc2890ca76
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB5893.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2024 10:29:11.9687
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: f8mV7V0zv0MNw8Wke2rN9Qzf51cpVIDaWIK2XLz/72Pbt8Lrl2bUjzzePMhg/Bt8swlGzsLW+t+Gb0ub+WMaiEkeNvittl9+pxiTlUBZxto=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4260
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-08_01,2024-02-07_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0
 mlxlogscore=999 suspectscore=0 adultscore=0 spamscore=0 malwarescore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2402080054
X-Proofpoint-ORIG-GUID: zqnH8P4LnUK2JbNPwcJ-8olVdevFl3do
X-Proofpoint-GUID: zqnH8P4LnUK2JbNPwcJ-8olVdevFl3do

On 08/02/2024 08:23, Yi Liu wrote:
> The only usage of input @domain is to get the domain id (DID) to flush
> cache after setting dirty tracking. However, DID can be obtained from
> the pasid entry. So no need to pass in domain. This can make this helper
> cleaner when adding the missing dirty tracking for the parent domain,
> which needs to use the DID of nested domain.
> 
> Signed-off-by: Yi Liu <yi.l.liu@intel.com>

Reviewed-by: Joao Martins <joao.m.martins@oracle.com>

> ---
>  drivers/iommu/intel/iommu.c | 7 +++----
>  drivers/iommu/intel/pasid.c | 3 +--
>  drivers/iommu/intel/pasid.h | 1 -
>  3 files changed, 4 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
> index c5a0275697cb..dae20991e036 100644
> --- a/drivers/iommu/intel/iommu.c
> +++ b/drivers/iommu/intel/iommu.c
> @@ -4742,8 +4742,7 @@ static int intel_iommu_set_dirty_tracking(struct iommu_domain *domain,
>  		goto out_unlock;
>  
>  	list_for_each_entry(info, &dmar_domain->devices, link) {
> -		ret = intel_pasid_setup_dirty_tracking(info->iommu,
> -						       info->domain, info->dev,
> +		ret = intel_pasid_setup_dirty_tracking(info->iommu, info->dev,
>  						       IOMMU_NO_PASID, enable);
>  		if (ret)
>  			goto err_unwind;
> @@ -4757,8 +4756,8 @@ static int intel_iommu_set_dirty_tracking(struct iommu_domain *domain,
>  
>  err_unwind:
>  	list_for_each_entry(info, &dmar_domain->devices, link)
> -		intel_pasid_setup_dirty_tracking(info->iommu, dmar_domain,
> -						 info->dev, IOMMU_NO_PASID,
> +		intel_pasid_setup_dirty_tracking(info->iommu, info->dev,
> +						 IOMMU_NO_PASID,
>  						 dmar_domain->dirty_tracking);
>  	spin_unlock(&dmar_domain->lock);
>  	return ret;
> diff --git a/drivers/iommu/intel/pasid.c b/drivers/iommu/intel/pasid.c
> index 3239cefa4c33..a32d7e509842 100644
> --- a/drivers/iommu/intel/pasid.c
> +++ b/drivers/iommu/intel/pasid.c
> @@ -428,7 +428,6 @@ int intel_pasid_setup_second_level(struct intel_iommu *iommu,
>   * Set up dirty tracking on a second only or nested translation type.
>   */
>  int intel_pasid_setup_dirty_tracking(struct intel_iommu *iommu,
> -				     struct dmar_domain *domain,
>  				     struct device *dev, u32 pasid,
>  				     bool enabled)
>  {
> @@ -445,7 +444,7 @@ int intel_pasid_setup_dirty_tracking(struct intel_iommu *iommu,
>  		return -ENODEV;
>  	}
>  
> -	did = domain_id_iommu(domain, iommu);
> +	did = pasid_get_domain_id(pte);
>  	pgtt = pasid_pte_get_pgtt(pte);
>  	if (pgtt != PASID_ENTRY_PGTT_SL_ONLY &&
>  	    pgtt != PASID_ENTRY_PGTT_NESTED) {
> diff --git a/drivers/iommu/intel/pasid.h b/drivers/iommu/intel/pasid.h
> index 8d40d4c66e31..487ede039bdd 100644
> --- a/drivers/iommu/intel/pasid.h
> +++ b/drivers/iommu/intel/pasid.h
> @@ -307,7 +307,6 @@ int intel_pasid_setup_second_level(struct intel_iommu *iommu,
>  				   struct dmar_domain *domain,
>  				   struct device *dev, u32 pasid);
>  int intel_pasid_setup_dirty_tracking(struct intel_iommu *iommu,
> -				     struct dmar_domain *domain,
>  				     struct device *dev, u32 pasid,
>  				     bool enabled);
>  int intel_pasid_setup_pass_through(struct intel_iommu *iommu,