Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759558AbXLUM0X (ORCPT ); Fri, 21 Dec 2007 07:26:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751321AbXLUM0Q (ORCPT ); Fri, 21 Dec 2007 07:26:16 -0500 Received: from brick.kernel.dk ([87.55.233.238]:7434 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751091AbXLUM0Q (ORCPT ); Fri, 21 Dec 2007 07:26:16 -0500 Date: Fri, 21 Dec 2007 13:26:19 +0100 From: Jens Axboe To: Adrian McMenamin Cc: linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org, Paul Mundt Subject: Re: [PATCH - SH/Dreamcast] Add support for GD-Rom device Message-ID: <20071221122619.GC11583@kernel.dk> References: <8b67d60712201559h5dbb2a17q8f16223b26b88006@mail.gmail.com> <8b67d60712201607k66d67fa2la8b21fc698fdb3ab@mail.gmail.com> <20071221121441.GB11583@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071221121441.GB11583@kernel.dk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 998 Lines: 34 On Fri, Dec 21 2007, Jens Axboe wrote: > static void gdrom_readdisk_dma(struct work_struct *work) > { > ... > > read_command = kzalloc(sizeof(struct packet_command), GFP_KERNEL); > if (!read_command) > probably just defer the work to some time later > > spin_lock(&gdrom_lock); > while (!list_empty(&gdrom_deferred)) { > req = list_entry(gdrom_deferred.next, struct request, queuelist); > list_del_init(&req->queuelist); > spin_unlock(&gdrom_lock); > > ... > > spin_lock(&gdrom_lock); > }; > + spin_unlock(&gdrom_lock); > kfree(read_command); > } is missing, of course. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/