Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp224523rdb; Thu, 8 Feb 2024 04:22:55 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXR/7PGPwrfBU6MmpvoQq34IBYNeHXtkmV176O5zkpJpNUKq+jjV3HioLRTpNIZfRR2wrlyHd3AveiScQb41dajNUS2l1vx+uW3nr1adQ== X-Google-Smtp-Source: AGHT+IGLgNcbbd0Ym0lZTycYtRatx+Iro6AfZXkgVdpL7WUSYGUkRZVHwt71a8AOWHw8lJI41rhN X-Received: by 2002:a17:902:b414:b0:1d9:143b:eaf with SMTP id x20-20020a170902b41400b001d9143b0eafmr6607196plr.61.1707394975438; Thu, 08 Feb 2024 04:22:55 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707394975; cv=pass; d=google.com; s=arc-20160816; b=LEK28S4Ef+E8ZXGmkXIoEHdh6E3EjmBjzZ7vmFfDexSlX/HHX/SX6ifctU01eP46sx LYt7kwJbx/jlCOmQA35hz4r6lj30YRc/WTrpWOUGIERDUdPhbRbLyVkXZvSiJtCu5eGX 2e+SqfrBfPM7V9074yOxlpjyBFIM9WqseXXmHjhRzQSdis4u/ygjiC8Sk+jqR692w5lI 7sKlq5zjyDmlcO3Hle7GWTjGUAJ8HooVzYwEifVoi4zA6Wxv/F3oJI7519ie76podnuW /5wZQZ9TMXuKiA0i6s52vhUR1R93xvHsAN3z9piVbxIiZ3YkkwUX2fI1OjLEjJyNjuLv ZFnA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=iBRxCFNg530HZ3mowLtmdXeppw43BoOmKkPx98+KxGQ=; fh=G6T0bc+TUcT5djHDiKurNtS6TflGLjfpDwiOq4I1KWQ=; b=JJZrItrU1XcClICQG4aXnBZPtSrTUYU/Wj9WnwYrbkocYTx1bMM8X2cUA8jFvRuEJY YFSd40uyXodQd6/ZJfBHSP8lCeLCYudvEYwDmD475aiWw3RFBAEEV0HgsdzlilxQmcmK iXAmCXO34Xh++DL32ZqQiFAG5T+oCmkAltl5NcLFGQm4/G5cYUXTSEMwPeDqrIDhmmoJ UyWzGU4J/dGYic6JWIw4JJZvugEEVNjtPl+kf7PwphBRqxj7opbmU/nd6ZNKmf4rsJlk 3qIhAesEOuMbid8DEj7pHYKq5xZncRwvY5OtDHCN/hFIhyAsb9eXI6aReO+5K+h0ZkE8 5QFw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=K8GvBnLw; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-58047-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-58047-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org X-Forwarded-Encrypted: i=2; AJvYcCVSWMDwr/bROSRD6zK6NQ4cGtom1Bfzw4GyMCI15GIzGADAEcmEpMz0MGjc3914gV99dMqNwSvBJakehHPbsFIjNu/5RDdQsBqCGhD4Ug== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id p14-20020a170902e74e00b001d97e406c32si4554450plf.46.2024.02.08.04.22.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 04:22:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-58047-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=K8GvBnLw; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-58047-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-58047-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 027E0286F7B for ; Thu, 8 Feb 2024 12:21:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5DEFF763E0; Thu, 8 Feb 2024 12:21:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="K8GvBnLw" Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0DA476021 for ; Thu, 8 Feb 2024 12:20:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707394859; cv=none; b=qqYHTgytXb1OK02pywX7gDraiYkpKJLITyHIpGZmY6/AkvU2czH7HL1qLcSpJIfBdMlLEe4R36ddyi2Cl6HInjf3W3F/wr7t+jZ9Ul0ydFNP1hqgUSRUeZF1ZvJHMGsLD65BlWtfFLkv43NOkBWkaw+F+qrRN2EPDNH3CAoVUvY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707394859; c=relaxed/simple; bh=iBRxCFNg530HZ3mowLtmdXeppw43BoOmKkPx98+KxGQ=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=KvFd9jSAcrCqe53L9vkpGdR3xA0ROES9Oab+eu33hmOUxzRcZpl86s6ymhcycaCeq86gVzfyxqq40PJbX+5tEg0wXVIGpc3E+fan2mWkiIS6p0Rp+124WWti0dPpQhOw2T6E6J77a63BxitEKPcWn4E+klGfbBbkGu6kwM4Dh/A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=K8GvBnLw; arc=none smtp.client-ip=209.85.128.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-604b0ae6babso1581767b3.3 for ; Thu, 08 Feb 2024 04:20:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707394856; x=1707999656; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=iBRxCFNg530HZ3mowLtmdXeppw43BoOmKkPx98+KxGQ=; b=K8GvBnLwHDN4ObdcyJyFaoH9q+VbIqnV8NsNRrlyp58VcSfxZMGELlSZF45/KXtbx9 qCJK5qlXOeFGVP2fL0KJeboSCqV0mit4eQ5ofcOWREo+cdmzcubPlKbGxpCortBifVch il2W/xp68lTaFbrOvKMoEF++Xsqir1pHh+wnty2utmZrqHH/sgn7nwaFh43+tHWoc/6k o9Ll1eU8Jo4FHthMwC6UHUOwKlZSSRhGcNN+cM7svR9WXa4yUzAfCusHM3hunkOkms/p c/B5TpVaqHTwUd3xxNeeHPxa/BJ/PK/TnVz2Yht5T+/0WJSTTvKE9QSFLhSw20zGHFij 8wAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707394856; x=1707999656; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iBRxCFNg530HZ3mowLtmdXeppw43BoOmKkPx98+KxGQ=; b=dpIwoq9oP1/Dw160rrmhE8JELPx92HKIiNYkYxUXIN+jupzly7zJo/G77/wDhgxRmA 83TGRRvlIvd2smwkHb6BSQAJR+3TOnGGADLi7aEYt0/mxUAK8U9CeCwONPDBxX7cHf14 d9UAOTQjaMSD1g3ipHqqJzVw9PXYel8Jq64Xr+uwKdYmfkcHcl1kKKOokqSstit4eQXF Hzan2llsG7pAFTFRlm5OmtDAE2wvFtMEdmswpukMBovTU81tIsAvghZ4v0LtX9TuhSFX NrAt/NhL0o51dbeSmR2XLAUeHWSWFACiTbZ6Qhh4BWughNOqVGwKOluQYOk0YuqIqIzN lsTw== X-Forwarded-Encrypted: i=1; AJvYcCVMUun2oVgcEEg3p+LpABMypZ6Tdyrp7VnsdaLhmQr9i6wFs9u8o0z+FgRgzyHnwLFMKzBrAr2xvsa0sr9GNEKDuyMersFBQ/lf1l6e X-Gm-Message-State: AOJu0YyzfFQ7VIEkqGscCLM9CRyQ7DUdFwqsmdGz/m4QIUOM64QrhmRM /tvg3RDwhMebBncxGfzHms/S6HPrw1OfrCyOd6gsBNpujfNLDs9IPWgq2iHKIvf6maqxxgyfnmq /46p3o9RauMqPClhJMjAlwNyl7BJgcQm5cB+9Lw== X-Received: by 2002:a81:b3c1:0:b0:604:7a6a:9d58 with SMTP id r184-20020a81b3c1000000b006047a6a9d58mr8271515ywh.25.1707394856481; Thu, 08 Feb 2024 04:20:56 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240208095920.8035-1-brgl@bgdev.pl> <20240208095920.8035-17-brgl@bgdev.pl> In-Reply-To: <20240208095920.8035-17-brgl@bgdev.pl> From: Linus Walleij Date: Thu, 8 Feb 2024 13:20:45 +0100 Message-ID: Subject: Re: [PATCH v3 16/24] gpio: sysfs: don't access gdev->chip if it's not needed To: Bartosz Golaszewski Cc: Kent Gibson , Alex Elder , Geert Uytterhoeven , "Paul E . McKenney" , Andy Shevchenko , Wolfram Sang , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Feb 8, 2024 at 10:59=E2=80=AFAM Bartosz Golaszewski = wrote: > From: Bartosz Golaszewski > > Don't dereference gdev->chip if the same information can be obtained > from struct gpio_device. > > Suggested-by: Andy Shevchenko > Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij Yours, Linus Walleij