Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp224526rdb; Thu, 8 Feb 2024 04:22:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IFYnu6sahzMKcCOrNgsL4LbpT8XMth4NwaALxvG66/uZ0H1LXwII/qpB3m/kiEL4fUUfzQ4 X-Received: by 2002:ad4:5ca6:0:b0:68c:75e8:7d7d with SMTP id q6-20020ad45ca6000000b0068c75e87d7dmr9785537qvh.60.1707394975801; Thu, 08 Feb 2024 04:22:55 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707394975; cv=pass; d=google.com; s=arc-20160816; b=zzvLOcQDM8uSsUToPd+Sq1L0OdqqYatrRsBzheZ3MiK3BeMUF+aZUn/+TDVL2k4784 OIsn+nlsGEJzuOrbhUhtukmfC6a2aOVu+H3WH+avLkpodlXYGWjVtCGI8FrzODDrba5h DBI5lv2OsnMVooXl64ESDLWNetD5p1S5ZJkKHGPilEfd5WCBnbGZN85tOxNbdD98wgRW xrKNSUdVroHEFEDjVDlqEA8IdA9m1N0UgBPEufSi6R1DlZPMv6qohPT/QDDQO6H905iE Bb1jH5BP7G+tN48POc+CojeeVoUn+KTsq4Wr/Do4dLaEkjIhsBHLm+kUo739RXb17+Xf qIew== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=c7XAvXW3JqDQu3a1gMUnXDEqNL5QzKj2+D77O+/2mAI=; fh=kqMKy6FazqrFeq0QBRzYVMJvAOWWTDUsXpuIMy5HJak=; b=OpJQYHuAbk2vG8SBTKn7kbPfpalgCciB6SNGsSx9AF8q0aBHfDOkh09dFFHmplMEyv krgN1BeSEeIbgk2t+z13tofPqIm/GT09dQ73Cl2lx3Zh6wQNq9ZVEaxzAlDcnoR5FWhv 6qOyKVndB9nOqjbpKrOGj/27fMsddozSlnLoy4rLsltUIEkOsVqajjTRP6QHvzY0KzmJ uRAMkBqTbCSqdCzz2EdVxwakigSjqKJsw932ta20D8AvUjEZlsC1Wx9ApycrNMaScfey sjCqj9jCrFsk/uBuS/qbj3li+ia8PW7wVEj+Lc3k+t/DqHbdpa0+qtGBlWGint/grEud bQSg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nmr8nhgL; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-58048-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-58048-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org X-Forwarded-Encrypted: i=2; AJvYcCXufT1akTo5UgpPBXfCbV38zOCq7dWl4wuYcG1DzQke5pbpVYT9VgIxoTVAA3AstBVRPsctfXNyfixXR3Wr9g5+LyxxXNkZP1614VQL9A== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id q8-20020ad45ca8000000b0068caee7da29si3514723qvh.110.2024.02.08.04.22.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 04:22:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-58048-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nmr8nhgL; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-58048-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-58048-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 24F251C2679F for ; Thu, 8 Feb 2024 12:21:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AD45F76046; Thu, 8 Feb 2024 12:21:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nmr8nhgL" Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6E9C7604D for ; Thu, 8 Feb 2024 12:21:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707394890; cv=none; b=gH1pNJjJ+5/P34iR6rwF3Enc7/n3Lg+nUvFhKEiE8XWUE1Wn1Qmr1R5izBSdDRVXpWEgZY9mbKLBVaJUPAe34sCCJ/HNAwezOhkBa9djT+AbYvjyW8riUuF3TbwlVMDJLROxIlNucwtFNw/EkV11HIwZgKUMH5xvB5uzmyIMQ9A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707394890; c=relaxed/simple; bh=c7XAvXW3JqDQu3a1gMUnXDEqNL5QzKj2+D77O+/2mAI=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=ZptWK3si7HnrWYpe8m1ZEYhs8APz2vZcnZsOLMsmo8wrg3EcDkwURZ1em82jzEpV21QsocWZz7VR2wDAwlQnhGih68HgDtMQPJYwLvXodqnTI/dwMAOMR0KJjCvPQWVfSwXOGwZQSxXDanBliuv7R0DkACRTK38h2psjIMtAzj4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=nmr8nhgL; arc=none smtp.client-ip=209.85.128.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-604ab54bb83so3845027b3.1 for ; Thu, 08 Feb 2024 04:21:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707394887; x=1707999687; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=c7XAvXW3JqDQu3a1gMUnXDEqNL5QzKj2+D77O+/2mAI=; b=nmr8nhgLZPJ++N2Jp7Q0EweSK3WAkfvn7DK8N5vw5hOeM/cAIIuS8/C5xfpTrOZkPX 5pxp3Swlj4UBdLR9M8AEkePwJhNQcKsx7sv0sG+OBEGep5QNu5BJGOhs8QXCXwtS/6qX pSYfN3nD14pZZZX8x8IR6WkfKl0FG6THUQmaYeqB1InNUqIO2KnXMimEt+DU+r98iF8i k+kRCewlC87n6N/5iTkAfnwlXxfDhe8rhipFvm+joU9cYWhMR9J88KhJKCv2RfTVAlTy 1NbvsW7p5Wvq//ASOwdC1haSjfkM3HOj7S3XB4N1haDkq4vL4n/7E/1hviTs2HKQ+AI0 uO/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707394887; x=1707999687; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c7XAvXW3JqDQu3a1gMUnXDEqNL5QzKj2+D77O+/2mAI=; b=vt/nJDJjrZuMqjOJQ6MSVsm5ya7Xk5uOU+ofEfU+sbWLsvlA1sBJB2ZdaL1JFbdlcp xUPp4hy3Qz1WJ7PDfCfceYHpIBgXLFIXN1KY80hK1j5wf6mf5Atw/a+wag5kGFNheRUy OcL6dk6XzPqqLlCChFED7Tr2TTDMJXjn6NkiNEpmB7abWDNQHwe7aW5BDhqenhIsxIZH l6fG396KgF3Lnb6RxVyOly9m4dlDgSARg+xrASZfpBwsodASzvkjdKNxYzyfICoFu7JW z1C7MAR3sfDj7o3wJJmN/y+sFvCDmgon0XhPXzpmHflnlnKBEc31UQnP+8+MtcG89k3X jp2Q== X-Gm-Message-State: AOJu0Yw8V85VlKPz7YRQoG/aXMs31XfgKDDjFRcJ27MQd5IMwwlIW5Ot b+HNeqrk1HabEl3rcdRm9tDuBx+/ov3macvu4HuAe0cUmo8ZtyyqpVhMTqA1qvF1UApPdqwS9+i O2xlRpu6PBYhYexeR/Nx/Q8DFc/Mz+VUDhAJGeQ== X-Received: by 2002:a81:e443:0:b0:5ff:9676:3658 with SMTP id t3-20020a81e443000000b005ff96763658mr7587421ywl.48.1707394887647; Thu, 08 Feb 2024 04:21:27 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240208095920.8035-1-brgl@bgdev.pl> <20240208095920.8035-18-brgl@bgdev.pl> In-Reply-To: <20240208095920.8035-18-brgl@bgdev.pl> From: Linus Walleij Date: Thu, 8 Feb 2024 13:21:16 +0100 Message-ID: Subject: Re: [PATCH v3 17/24] gpio: don't dereference gdev->chip in gpiochip_setup_dev() To: Bartosz Golaszewski Cc: Kent Gibson , Alex Elder , Geert Uytterhoeven , "Paul E . McKenney" , Andy Shevchenko , Wolfram Sang , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Feb 8, 2024 at 10:59=E2=80=AFAM Bartosz Golaszewski = wrote: > From: Bartosz Golaszewski > > We don't need to dereference gdev->chip in gpiochip_setup_dev() as at > the time it's called, the label in the associated struct gpio_device is > already set. > > Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij Yours, Linus Walleij