Received: by 2002:a05:7412:3b8b:b0:fc:a2b0:25d7 with SMTP id nd11csp230726rdb; Thu, 8 Feb 2024 04:34:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IGkLnev4U2YW3B4bjoLkE9Ddo5BZHniHzcaLS7S9CWcT+cY0Pl6S3LnoO/EqB8DvS89gbnJ X-Received: by 2002:a05:6a20:9d94:b0:19e:9bc1:df61 with SMTP id mu20-20020a056a209d9400b0019e9bc1df61mr8763045pzb.50.1707395676202; Thu, 08 Feb 2024 04:34:36 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707395676; cv=pass; d=google.com; s=arc-20160816; b=gFcKtB/F+O0en/tVQuChthloEsihfyKFuG1i+pC/S9TGoI8OYqupWJaEdEpOd3dx94 /6Y+gK/cdT9mjWJ27BQ+riTUyDWOX5DEo1u+Ji2nMSr+ZaXvsbW6RyWdvChTXXY0iYgj jD/B7nyudXcZ1w6aA/QDy8WI15YgGlRY0aGloZCjw5aE/9y+uR7pmISxh1+awDdGPAUd V6yU9ZYFIBcIfaspwWIYoZwjsfkaQZ958iWV7+cyqnYB5zL3CnrTnrMxgc3X6d/Thhdk OWw4+XbQ9I8blNTtR/urLaRXbIRgbzKW6t9QWCYnvDQpr79UhymFReXx6ubfG8bQq/N4 LrOQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=LFohAqcwHqGuwSh8U95371hYU/NXi/YIftlluaNzgcs=; fh=VXfAmT1u4ZEtUkdwAjbQ7hvrCGbzsaIjucCYiLympwU=; b=OsHclrkposEmx97VI0wKIG0JuzupqmAE0hUvc0QP+h5KOUaU/2cu4Z5QAyVQdni2aa Hw3SPWs0XTm0sWt522k7+9bP59buShi16LJpGr2BoKLgogRLhcsOSU+ln2vGvJq15Ahm 4LNcN5eb1Z7UnImqHc/6U8L8v7A5fFSqVbAY2+5cmpoDn5df5MgTU2F/xkEpfRFQ4nke 2GrZTy5m1dt/ScoREoeFBgPVz42rmRemQicjljxqg+u8CLxQdSEnMRgT5VkZ3Dr939Mp 1waNk4gfIfYaL+94fEO++IgqZrN9qlaBgdUWtPS0zcG6atxSBiaXvSgloFCGjG76jHV4 s0VQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@atomide.com header.s=25mailst header.b=LOUDwAWe; arc=pass (i=1 dkim=pass dkdomain=atomide.com); spf=pass (google.com: domain of linux-kernel+bounces-57593-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-57593-linux.lists.archive=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=2; AJvYcCVPy7xtm8xexWG4mlkmwFriuSNr5thJjYSjQUHCwa+ka4ATEJ2vs85Go8tKmUDeuxDRToyiFz7lxODMmubarDi0NeFU/9EIna8ecvIOzw== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id p21-20020a637415000000b005dc488101casi1130704pgc.341.2024.02.08.04.34.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 04:34:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-57593-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@atomide.com header.s=25mailst header.b=LOUDwAWe; arc=pass (i=1 dkim=pass dkdomain=atomide.com); spf=pass (google.com: domain of linux-kernel+bounces-57593-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-57593-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 0A286283656 for ; Thu, 8 Feb 2024 08:14:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 07E876A032; Thu, 8 Feb 2024 08:13:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=atomide.com header.i=@atomide.com header.b="LOUDwAWe" Received: from mail5.25mail.st (mail5.25mail.st [74.50.62.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49DE36A03A; Thu, 8 Feb 2024 08:13:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.50.62.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707380034; cv=none; b=Ph46zr57ALJHmaETCVEMumdTUB08t7829+MC0sLIxwUtQ0UVNwGGHHm5QPha7wljpn19XVT2ZBpkrLeqDKs/MV1vLS639osEdQVi4Z9mqetfLvvj/v222QStCQvAGeWSyN1zwdngw5E0PYThZ/xvIgO9lZ8B57aTsPs34FSJcEM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707380034; c=relaxed/simple; bh=LFohAqcwHqGuwSh8U95371hYU/NXi/YIftlluaNzgcs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=D1nPWYAPX/ViCq5Qk8cA+/pmBKsIRM3anw5GBvWtpS1tEzt3l08Mc/Cag3kXJTAsAOVlCCDkZPfqY8zS0Ph3g1Tsy+Wv9ukXMenHpXMoL7+BElSf+R9kpFIMnREU3/8FZuvYOqDMUdbbx/FXERdOyDPduald06dskVsihhEG074= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com; spf=fail smtp.mailfrom=atomide.com; dkim=pass (2048-bit key) header.d=atomide.com header.i=@atomide.com header.b=LOUDwAWe; arc=none smtp.client-ip=74.50.62.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=atomide.com Received: from localhost (91-158-86-216.elisa-laajakaista.fi [91.158.86.216]) by mail5.25mail.st (Postfix) with ESMTPSA id A4F60603F4; Thu, 8 Feb 2024 08:13:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=atomide.com; s=25mailst; t=1707380025; bh=LFohAqcwHqGuwSh8U95371hYU/NXi/YIftlluaNzgcs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LOUDwAWef0wGBHc1K0Sizi+WgSJcc491FzEJrY2mlV7cJ5ky2R27R++QPMOvFe6Jz f6bk0O0rLVjZ4UrvJgeGf327K043lXsuZePC4DsBYjidpXsRwjLPtkOBl84loSPkhX JdhiEWwiM0/bkA7s8bDiv1001tkGQYlR1ODEqenTZzrblGMXkbvsuk6ZiYmeN5TRLP 1akTBcstpH1j2z3iZSKeZTwv1BBNz+wYA1AYhTtxRYWqVwoo573xBmIJx0nRo6wDaD ldX4NQL+dpYGlq8wn4hF4ldtRLzea8HQkizegHxWQMm9X8fyo3xHuZTFHEjAHEJSb2 7C7MWtOxgFddA== Date: Thu, 8 Feb 2024 10:13:15 +0200 From: Tony Lindgren To: Yicong Yang Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, john.ogness@linutronix.de, andriy.shevchenko@linux.intel.com, tglx@linutronix.de, yangyicong@hisilicon.com, linuxarm@huawei.com, prime.zeng@hisilicon.com, jonathan.cameron@huawei.com, fanghao11@huawei.com Subject: Re: [PATCH v3] serial: port: Don't suspend if the port is still busy Message-ID: <20240208081315.GA52537@atomide.com> References: <20240208075216.48915-1-yangyicong@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240208075216.48915-1-yangyicong@huawei.com> * Yicong Yang [240208 07:56]: > Reviewed-by: Tony Lindgren > --- > Change since v2: > - Narrow the spinlock region per Andy > - Make __serial_port_busy() return -EBUSY if port has pending chars per Andy > Thanks. > Link: https://lore.kernel.org/all/20240206073322.5560-1-yangyicong@huawei.com/ Looks good to me thanks. Regards, Tony